Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
Bug ID: 919100 Summary: Review Request: crudini - A utility for manipulating ini files Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: jruzicka@redhat.com
Spec URL: http://srck.cz/pkg/crudini/crudini.spec SRPM URL: http://srck.cz/pkg/crudini/crudini-0.1-1.fc18.src.rpm Description: A utility for manipulating ini files Fedora Account System Username: jruzicka
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
Antonio Trande trpost@katamail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |trpost@katamail.com
--- Comment #1 from Antonio Trande trpost@katamail.com --- Hi Jakub.
I don't see any License file; it's fundamental. http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
You should seek to add a %check section, a tests directory is available although a instruction file doesn't exist. http://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites
You can use %{name} instead crudimi.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
Pádraig Brady p@draigbrady.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |p@draigbrady.com Assignee|nobody@fedoraproject.org |p@draigbrady.com Flags| |fedora-review?
--- Comment #2 from Pádraig Brady p@draigbrady.com --- I'd update the long description to: A utility for easily handling ini files from the command line and shell scripts
spec needs: Requires: python-iniparse
%check would be something like: pushd tests ./test.sh popd
I've just tagged 0.2 to include the COPYING text which you can add to %doc
thanks! Pádraig
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
--- Comment #3 from Jakub Ruzicka jruzicka@redhat.com --- Updated version 0.3: Spec URL: http://srck.cz/pkg/crudini/crudini.spec SRPM URL: http://srck.cz/pkg/crudini/crudini-0.3-1.fc18.src.rpm
Changelog: - New version 0.3 includes COPYING licence file. - Improved description. - Added python-iniparse dependency. - Added tests check.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
--- Comment #4 from Jakub Ruzicka jruzicka@redhat.com --- Updated version 0.3-2: Spec URL: http://srck.cz/pkg/crudini/crudini.spec SRPM URL: http://srck.cz/pkg/crudini/crudini-0.3-2.fc18.src.rpm
Added missing BuildRequires.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
Pádraig Brady p@draigbrady.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #5 from Pádraig Brady p@draigbrady.com --- looks good, thanks!
Package Review ==============
Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/padraig/919100-crudini/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 4 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment).
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: crudini-0.3-2.fc15.noarch.rpm crudini.noarch: W: spelling-error Summary(en_US) ini -> uni, in, ii crudini.noarch: W: spelling-error %description -l en_US ini -> uni, in, ii crudini.noarch: W: no-manual-page-for-binary crudini 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint crudini crudini.noarch: I: enchant-dictionary-not-found en_US crudini.noarch: W: no-manual-page-for-binary crudini 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:'
Requires -------- crudini (rpmlib, GLIBC filtered): /usr/bin/python python-iniparse
Provides -------- crudini: crudini
MD5-sum check ------------- https://github.com/pixelb/crudini/archive/0.3.tar.gz : CHECKSUM(SHA256) this package : 0194fd92314e3c1f53178daf93a69ee95df68766acf53e5d580396cbe6c996ed CHECKSUM(SHA256) upstream package : 0194fd92314e3c1f53178daf93a69ee95df68766acf53e5d580396cbe6c996ed
Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-15-x86_64 Command line :/usr/bin/fedora-review -b 919100
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mrunge@redhat.com
--- Comment #6 from Matthias Runge mrunge@redhat.com --- Jakub, I sponsored you into the packager group. Please go ahead and request branches.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
--- Comment #7 from Jakub Ruzicka jruzicka@redhat.com --- New Package SCM Request ======================= Package Name: crudini Short Description: A utility for manipulating ini files Owners: jruzicka Branches: f17 f18 f19 el6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
Jakub Ruzicka jruzicka@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ | Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
Jakub Ruzicka jruzicka@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ Flags| |fedora-cvs?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- crudini-0.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/crudini-0.3-2.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- crudini-0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/crudini-0.3-2.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- crudini-0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/crudini-0.3-2.el6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- crudini-0.3-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-04-02 21:59:54
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- crudini-0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- crudini-0.3-2.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919100
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- crudini-0.3-2.fc18 has been pushed to the Fedora 18 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla