[Bug 1702822] New: Review Request: golang-tinygo-x-llvm - Go bindings to a system-installed LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1702822
Bug ID: 1702822 Summary: Review Request: golang-tinygo-x-llvm - Go bindings to a system-installed LLVM Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: quantum.analyst@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://qulogic.fedorapeople.org//golang-tinygo-x-llvm.spec SRPM URL: https://qulogic.fedorapeople.org//golang-tinygo-x-llvm-0-0.1.20190418git7707...
Description: Go bindings to a system-installed LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1702822
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=34394141
https://bugzilla.redhat.com/show_bug.cgi?id=1702822
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- - Your patch should have the extension .patch or .diff, not .go
- BUILDDIR=/usr → BUILDDIR=%{_prefix}
- Your changelog entry contains erroneous Version-Release:
* Thu Apr 18 2019 Elliott Sales de Andrade quantum.analyst@gmail.com - 0-0.1-20190418git7707ae5
- The license is BSD, not "LLVM's license"
License: BSD
- Add a comment justifying the patch, a PR would be nice.
May I suggest using go2rpm: https://pagure.io/GoSIG/go2rpm It needs beta testers. Use: go2rpm -p1 tinygo.org/x/go-llvm -f https://github.com/tinygo-org/go-llvm
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 35 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/golang-tinygo-x- llvm/review-golang-tinygo-x-llvm/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8.
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Test run failed [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-tinygo-x-llvm-devel-0-0.1.20190424git7707ae5.fc31.noarch.rpm golang-tinygo-x-llvm-0-0.1.20190424git7707ae5.fc31.src.rpm golang-tinygo-x-llvm-devel.noarch: W: invalid-license LLVM's license golang-tinygo-x-llvm-devel.noarch: W: no-documentation golang-tinygo-x-llvm-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/tinygo.org/x/go-llvm/.goipath golang-tinygo-x-llvm.src: W: invalid-license LLVM's license golang-tinygo-x-llvm.src: W: no-%build-section golang-tinygo-x-llvm.src: E: specfile-error warning: %gochecks is obsolete, use %gocheck in %check instead! 2 packages and 0 specfiles checked; 1 errors, 6 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1702822
--- Comment #3 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Oops, forgot to finish up a few things there. Should be fixed now:
Spec URL: https://qulogic.fedorapeople.org/golang-tinygo-x-llvm.spec SRPM URL: https://qulogic.fedorapeople.org/golang-tinygo-x-llvm-0-0.1.20190418git7707a...
https://bugzilla.redhat.com/show_bug.cgi?id=1702822
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- You forgot:
- Add a comment justifying the patch, a PR link would be nice.
It is important for the SIG to know if the patch has been upstreamedxand if it can be removed in a future version.
Package approved. Please fix the aforementioned issue before import.
https://bugzilla.redhat.com/show_bug.cgi?id=1702822
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-tinygo-x-llvm
https://bugzilla.redhat.com/show_bug.cgi?id=1702822
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- golang-tinygo-x-llvm-0-0.1.20190427git7707ae5.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-63aeb5559d
https://bugzilla.redhat.com/show_bug.cgi?id=1702822
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-tinygo-x-llvm-0-0.2.20190427git7707ae5.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-63aeb5559d
https://bugzilla.redhat.com/show_bug.cgi?id=1702822
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-05-05 02:19:32
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-tinygo-x-llvm-0-0.2.20190427git7707ae5.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com