[Bug 2387625] New: Review Request: cellbroadcastd - DBus daemon for cellular broadcast messages
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
Bug ID: 2387625 Summary: Review Request: cellbroadcastd - DBus daemon for cellular broadcast messages Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: lihis@lihis.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://codeberg.org/Lihis/cellbroadcastd-spec/raw/commit/1e240f01d1279e4a37... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/6185/135936185/cellbroadcastd... Description: cellbroadcastd provides DBus daemon manages cell broadcast messages received via ModemManager. It offers a library (libcellbroadcast) and GObject introspection bindings to ease using it from applications. Fedora Account System Username: lihis
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
Tomi Lähteenmäki lihis@lihis.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2387375
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2387375 [Bug 2387375] phosh-mobile-settings-0.49_rc1 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.freedesktop. | |org/devrtz/%{name}
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9398494 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Systemd user unit service file(s) in cellbroadcastd Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |ngompa13@gmail.com Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Spec review notes:
Source: %{url}/-/archive/v%{version}/%{name}-v%{version}.tar.gz Source: https://gitlab.gnome.org/GNOME/gvdb/-/archive/%%7Bgvdb_commit%7D/gvdb-%%7Bgv...
Please number your sources, since you have multiple ones. It may not be required, but it makes it more coherent.
ExcludeArch: i686
This should be "ExcludeArch: %{ix86}"
%autosetup -a1 -n %{name}-v%{version} mv gvdb-%{gvdb_commit} subprojects/gvdb
This can be simplified to the following:
%autosetup -n %{name}-v%{version} tar -xf %{S:1} -C subprojects/gvdb
%files -n libcellbroadcast-devel %{_includedir}/libcellbroadcast-0.0/ %{_libdir}/libcellbroadcast-0.0.so %{_libdir}/pkgconfig/libcellbroadcast-0.0.pc %changelog %autochangelog
This is missing a newline after the last files entry to separate sections.
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
Tomi Lähteenmäki lihis@lihis.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@gmail.co | |m)
--- Comment #4 from Tomi Lähteenmäki lihis@lihis.net --- Spec URL: https://codeberg.org/Lihis/cellbroadcastd-spec/raw/commit/57045aafbe12f4cbe7... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1658/136171658/cellbroadcastd...
Numbered the sources, fixed the "ExcludeArch" and added the missing newline.
This can be simplified to the following:
%autosetup -n %{name}-v%{version} tar -xf %{S:1} -C subprojects/gvdb
Why this is better than having the "-a1" for %autosetup?
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2103936 --> https://bugzilla.redhat.com/attachment.cgi?id=2103936&action=edit The .spec file difference from Copr build 9398494 to 9437833
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9437833 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Systemd user unit service file(s) in cellbroadcastd Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
--- Comment #7 from Tomi Lähteenmäki lihis@lihis.net ---
This can be simplified to the following:
%autosetup -n %{name}-v%{version} tar -xf %{S:1} -C subprojects/gvdb
Why this is better than having the "-a1" for %autosetup?
Well, it removes the need for move and the "-a1" flag.. Posting updated spec soon
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
--- Comment #8 from Tomi Lähteenmäki lihis@lihis.net --- Spec URL: https://codeberg.org/Lihis/cellbroadcastd-spec/raw/commit/cdb802d2139a2f70da... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4293/136174293/cellbroadcastd...
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2103940 --> https://bugzilla.redhat.com/attachment.cgi?id=2103940&action=edit The .spec file difference from Copr build 9437833 to 9438236
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9438236 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Systemd user unit service file(s) in cellbroadcastd Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@gmail.co | |m) |
--- Comment #11 from Neal Gompa ngompa13@gmail.com --- Spec review notes:
There's a missing desktop-file-validate call in %check for installed .desktop file in %{_datadir}/applications.
Also, one other piece...
%build %meson -Dsystemd_user_unit_dir="%{_userunitdir}"
This should be in %conf instead of %build unless you plan to build this for < EPEL 10.
For an example, see: https://src.fedoraproject.org/rpms/wayback/blob/rawhide/f/wayback.spec
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
Tomi Lähteenmäki lihis@lihis.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@gmail.co | |m)
--- Comment #12 from Tomi Lähteenmäki lihis@lihis.net --- Spec URL: https://codeberg.org/Lihis/cellbroadcastd-spec/raw/commit/89a6a05699cd79e7d0... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/990/136400990/cellbroadcastd-...
There's a missing desktop-file-validate call in %check for installed .desktop file in %{_datadir}/applications.
Upstream tests [1] already validates it but added explicit check.
Also, one other piece...
%build %meson -Dsystemd_user_unit_dir="%{_userunitdir}"
This should be in %conf instead of %build unless you plan to build this for < EPEL 10.
For an example, see: https://src.fedoraproject.org/rpms/wayback/blob/rawhide/f/wayback.spec
I see, thanks! I'll send a PR to update Packaging Guidelines for Meson as its example SPEC [2] does not contain %conf at all.
[1] https://gitlab.freedesktop.org/devrtz/cellbroadcastd/-/blob/7229aad3bb60521a... [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Meson/#_example_rp...
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
--- Comment #13 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2104577 --> https://bugzilla.redhat.com/attachment.cgi?id=2104577&action=edit The .spec file difference from Copr build 9438236 to 9461965
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
--- Comment #14 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9461965 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Systemd user unit service file(s) in cellbroadcastd Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
--- Comment #15 from Tomi Lähteenmäki lihis@lihis.net --- @ngompa do you have time to check this?
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ |needinfo?(ngompa13@gmail.co | |m) |
--- Comment #16 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package follows Fedora packaging guidelines * Package builds and installs * Package licensing is correct and license data is installed * No serious issues from rpmlint
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #17 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/cellbroadcastd
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-401cc63851 (cellbroadcastd-0.0.2-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-401cc63851
https://bugzilla.redhat.com/show_bug.cgi?id=2387625
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2025-09-01 19:53:04
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-401cc63851 (cellbroadcastd-0.0.2-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com