https://bugzilla.redhat.com/show_bug.cgi?id=2091372
Bug ID: 2091372 Summary: Review Request: oxygen-sounds - The Oxygen Sound Theme Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: marcdeop@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://marcdeop.fedorapeople.org/oxygen-sounds.spec SRPM URL: https://marcdeop.fedorapeople.org/oxygen-sounds-5.24.90-1.fc35.src.rpm Description: The Oxygen Sound Theme Fedora Account System Username: marcdeop
https://bugzilla.redhat.com/show_bug.cgi?id=2091372
marcdeop@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from marcdeop@fedoraproject.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Creative Commons CC0 1.0", "*No copyright* BSD 2-Clause License", "GNU Lesser General Public License, Version 3", "Unknown or generated", "*No copyright* GNU Lesser General Public License, Version 3". 50 files have unknown license. Detailed output of licensecheck in /home/marc.deop-private/rpmbuild/SPECS/oxygen- sounds/licensecheck.txt [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2160640 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- http://download.kde.org/unstable/plasma/5.24.90/oxygen-sounds-5.24.90.tar.xz : CHECKSUM(SHA256) this package : d64f11952fdb71bb54f7092bb49cada5ffbd8751d2c3cccec5ae3a2af4ed325f CHECKSUM(SHA256) upstream package : d64f11952fdb71bb54f7092bb49cada5ffbd8751d2c3cccec5ae3a2af4ed325f
Requires -------- oxygen-sounds (rpmlib, GLIBC filtered):
Provides -------- oxygen-sounds: oxygen-sound-theme oxygen-sounds oxygen-sounds(x86-64)
Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review --rpm-spec -n /home/marc.deop-private/rpmbuild/SRPMS/oxygen-sounds-5.24.90-1.fc35.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: R, C/C++, SugarActivity, Java, Python, Ocaml, Haskell, Perl, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2091372
Onuralp Sezer thunderbirdtr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |thunderbirdtr@gmail.com Flags| |fedora-review? CC| |thunderbirdtr@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=2091372
--- Comment #2 from Onuralp Sezer thunderbirdtr@gmail.com --- I am taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2091372
--- Comment #3 from Onuralp Sezer thunderbirdtr@gmail.com ---
First please change license section into this one (https://fedoraproject.org/wiki/Licensing:Main)
License: LGPLv3+,CC0,BSD
Second you're not installing via "cmake" file and since you're were only copying "sound" files as installation, which means we can remove these BR(s)
BuildRequires: extra-cmake-modules BuildRequires: cmake BuildRequires: qt5-qtbase-devel
Also %build section is empty which means we don't need no debug variable as well
# debuginfo.list ends up empty/blank anyway. disable %global debug_package %{nil}
And we make it "noarch" since this is just a "sound package" It is not depend on any arch as well.
BuildArch: noarch
You're also missing license section in files so we need that to as well.
%files %license LICENSES/*.txt
https://bugzilla.redhat.com/show_bug.cgi?id=2091372
--- Comment #4 from marcdeop@fedoraproject.org --- (In reply to Onuralp Sezer from comment #3)
First please change license section into this one (https://fedoraproject.org/wiki/Licensing:Main)
License: LGPLv3+,CC0,BSD
Added
Second you're not installing via "cmake" file and since you're were only copying "sound" files as installation, which means we can remove these BR(s)
BuildRequires: extra-cmake-modules BuildRequires: cmake BuildRequires: qt5-qtbase-devel
Removed. I should have catched this initially. Apologies
Also %build section is empty which means we don't need no debug variable as well
# debuginfo.list ends up empty/blank anyway. disable %global debug_package %{nil}
This was only there because rpmlint was giving me a warning for not having a %build section and the moment I added it then I was getting an error only solvable by adding this.
Regardless, I've removed the %build section altogether (even with the W from rpmlint)
And we make it "noarch" since this is just a "sound package" It is not depend on any arch as well.
BuildArch: noarch
Done
You're also missing license section in files so we need that to as well.
%files %license LICENSES/*.txt
Done
https://bugzilla.redhat.com/show_bug.cgi?id=2091372
Onuralp Sezer thunderbirdtr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Onuralp Sezer thunderbirdtr@gmail.com --- Also in case of repository changes (we discuss this in kde meeting) please add back BR cmake and install vith "cmake" way macro but keep noarch. So in future when cmake changes or files updated. We don't have to do change spec file too. That means you should add back build section as well. Rest is LGTM. I'm approving package but please do changes as well.
Thank you.
Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2091372
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/oxygen-sounds
https://bugzilla.redhat.com/show_bug.cgi?id=2091372
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2091372
marcdeop@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |COMPLETED Status|ASSIGNED |CLOSED Last Closed| |2023-03-20 08:48:47
--- Comment #7 from marcdeop@fedoraproject.org --- This was done months ago :-)
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com