[Bug 2150511] New: Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust

https://bugzilla.redhat.com/show_bug.cgi?id=2150511

Bug ID: 2150511
           Summary: Review Request: rust-kamadak-exif - Exif parsing
                    library written in pure Rust
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://kalev.fedorapeople.org/rust-kamadak-exif.spec
SRPM URL: https://kalev.fedorapeople.org/rust-kamadak-exif-0.5.5-1.fc38.src.rpm
Description:
Exif parsing library written in pure Rust.

Fedora Account System Username: kalev

[Bug 2150511] Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust

https://bugzilla.redhat.com/show_bug.cgi?id=2150511

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |2150509

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2150509
[Bug 2150509] Review Request: rust-mutate_once - Interior mutability,
write-once and borrowable as plain &T

[Bug 2150511] Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust

https://bugzilla.redhat.com/show_bug.cgi?id=2150511
Bug 2150511 depends on bug 2150509, which changed state.

Bug 2150509 Summary: Review Request: rust-mutate_once - Interior mutability, write-once and borrowable as plain &T
https://bugzilla.redhat.com/show_bug.cgi?id=2150509

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE

[Bug 2150511] Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust

https://bugzilla.redhat.com/show_bug.cgi?id=2150511

--- Comment #1 from Kalev Lember  ---
OK, rust-mutate_once is now imported, which unblocks this. Upstream has nicely
added a LICENSE file in the mean time so I've gone ahead and copied it
downstream as well.

* Thu Mar 23 2023 Kalev Lember  - 0.5.5-2
- Add missing LICENSE file from upstream

Spec URL: https://kalev.fedorapeople.org/rust-kamadak-exif.spec
SRPM URL: https://kalev.fedorapeople.org/rust-kamadak-exif-0.5.5-2.fc39.src.rpm

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=99064259

[Bug 2150511] Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust

https://bugzilla.redhat.com/show_bug.cgi?id=2150511

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://crates.io/crates/ka
                   |                            |madak-exif

--- Comment #2 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5701847
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2150511] Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust

https://bugzilla.redhat.com/show_bug.cgi?id=2150511

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |fedora-review+
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]

--- Comment #3 from Fabio Valentini  ---
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (BSD-2-Clause) and is acceptable for
Fedora
- license file is included with %license in %files (included from upstream git)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Please regenerate the spec file with rust2rpm v24 before importing the package.

[Bug 2150511] Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust

https://bugzilla.redhat.com/show_bug.cgi?id=2150511

--- Comment #4 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-kamadak-exif

[Bug 2150511] Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust

https://bugzilla.redhat.com/show_bug.cgi?id=2150511

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #5 from Kalev Lember  ---
Thanks for the review, Fabio! Package imported and build is under way.
> Please regenerate the spec file with rust2rpm v24 before importing the package.

Why? There are no changes in the generated spec file as much as I can see,
except for the "# Generated by rust2rpm 23" comment.

[Bug 2150511] Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust

https://bugzilla.redhat.com/show_bug.cgi?id=2150511

--- Comment #6 from Fabio Valentini  ---
(In reply to Kalev Lember from comment #5)
> Thanks for the review, Fabio! Package imported and build is under way.
> > Please regenerate the spec file with rust2rpm v24 before importing the package.
>
> Why? There are no changes in the generated spec file as much as I can see,
> except for the "# Generated by rust2rpm 23" comment.

Then it should be fine ... the only reason might be that I track packages by
those comments and regenerate the oldest ones from time to time (in part
because of the Fedora -> SPDX license tags thing), but rust2rpm v22+ should
default to SPDX anyway.

[Bug 2150511] Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust

https://bugzilla.redhat.com/show_bug.cgi?id=2150511

--- Comment #7 from Kalev Lember  ---
Ah, makes sense, thanks.

[Bug 2150511] Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust

https://bugzilla.redhat.com/show_bug.cgi?id=2150511

--- Comment #8 from Fedora Update System  ---
FEDORA-2023-f1fc171396 has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-f1fc171396

[Bug 2150511] Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust

https://bugzilla.redhat.com/show_bug.cgi?id=2150511

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2023-04-02 22:16:26

--- Comment #9 from Fedora Update System  ---
FEDORA-2023-f1fc171396 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.