Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: spacenavd - A free, compatible alternative for 3Dconnecxion's input drivers
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Summary: Review Request: spacenavd - A free, compatible alternative for 3Dconnecxion's input drivers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: hobbes1069@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://hobbes1069.fedorapeople.org/spacenavd/spacenavd.spec SRPM URL: http://hobbes1069.fedorapeople.org/spacenavd/spacenavd-0.5-1.fc15.src.rpm Description: Spacenavd, is a free software replacement user-space driver (daemon), for 3Dconnexion's space-something 6dof input devices. It's compatible with the original 3dxsrv proprietary daemon provided by 3Dconnexion, and works perfectly with any program that was written for the 3Dconnexion driver.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Richard Shaw hobbes1069@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |spacenavd
--- Comment #1 from Richard Shaw hobbes1069@gmail.com 2011-08-17 15:17:51 EDT --- rpmlint output:
# ls *.rpm spacenavd-0.5-1.fc15.src.rpm spacenavd-debuginfo-0.5-1.fc15.x86_64.rpm spacenavd-0.5-1.fc15.x86_64.rpm
# rpmlint *.rpm spacenavd.src:32: W: rpm-buildroot-usage %build %configure --prefix=%{buildroot}%{_prefix}
Necessary because make file does not support DESTDIR
spacenavd.x86_64: W: no-manual-page-for-binary spacenavd
Is a daemon, not an end user binary.
spacenavd.x86_64: W: no-manual-page-for-binary spnavd_ctl
Not sure what to do here, upstream doesn't provide anything beyond a README.
spacenavd.x86_64: W: service-default-enabled /etc/rc.d/init.d/spacenavd
You'll only install this if you need to so should be on by default.
spacenavd.x86_64: W: incoherent-subsys /etc/rc.d/init.d/spacenavd $prog
Rpmlint has issues with $ variables in init scripts which is why this is a warning and not an error. Not really a problem.
3 packages and 0 specfiles checked; 0 errors, 5 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rdieter@math.unl.edu AssignedTo|nobody@fedoraproject.org |rdieter@math.unl.edu Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(hobbes1069@gmail. | |com)
--- Comment #2 from Rex Dieter rdieter@math.unl.edu 2011-08-19 10:07:22 EDT --- Initial review:
naming: ok
scriptlets: ok, though would be nice to investigate proper/native systemd init support
licensing: ok
sources: ok 0bb21da5315bd376aa508157a9455aaa spacenavd-0.5.tar.gz
MUST: build doesn't use $RPM_OPT_FLAGS , please fix.
Else, pretty small simple, fix the optflags thing, and looks like we have a winner.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Richard Shaw hobbes1069@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(hobbes1069@gmail. | |com) |
--- Comment #3 from Richard Shaw hobbes1069@gmail.com 2011-08-19 10:54:54 EDT --- (In reply to comment #2)
scriptlets: ok, though would be nice to investigate proper/native systemd init support
This was my first attempt at a daemon and didn't feel competent to do a systemd unit but if you want to help me I'm all for it.
Here's my first attempt: [Unit] Description=Spacenav Daemon After=syslog.target
[Service] Type=Simple ExecStart=/usr/bin/spacenavd
[Install] WantedBy=graphical.target
MUST: build doesn't use $RPM_OPT_FLAGS , please fix.
Fixed.
Let me know if you want to move forward with a systemd unit or not then I'll post an updated spec and SRPM.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Richard Shaw hobbes1069@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: spacenavd - |Review Request: spacenavd - |A free, compatible |A free, compatible |alternative for |alternative for |3Dconnecxion's input |3Dconnexion's input drivers |drivers |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Rex Dieter rdieter@math.unl.edu 2011-08-19 11:06:38 EDT --- Hrm, systemd support can just as easily be developed outside of or after pkg review. (imo, better than way).
I'll take your word that you've got the optflags thing nailed, (and will verify upon git import, and slap you with a wet noodle if they're still missing... :) )
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Richard Shaw hobbes1069@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Flag| |fedora-cvs?
--- Comment #5 from Richard Shaw hobbes1069@gmail.com 2011-08-19 13:40:18 EDT --- New Package SCM Request ======================= Package Name: spacenavd Short Description: A free, compatible alternative for 3Dconnexion's input drivers Owners: hobbes1069 Branches: f15 f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
--- Comment #6 from Jon Ciesla limb@jcomserv.net 2011-08-19 13:46:20 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
--- Comment #7 from Jóhann B. Guðmundsson johannbg@hi.is 2011-08-22 20:50:50 EDT --- Created attachment 519375 --> https://bugzilla.redhat.com/attachment.cgi?id=519375 Native systemd service file for spacenavd daemon
As requested on -devel starts/restarts/stops cleanly
https://fedoraproject.org/wiki/Packaging:Guidelines:Systemd https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd http://fedoraproject.org/wiki/Packaging:Tmpfiles.d
Btw is it not mandatory now to provide native systemd units for new packages I certainly hope so...
Oh and dont forget to submit the unit file upstream thanks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
--- Comment #8 from Richard Shaw hobbes1069@gmail.com 2011-08-22 21:16:47 EDT --- Thanks! It's funny. I just finished trying out a systemd based version of my package based on Lennart's input.
I like the StandardError on yours so I'll definitely use that.
As far as the target, mulit-user would work but I chose graphical since there is really no use for this outside of a graphical environment. Is there a reason to choose multi-user that I'm not aware of?
Thanks, Richard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Jóhann B. Guðmundsson johannbg@hi.is changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |johannbg@hi.is
--- Comment #9 from Jóhann B. Guðmundsson johannbg@hi.is 2011-08-23 05:42:09 EDT --- Nope not really (In reply to comment #8)
Thanks! It's funny. I just finished trying out a systemd based version of my package based on Lennart's input.
I like the StandardError on yours so I'll definitely use that.
As far as the target, mulit-user would work but I chose graphical since there is really no use for this outside of a graphical environment. Is there a reason to choose multi-user that I'm not aware of?
Not really the graphical target pulls in the multi user one but you are right we really should tie desktop only service to the graphical.target ( or create a specific desktop target for that).
I also noticed spacenavd could be started in a non daemon mode if you need/want a unit file for that this should suffice..
[Unit] Description=3Dconnexion Input Devices Userspace Driver After=syslog.target
[Service] ExecStart=/usr/bin/spacenavd -d StandardError=syslog
[Install] WantedBy=graphical.target
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-08-25 13:45:34 EDT --- spacenavd-0.5-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/spacenavd-0.5-2.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-08-25 13:45:42 EDT --- spacenavd-0.5-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/spacenavd-0.5-2.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-08-26 10:19:54 EDT --- spacenavd-0.5-2.fc16 has been pushed to the Fedora 16 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-09-06 20:27:41 EDT --- spacenavd-0.5-2.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |spacenavd-0.5-2.fc15 Resolution| |ERRATA Last Closed| |2011-09-06 20:27:46
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-09-06 23:29:41 EDT --- spacenavd-0.5-2.fc16 has been pushed to the Fedora 16 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|spacenavd-0.5-2.fc15 |spacenavd-0.5-2.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=731519
John Morris john@zultron.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |john@zultron.com
--- Comment #15 from John Morris john@zultron.com --- Package Change Request ====================== Package Name: spacenavd New Branches: el6 Owners: zultron hobbes1069 InitialCC:
The owner of this package (hobbes1069) and I (zultron) are building this package for EPEL6.
https://bugzilla.redhat.com/show_bug.cgi?id=731519
John Morris john@zultron.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ | Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=731519
--- Comment #16 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Richard Shaw hobbes1069@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?
--- Comment #17 from Richard Shaw hobbes1069@gmail.com --- Package Change Request ====================== Package Name: spacenavd New Branches: epel7 Owners: zultron hobbes1069 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=731519
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=731519
--- Comment #18 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org