[Bug 1197642] New: Review Request: ghc-data-hash - Combinators for building fast hashing functions - package-review

List overview All Threads
Download

newer

[Bug 1197642] New: Review Request: ghc-data-hash - Combinators for building fast hashing functions

older

[Bug 1197337] New: Review Request:...

[Bug 1200241] New: Review Request:...

Red Hat Bugzilla

2 Mar 2015 2 Mar '15

3:52 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

Bug ID: 1197642 Summary: Review Request: ghc-data-hash - Combinators for building fast hashing functions Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: petersen@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: http://petersen.fedorapeople.org//ghc-data-hash.spec SRPM URL: http://petersen.fedorapeople.org//ghc-data-hash-0.2.0.0-1.fc21.src.rpm

Description: Combinators for building fast hashing functions. Includes hashing functions for all basic Haskell98 types.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

2 Mar 2 Mar

3:52 a.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

--- Comment #1 from Jens Petersen petersen@redhat.com --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9117540

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:55 a.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

Jens Petersen petersen@redhat.com changed:

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1164120 [Bug 1164120] Agda-2.4.2.2 is available

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:35 p.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

Ben Boeckel mathstuf@gmail.com changed:

--- Comment #2 from Ben Boeckel mathstuf@gmail.com --- Would be nice to have AUTHORS in %doc.

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 194560 bytes in 23 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: ghc-data-hash-0.2.0.0-1.fc23.x86_64.rpm ghc-data-hash-devel-0.2.0.0-1.fc23.x86_64.rpm ghc-data-hash-0.2.0.0-1.fc23.src.rpm ghc-data-hash.x86_64: W: spelling-error Summary(en_US) Combinators -> Combinations, Combination, Contaminators ghc-data-hash.x86_64: W: spelling-error %description -l en_US Combinators -> Combinations, Combination, Contaminators ghc-data-hash.src: W: spelling-error Summary(en_US) Combinators -> Combinations, Combination, Contaminators ghc-data-hash.src: W: spelling-error %description -l en_US Combinators -> Combinations, Combination, Contaminators 3 packages and 0 specfiles checked; 0 errors, 4 warnings.

Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:

Requires -------- ghc-data-hash-devel (rpmlib, GLIBC filtered): /bin/sh ghc(data-hash-0.2.0.0-821e6d6cc0f3d28c3228b30f83b9ceca) ghc-compiler ghc-data-hash(x86-64) ghc-devel(array-0.5.0.0-ce080a527b3819e94d851f7f80ca77dd) ghc-devel(base-4.7.0.2-cb23b5265b6e147094c0cd9ac819acb1) ghc-devel(containers-0.5.5.1-d7910f1cd81272c1f31ca9f71d0f206e)

ghc-data-hash (rpmlib, GLIBC filtered): ghc(array-0.5.0.0-ce080a527b3819e94d851f7f80ca77dd) ghc(base-4.7.0.2-cb23b5265b6e147094c0cd9ac819acb1) ghc(containers-0.5.5.1-d7910f1cd81272c1f31ca9f71d0f206e) libHSarray-0.5.0.0-ghc7.8.4.so()(64bit) libHSbase-4.7.0.2-ghc7.8.4.so()(64bit) libHScontainers-0.5.5.1-ghc7.8.4.so()(64bit) libHSdeepseq-1.3.0.2-ghc7.8.4.so()(64bit) libHSghc-prim-0.3.1.0-ghc7.8.4.so()(64bit) libHSinteger-gmp-0.5.1.0-ghc7.8.4.so()(64bit) libc.so.6()(64bit) libgmp.so.10()(64bit) rtld(GNU_HASH)

Provides -------- ghc-data-hash-devel: ghc-data-hash-devel ghc-data-hash-devel(x86-64) ghc-data-hash-static ghc-devel(data-hash-0.2.0.0-821e6d6cc0f3d28c3228b30f83b9ceca)

ghc-data-hash: ghc(data-hash-0.2.0.0-821e6d6cc0f3d28c3228b30f83b9ceca) ghc-data-hash ghc-data-hash(x86-64) libHSdata-hash-0.2.0.0-ghc7.8.4.so()(64bit)

Unversioned so-files -------------------- ghc-data-hash: /usr/lib64/ghc-7.8.4/data-hash-0.2.0.0/libHSdata-hash-0.2.0.0-ghc7.8.4.so

Source checksums ---------------- https://hackage.haskell.org/package/data-hash-0.2.0.0/data-hash-0.2.0.0.tar.... : CHECKSUM(SHA256) this package : 35b39a4ec9efaad0c1fac2c1d5f7b6fe4717a67935a8f9d6c372bce9085bdaad CHECKSUM(SHA256) upstream package : 35b39a4ec9efaad0c1fac2c1d5f7b6fe4717a67935a8f9d6c372bce9085bdaad

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64-bb-tmpfs --bug 1197642 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Haskell, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:58 p.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

Jens Petersen petersen@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #3 from Jens Petersen petersen@redhat.com --- Thanks for the review!

New Package SCM Request ======================= Package Name: ghc-data-hash Short Description: Combinators for building fast hashing functions Upstream URL: https://hackage.haskell.org/package/data-hash Owners: petersen Branches: f22 f21 f20 epel7 InitialCC: haskell-sig

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3 Mar 3 Mar

7:25 a.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:25 a.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 Mar 4 Mar

4:35 a.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:35 a.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

--- Comment #5 from Fedora Update System updates@fedoraproject.org --- ghc-data-hash-0.2.0.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/ghc-data-hash-0.2.0.0-1.fc22

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:35 a.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

--- Comment #6 from Fedora Update System updates@fedoraproject.org --- ghc-data-hash-0.2.0.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/ghc-data-hash-0.2.0.0-1.fc21

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:36 a.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

--- Comment #7 from Fedora Update System updates@fedoraproject.org --- ghc-data-hash-0.2.0.0-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/ghc-data-hash-0.2.0.0-1.el7

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:36 a.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- ghc-data-hash-0.2.0.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-data-hash-0.2.0.0-1.fc20

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:08 p.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- ghc-data-hash-0.2.0.0-1.fc22 has been pushed to the Fedora 22 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

13 Mar 13 Mar

12:17 p.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

Fedora Update System updates@fedoraproject.org changed:

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- ghc-data-hash-0.2.0.0-1.fc22 has been pushed to the Fedora 22 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

18 Mar 18 Mar

5:36 a.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

Fedora Update System updates@fedoraproject.org changed:

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- ghc-data-hash-0.2.0.0-1.fc21 has been pushed to the Fedora 21 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2 Apr 2 Apr

10:38 a.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

Fedora Update System updates@fedoraproject.org changed:

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- ghc-data-hash-0.2.0.0-1.fc20 has been pushed to the Fedora 20 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:51 p.m.

New subject: [Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions

https://bugzilla.redhat.com/show_bug.cgi?id=1197642

Fedora Update System updates@fedoraproject.org changed:

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- ghc-data-hash-0.2.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3765

Age (days ago)

3796

Last active (days ago)

package-review@lists.fedoraproject.org

16 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla