Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Bug ID: 924513 Summary: Review Request: zanata-api - Zanata API modules Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: pahuang@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://fedorapeople.org/~pahuang/zanata-api.spec SRPM URL: http://fedorapeople.org/~pahuang/zanata-api-2.2.0-1.fc17.src.rpm Description: Zanata API modules. Shared between client and server. Fedora Account System Username: pahuang
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Patrick Huang pahuang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183 (FE-JAVASIG)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #1 from Patrick Huang pahuang@redhat.com --- amended after hamcrest package update.
Spec URL: http://fedorapeople.org/~pahuang/zanata-api.spec SRPM URL: http://fedorapeople.org/~pahuang/zanata-api-2.2.0-2.fc17.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Ding-Yi Chen dchen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dchen@redhat.com Assignee|nobody@fedoraproject.org |dchen@redhat.com
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #2 from Ding-Yi Chen dchen@redhat.com --- Due to Bug 924016, I cannot build it in F-18, mind providing the spec that work in f-18?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #3 from Patrick Huang pahuang@redhat.com --- added conditional build for f19- Spec URL: http://fedorapeople.org/~pahuang/zanata-api.spec SRPM URL: http://fedorapeople.org/~pahuang/zanata-api-2.2.0-3.fc17.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Ding-Yi Chen dchen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #4 from Ding-Yi Chen dchen@redhat.com --- 1. Dependency apache-james-project is needed as BuildRequires. 2. Package SHOULD include LICENSE documents. 3. koji build --scratch f19 produced following error: [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /builddir/build/BUILD/zanata-api-api-2.2.0/zanata-common-api/src/test/java/org/zanata/rest/service/SourceDocResourceTest.java:[25,27] cannot find symbol symbol: class MatcherAssert location: package org.hamcrest [ERROR] /builddir/build/BUILD/zanata-api-api-2.2.0/zanata-common-api/src/test/java/org/zanata/rest/service/SourceDocResourceTest.java:[25,1] static import only from classes and interfaces [ERROR] /builddir/build/BUILD/zanata-api-api-2.2.0/zanata-common-api/src/test/java/org/zanata/rest/dto/v1/SerializationTest.java:[6,27] cannot find symbol symbol: class MatcherAssert location: package org.hamcrest [ERROR] /builddir/build/BUILD/zanata-api-api-2.2.0/zanata-common-api/src/test/java/org/zanata/rest/dto/v1/SerializationTest.java:[6,1] static import only from classes and interfaces [ERROR] /builddir/build/BUILD/zanata-api-api-2.2.0/zanata-common-api/src/test/java/org/zanata/common/TranslationStatsTest.java:[25,27] cannot find symbol symbol: class MatcherAssert location: package org.hamcrest [ERROR] /builddir/build/BUILD/zanata-api-api-2.2.0/zanata-common-api/src/test/java/org/zanata/common/TranslationStatsTest.java:[25,1] static import only from classes and interfaces [ERROR] /builddir/build/BUILD/zanata-api-api-2.2.0/zanata-common-api/src/test/java/org/zanata/rest/service/SourceDocResourceTest.java:[39,7] cannot find symbol symbol: method assertThat(java.lang.String,boolean) location: class org.zanata.rest.service.SourceDocResourceTest [ERROR] /builddir/build/BUILD/zanata-api-api-2.2.0/zanata-common-api/src/test/java/org/zanata/rest/service/SourceDocResourceTest.java:[40,7] cannot find symbol symbol: method assertThat(java.lang.String,boolean) location: class org.zanata.rest.service.SourceDocResourceTest [ERROR] /builddir/build/BUILD/zanata-api-api-2.2.0/zanata-common-api/src/test/java/org/zanata/rest/service/SourceDocResourceTest.java:[41,7] cannot find symbol symbol: method assertThat(java.lang.String,boolean) location: class org.zanata.rest.service.SourceDocResourceTest
..... =================================================================
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #5 from Patrick Huang pahuang@redhat.com --- Fixed f19. Koji job http://koji.fedoraproject.org/koji/taskinfo?taskID=5286140
Spec URL: http://fedorapeople.org/~pahuang/zanata-api.spec SRPM URL: http://fedorapeople.org/~pahuang/zanata-api-2.2.0-4.fc17.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #6 from Ding-Yi Chen dchen@redhat.com --- koji build --scratch f18 ~/924513-zanata-api/srpm/zanata-api-2.2.0-4.fc17.src.rpm
Produced following error:
[INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 2.860s [INFO] Finished at: Mon Apr 22 08:04:51 UTC 2013 [INFO] Final Memory: 15M/253M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal on project zanata-common-api: Could not resolve dependencies for project org.zanata:zanata-common-api:jar:2.2.0: Failed to collect dependencies for [org.hibernate:hibernate-validator:jar:4.2.0.Final (compile), javax.validation:validation-api:jar:1.0.0.GA (compile), org.jboss.resteasy:resteasy-jaxrs:jar:2.3.2.Final (compile), org.jboss.resteasy:resteasy-jaxb-provider:jar:2.3.2.Final (compile), org.jboss.resteasy:jaxrs-api:jar:2.3.2.Final (compile), org.jboss.resteasy:resteasy-multipart-provider:jar:2.3.2.Final (compile), org.codehaus.jackson:jackson-core-asl:jar:1.9.2 (compile), org.codehaus.jackson:jackson-mapper-asl:jar:1.9.2 (compile), org.slf4j:slf4j-api:jar:1.7.2 (compile), commons-lang:commons-lang:jar:2.6 (compile), org.hamcrest:hamcrest-core:jar:1.3 (test), org.hamcrest:hamcrest-library:jar:1.3 (test), javax.xml.stream:stax-api:jar:1.0 (compile), javax.xml.bind:jaxb-api:jar:2.2 (compile), org.testng:testng:jar:6.4 (test), org.slf4j:slf4j-log4j12:jar:1.7.2 (test)]: Failed to read artifact descriptor for org.apache.james:apache-mime4j-core:jar:0.7.2: The repository system is offline but the artifact org.apache.james:james-project:pom:1.8 is not available in the local repository. -> [Help 1]
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #7 from Patrick Huang pahuang@redhat.com --- Fixed f18. Spec URL: http://fedorapeople.org/~pahuang/zanata-api.spec SRPM URL: http://fedorapeople.org/~pahuang/zanata-api-2.2.0-5.fc17.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #8 from Patrick Huang pahuang@redhat.com --- Legal files will be included in next upstream release. For current upstream stable version 2.2.0, there is no legal files.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #9 from Ding-Yi Chen dchen@redhat.com --- Additional 2 issues
===== MUST items =====
Generic: [!]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in zanata-api- javadoc
Please add: %{name}%{?_isa} = %{version}-%{release}
[!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "Unknown or generated", "*No copyright* LGPL (v2.1 or later)". 3 files have unknown license. Detailed output of licensecheck in zanata-api/licensecheck.txt
Please change license to: LGPLv2+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #10 from Patrick Huang pahuang@redhat.com --- Fixed. f18 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5291496 f19 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5291479
Spec URL: http://fedorapeople.org/~pahuang/zanata-api.spec SRPM URL: http://fedorapeople.org/~pahuang/zanata-api-2.2.0-6.fc17.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Ding-Yi Chen dchen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #11 from Ding-Yi Chen dchen@redhat.com --- Package Review ==============
Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package requires other packages for directories it uses. [X]: Package uses nothing in %doc for runtime. [X]: Package is not known to require ExcludeArch. [X]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in zanata-api- javadoc [X]: Package complies to the Packaging Guidelines [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "Unknown or generated", "*No copyright* LGPL (v2.1 or later)". 3 files have unknown license. Detailed output of licensecheck in /home/dchen/zanata-api/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Package must own all directories that it creates. [X]: Package does not own files or directories owned by other packages. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 1 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment).
Java: [x]: Fully versioned dependency in subpackages, if present. [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages have Requires: jpackage-utils [x]: Bundled jar/class files should be removed before build
Maven: [X]: Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct [X]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define.
Java: [X]: Package has BuildArch: noarch (if possible) [X]: Package uses upstream build method (ant/maven/etc.)
===== EXTRA items =====
Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: zanata-api-2.2.0-3.fc17.noarch.rpm zanata-api-javadoc-2.2.0-3.fc17.noarch.rpm zanata-api-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint zanata-api zanata-api-javadoc zanata-api-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 2 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:'
Requires -------- zanata-api (rpmlib, GLIBC filtered): apache-commons-codec apache-commons-lang hibernate-validator jackson java jboss-annotations-1.1-api jpackage-utils resteasy slf4j
zanata-api-javadoc (rpmlib, GLIBC filtered): jpackage-utils
Provides -------- zanata-api: mvn(org.zanata:api) mvn(org.zanata:zanata-common-api) zanata-api
zanata-api-javadoc: zanata-api-javadoc
MD5-sum check ------------- https://github.com/zanata/zanata-api/archive/api-2.2.0.zip : CHECKSUM(SHA256) this package : 74b509e3d4b0e18303a438a24efedc79e70355aa00696a0736dd91945724f424 CHECKSUM(SHA256) upstream package : 399a39b433bc01f10984c05e91155c6991b1d48f6d7ac854a92b7165b23c98b7 However, diff -r shows no differences
Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -rn /home/dchen/rpmbuild/SRPMS/zanata-api-2.2.0-3.fc18.src.rpm ======================
APPROVED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Ding-Yi Chen dchen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|dchen@redhat.com |pahuang@redhat.com
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Patrick Huang pahuang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #12 from Patrick Huang pahuang@redhat.com --- New Package SCM Request ======================= Package Name: zanata-api Short Description: Zanata API modules Owners: pahuang seanf Branches: f17 f18 f19 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? | Flags| |fedora-cvs+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #13 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- zanata-api-2.2.0-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/zanata-api-2.2.0-6.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- zanata-api-2.2.0-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/zanata-api-2.2.0-6.fc19
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- zanata-api-2.2.0-6.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/zanata-api-2.2.0-6.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- zanata-api-2.2.0-6.fc19 has been pushed to the Fedora 19 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-04-30 00:30:45
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- zanata-api-2.2.0-6.fc19 has been pushed to the Fedora 19 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Gerard Ryan gerard@ryan.lt changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183 (FE-JAVASIG) |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- zanata-api-2.2.0-7.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/zanata-api-2.2.0-7.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- zanata-api-2.2.0-7.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/zanata-api-2.2.0-7.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- zanata-api-2.2.0-7.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/zanata-api-2.2.0-7.fc19
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |zanata-api-2.2.0-7.fc18
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- zanata-api-2.2.0-7.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924513
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|zanata-api-2.2.0-7.fc18 |zanata-api-2.2.0-7.fc17
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- zanata-api-2.2.0-7.fc17 has been pushed to the Fedora 17 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=924513
Ding-Yi Chen dchen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?
--- Comment #24 from Ding-Yi Chen dchen@redhat.com --- Package Change Request ====================== Package Name: zanata-api New Branches: epel7 Owners: pahuang dchen
https://bugzilla.redhat.com/show_bug.cgi?id=924513
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=924513
--- Comment #25 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla