[Bug 488911] New: Review Request: perl-Hash-Merge-Simple - Recursively merge two or more hashes, simply
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Hash-Merge-Simple - Recursively merge two or more hashes, simply
https://bugzilla.redhat.com/show_bug.cgi?id=488911
Summary: Review Request: perl-Hash-Merge-Simple - Recursively merge two or more hashes, simply Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/Hash-Merge-Simple OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Hash-Merge-Simple.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Hash-Merge-Simple-0.04-1.fc10.src...
Description: Hash::Merge::Simple will recursively merge two or more hashes and return the result as a new hash reference. The merge function will descend and merge hashes that exist under the same node in both the left and right hash, but doesn't attempt to combine arrays, objects, scalars, or anything else. The rightmost hash also takes precedence, replacing whatever was in the left hash if a conflict occurs. This code was pretty much taken straight from Catalyst::Utils, and modified to handle more than 2 hashes at the same time.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1225712
*rt-0.05
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488911
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488911
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-03-06 01:48:56 EDT --- Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1225712 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 977b6f679977e720ea70cef6acd00b47 Hash-Merge-Simple-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=14, 0 wallclock secs ( 0.00 usr 0.02 sys + 0.10 cusr 0.06 csys = 0.18 CPU) + Package perl-Hash-Merge-Simple-0.04-1.fc11-noarch => Provides: perl(Hash::Merge::Simple) = 0.04 Requires: perl(strict) perl(vars) perl(warnings)
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488911
--- Comment #2 from Chris Weyl cweyl@alumni.drew.edu 2009-03-06 02:09:06 EDT --- New Package CVS Request ======================= Package Name: perl-Hash-Merge-Simple Short Description: Recursively merge two or more hashes, simply Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488911
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488911
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2009-03-07 12:32:57 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488911
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #4 from Chris Weyl cweyl@alumni.drew.edu 2009-03-08 14:58:15 EDT --- Thanks for the review! :-)
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla