https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Bug ID: 1415686 Summary: Review Request: php-phpmyadmin-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@famillecollet.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/00671c6714d4987c8163c8... SRPM URL: http://rpms.remirepo.net/SRPMS/php-phpmyadmin-sql-parser-4.0.0-1.remi.src.rp... Description: A validating SQL lexer and parser with a focus on MySQL dialect.
This library was originally developed for phpMyAdmin during the Google Summer of Code 2015.
Autoloader: /usr/share/php/PhpMyAdmin/SqlParser/autoload.php
Fedora Account System Username: remi
Introduce PhpMyAdmin "vendor" namespace, so not BC. So this package is v4, php-udan11-sql-parser is v3 (and will be retired soon)
See (drop commands) http://pkgs.fedoraproject.org/cgit/rpms/php-udan11-sql-parser.git/commit/?h=...
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |phpmyadmin/sql-parser
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #1 from Remi Collet fedora@famillecollet.com --- Of course, I mean "BC break, not compatible with v3"
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #2 from Remi Collet fedora@famillecollet.com --- Update to 4.1.0 https://github.com/remicollet/remirepo/commit/44cca24ab0034c8a1220a0cf9b387e...
Spec: https://raw.githubusercontent.com/remicollet/remirepo/44cca24ab0034c8a1220a0... Srpm: http://rpms.remirepo.net/SRPMS/php-phpmyadmin-sql-parser-4.1.0-1.remi.src.rp...
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1415390 | |(phpmyadmin/motranslato)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1415390 [Bug 1415390] Review Request: php-phpmyadmin-motranslator - Translation API for PHP using Gettext MO files
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #3 from Remi Collet fedora@famillecollet.com --- Updated to 4.1.1
Spec: https://raw.githubusercontent.com/remicollet/remirepo/a85c9292862c4b3a7bdea2... Srpm: http://rpms.remirepo.net/SRPMS/php-phpmyadmin-sql-parser-4.1.1-1.remi.src.rp...
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #4 from Remi Collet fedora@famillecollet.com --- Update to 4.1.2
Spec: https://raw.githubusercontent.com/remicollet/remirepo/c010cfce09c53715655f75... Srpm: http://rpms.remirepo.net/SRPMS/php-phpmyadmin-sql-parser-4.1.2-1.remi.src.rp...
https://bugzilla.redhat.com/show_bug.cgi?id=1415686 Bug 1415686 depends on bug 1415390, which changed state.
Bug 1415390 Summary: Review Request: php-phpmyadmin-motranslator - Translation API for PHP using Gettext MO files https://bugzilla.redhat.com/show_bug.cgi?id=1415390
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1437273
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1437273 [Bug 1437273] phpMyAdmin-4.7.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #5 from Remi Collet fedora@famillecollet.com --- Update to 4.1.3
Spec: https://git.remirepo.net/cgit/rpms/php/phpmyadmin/php-phpmyadmin-sql-parser.... Srpm: http://rpms.remirepo.net/SRPMS/php-phpmyadmin-sql-parser-4.1.3-1.remi.src.rp...
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shawn@iwin.ski Assignee|nobody@fedoraproject.org |shawn@iwin.ski
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #6 from Shawn Iwinski shawn@iwin.ski --- Created attachment 1275186 --> https://bugzilla.redhat.com/attachment.cgi?id=1275186&action=edit phpcompatinfo-full.log
phpCompatInfo version 5.0.6 DB version 1.19.0 built Mar 17 2017 07:03:16 CET
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #7 from Shawn Iwinski shawn@iwin.ski --- Created attachment 1275187 --> https://bugzilla.redhat.com/attachment.cgi?id=1275187&action=edit phpcompatinfo-lib.log
phpCompatInfo version 5.0.6 DB version 1.19.0 built Mar 17 2017 07:03:16 CET
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #8 from Shawn Iwinski shawn@iwin.ski --- Created attachment 1275188 --> https://bugzilla.redhat.com/attachment.cgi?id=1275188&action=edit fedora-review.txt
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 1415686 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #9 from Shawn Iwinski shawn@iwin.ski --- No blockers.
===== APPROVED =====
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #10 from Shawn Iwinski shawn@iwin.ski --- Minor typo near %files:
%if 0%{?rhel} >= 12 || 0%{?rhel} >= 7
should be:
%if 0%{?fedora} >= 12 || 0%{?rhel} >= 7
please fix after initial import.
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #11 from Remi Collet fedora@famillecollet.com ---
Thanks for the review.
New package requested on pkgdb.
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #12 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-phpmyadmin-sql-parser
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.3-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ac62a9901f
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.3-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b74532eb9f
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.3-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6b5db03f58
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.3-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-633b2ecd8a
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.3-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6b5db03f58
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.3-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b74532eb9f
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.3-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ac62a9901f
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.3-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-633b2ecd8a
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6b5db03f58
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b74532eb9f
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.4-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-633b2ecd8a
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2017-05-05 09:33:35
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.3-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords| |Reopened
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b74532eb9f
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6b5db03f58
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #27 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-633b2ecd8a
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-05-05 09:33:35 |2017-05-15 00:26:30
--- Comment #28 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #29 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
--- Comment #30 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.5-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2246580be3
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|ERRATA |---
--- Comment #31 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.5-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2246580be3
https://bugzilla.redhat.com/show_bug.cgi?id=1415686
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-05-15 00:26:30 |2017-05-31 17:28:12
--- Comment #32 from Fedora Update System updates@fedoraproject.org --- php-phpmyadmin-sql-parser-4.1.5-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org