[Bug 431955] New: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=431955

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and
                    flexible way to build nice URLs for web applications
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-URL-Mapper.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-URL-Mapper-0.9.0-1.f...

Description:
Net_URL_Mapper provides a simple and flexible way to build nice URLs for your
web applications.

The URL syntax is similar to what can be found in Ruby on Rails or Python
Routes module and as such, this package can be compared to what they call a
router. Still, Net_URL_Mapper does not perform the dispatching like these
frameworks and therefore can be used with your own router.

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |pear-URL-Mapper

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2008-02-09 09:17 EST -------
REVIEW:
* rpmlint :
W: no-documentation
* The package is named according to the Package Naming Guidelines.
* The spec file name match the base package
* The package meet the PHP Packaging Guidelines
* Fedora approved license (BSD)
* License field in the package spec file match the actual license
* The spec file is written in American English
* The spec file is legible
* The sources used to build the package must match the upstream source
11a4d002f881ac5d957cdbb6b46139f7  Net_URL_Mapper-0.9.0.tgz
* build in mock (rawhide, noarch)
* All build dependencies are listed in BuildRequires
* no locales
* no shared library files
* package own all directories that it creates
* Package don't own files or directories already owned by other packages
* no duplicate files
* Permissions on files are set properly
* %clean section
* package consistently use macros
* The package contain code
* no documentation
* no library
* no desktop file
* %install, start with rm -rf %{buildroot}
* All filenames are valid UTF-8
* scriptlets are sane
* Final Provides ok
php-pear(Net_URL_Mapper) = 0.9.0
php-pear-Net-URL-Mapper = 0.9.0-1.fc8
**** Final Requires not OK
/usr/bin/pear  
php-pear(Net_URL) >= 1.0.14 (see below)
php-pear(PEAR)

Must fixe:
   Requires: php-pear(Net-URL) >= 1.0.14
To :
   Requires: php-pear(Net_URL) >= 1.0.14

Should fixe test suite.

Using the attached patch, all provided tests (19+12+22) succeed.

I know running tests during build is not always simple, but it still usefull (as
least an "how to" provided)

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

------- Additional Comments From [e-mail]  2008-02-09 09:17 EST -------
Created an attachment (id=294467)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=294467&action=view)
patch for tests

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #294467|0                           |1
        is obsolete|                            |

------- Additional Comments From [e-mail]  2008-02-09 09:39 EST -------
Created an attachment (id=294468)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=294468&action=view)
294467: patch for tests and package.xml

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

------- Additional Comments From [e-mail]  2008-02-09 09:40 EST -------
Created an attachment (id=294469)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=294469&action=view)
patch to use patch in specfile + add %check

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

------- Additional Comments From [e-mail]  2008-02-09 10:01 EST -------
Forget the %check. Doesn't work (at least in mock)

Or just keep it for documentation purpose.

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

------- Additional Comments From [e-mail]  2008-02-09 16:18 EST -------
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-URL-Mapper.spec
SRPM URL:
http://tkmame.retrogames.com/fedora-extras/php-pear-Net-URL-Mapper-0.9.0-2.f...

%changelog
* Sat Feb  9 2008 Christopher Stone  0.9.0-2
- Add test file patch (bz #431955)

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-02-10 02:06 EST -------
** APPROVED **

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-02-10 16:44 EST -------
New Package CVS Request
=======================
Package Name: php-pear-Net-URL-Mapper
Short Description: Simple and flexible way to build nice URLs for web applications
Owners: xulchris
Branches: F-7 F-8 EL-5
InitialCC: 
Cvsextras Commits: yes

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-02-11 12:55 EST -------
cvs done.

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

------- Additional Comments From [e-mail]  2008-02-11 16:37 EST -------
php-pear-Net-URL-Mapper-0.9.0-2.fc8 has been submitted as an update for Fedora 8

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

------- Additional Comments From [e-mail]  2008-02-13 00:05 EST -------
php-pear-Net-URL-Mapper-0.9.0-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |CURRENTRELEASE
   Fixed In Version|                            |0.9.0-2.fc8

[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955

------- Additional Comments From [e-mail]  2008-02-18 16:15 EST -------
Built on all branches, thanks for the review! :D