[Bug 2353412] New: Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

Bug ID: 2353412
           Summary: Review Request: libgenht - Simple generic hash table
                    implementation in C
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/s-kro/libgenht/fedora-raw...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/s-kro/libgenht/fedora-raw...
Description: genht is a simple generic hash table implementation in C.
Uses open addressing scheme with space doubling.
Type generics is achieved by ugly name prefixing macros.
Fedora Account System Username: s-kro

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://repo.hu/projects/gen
                   |                            |ht

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8794946
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/libgenht
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

Artur Frenszek-Iwicki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Artur Frenszek-Iwicki  ---
> Patch0:         00-fix-makefile.patch
> [...]
> sed -i 's|$< $(CFLAGS)|$< $(CFLAGS) -Wno-incompatible-pointer-types|' src/Makefile

You're already patching the Makefile, why use sed?
Why not add this change to the patch?
> %build
> %set_build_flags

Calling %set_build_flags manually is not needed since Fedora 36.

Also, looking at the build log:
> cp `pwd`/hash.h /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/hash.h
> cp `pwd`/siphash24.h /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/siphash24.h
> cp `pwd`/ht.h /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/ht.h
> cp `pwd`/ht.c /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/ht.c

It might be good to patch the Makefile (or alter the make call) to use "cp -p"
in order to preserve file timestamps.

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

--- Comment #3 from Steve  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/s-kro/libgenht/fedora-raw...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/s-kro/libgenht/fedora-raw...

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

--- Comment #4 from Fedora Review Service  ---
Created attachment 2081959
  --> https://bugzilla.redhat.com/attachment.cgi?id=2081959&action=edit
The .spec file difference from Copr build 8794946 to 8819222

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

--- Comment #5 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8819222
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/libgenht
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

--- Comment #6 from Steve  ---
Artur, thanks for the feedback
> > Patch0:         00-fix-makefile.patch
> > [...]
> > sed -i 's|$< $(CFLAGS)|$< $(CFLAGS) -Wno-incompatible-pointer-types|' src/Makefile
>
> you're already patching the Makefile, why use sed?
> Why not add this change to the patch?

The patch isn't mine, it comes from my upstream, who is a Debian Dude :)
> > %build
> > %set_build_flags
>
> Calling %set_build_flags manually is not needed since Fedora 36.

Done
> Also, looking at the build log:
> > cp `pwd`/hash.h /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/hash.h
> > [...]
>
> It might be good to patch the Makefile (or alter the make call) to use "cp -p" in order to preserve file timestamps.

Done, also in the spec file

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

--- Comment #7 from Steve  ---
https://download.copr.fedorainfracloud.org/results/s-kro/libgenht/fedora-raw...
https://download.copr.fedorainfracloud.org/results/s-kro/libgenht/fedora-raw...

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

--- Comment #8 from Fedora Review Service  ---
Created attachment 2104586
  --> https://bugzilla.redhat.com/attachment.cgi?id=2104586&action=edit
The .spec file difference from Copr build 8819222 to 9462133

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

--- Comment #9 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9462133
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/libgenht
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

--- Comment #10 from Artur Frenszek-Iwicki  ---
> %global debug_package %{nil}

No-go. If this creates .so files, it has to generate debuginfo.

Also, the -static subpackage should Require the -devel subpackage, as only
-devel contains the include headers.

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

--- Comment #11 from Steve  ---
https://download.copr.fedorainfracloud.org/results/s-kro/libgenht/fedora-raw...
https://download.copr.fedorainfracloud.org/results/s-kro/libgenht/fedora-raw...

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

--- Comment #12 from Fedora Review Service  ---
Created attachment 2105642
  --> https://bugzilla.redhat.com/attachment.cgi?id=2105642&action=edit
The .spec file difference from Copr build 9462133 to 9516999

[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

https://bugzilla.redhat.com/show_bug.cgi?id=2353412

--- Comment #13 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9516999
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/libgenht
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.