https://bugzilla.redhat.com/show_bug.cgi?id=1472824
Bug ID: 1472824 Summary: package review: rubygem-jekyll-redirect-from Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: johnh@isi.edu QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
SPEC: https://copr-be.cloud.fedoraproject.org/results/johnh/jekyll/fedora-25-x86_6...
SRPM: https://copr-be.cloud.fedoraproject.org/results/johnh/jekyll/fedora-25-x86_6...
This package provides useful functionality for jekyll.
The spec is automatic from the rubygem.
This build is 0.11.0 to work with rubygem-jekyll-3.2, the current package in Fedora Extras. The current release 0.12.0 requires jekyll-3.3 and so awaits upgrade of the parent package. However, no reason not to start with 0.11.0.
https://bugzilla.redhat.com/show_bug.cgi?id=1472824
--- Comment #1 from John Heidemann johnh@isi.edu --- Related tickets: #1470699 (update to rubygem-jekyll) #1470702 (another jekyll extension) #1310368 (my prior request for jekyll including this module, fortunately overtaken by someone else's packaging fo it)
https://bugzilla.redhat.com/show_bug.cgi?id=1472824
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- Hello,
- Version: is 0.11.0 but version in %changelog (and upstream) is 0.12.1. Did you forget to update the tag?
- The Group: tag is not used in Fedora. See https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- You didn't fill the %changelog entry with your name and email.
* Tue Jul 04 2017 John Heidemann johnh@isi.edu - 0.12.1-1
- The %check section is currently not testing anything, missing "rspec spec/" ?
For this, some dependencies are missing, I remember reviewing jekyll-sitemap so I already have a rpm laying around. It is not yet in Rawhide because it depend on the jekyll update. Rubocop has a review request but it doesn't seem mandatory. However the jekyll-sitemap packaged is a 1.x version, and the compatibility with such version is only available on a recent GIT snapshot: https://github.com/jekyll/jekyll-redirect-from/commit/55b91b3748f53679697225...
Thus I suggest you to package the latest development snapshot:
First:
%global commit bc5ab9bd672e005f59ae6beabe8cbce5c77e0cdc %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global commitdate 20170731
Then:
Release: 0.1.%{commitdate}git%{shortcommit}%{?dist}
With the following source:
# git clone https://github.com/jekyll/jekyll-redirect-from/ # cd jekyll-redirect-from; gem build jekyll-redirect-from.gemspec Source0: %{gem_name}-%{version}.gem
And the corresponding changelog entry:
* Tue Sep 12 2017 John Heidemann johnh@isi.edu - 0.12.1-0.1.20170731gitbc5ab9b
Of course, it will depend on the jekyll update going through (bug #1470699) then the sitemap package being imported (bug #1470702).
package-review@lists.fedoraproject.org