[Bug 1622717] New: Review Request: addrwatch - Monitoring IPv4/ IPv6 and Ethernet address pairings
https://bugzilla.redhat.com/show_bug.cgi?id=1622717
Bug ID: 1622717 Summary: Review Request: addrwatch - Monitoring IPv4/IPv6 and Ethernet address pairings Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: bugzilla-redhat@jens.kuehnel.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://copr-be.cloud.fedoraproject.org/results/jens/addrwatch/epel-7-x86_64... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jens/addrwatch/epel-7-x86_64... Description: It main purpose is to monitor network and log discovered Ethernet/IP pairings. Fedora Account System Username: Jens
https://bugzilla.redhat.com/show_bug.cgi?id=1622717
--- Comment #1 from Jens Kuehnel bugzilla-redhat@jens.kuehnel.org --- output of rpmlint: # rpmlint addrwatch-1.0.1-1.el7.src.rpm addrwatch.src: W: spelling-error %description -l en_US syslog -> slog 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
# rpmlint results_addrwatch/1.0.1/1.fc28/addrwatch-1.0.1-1.fc28.x86_64.rpm addrwatch.x86_64: W: spelling-error %description -l en_US syslog -> slog addrwatch.x86_64: W: non-standard-uid /var/lib/addrwatch addrwatch addrwatch.x86_64: W: non-standard-gid /var/lib/addrwatch addrwatch addrwatch.x86_64: W: no-manual-page-for-binary addrwatch_mysql addrwatch.x86_64: W: no-manual-page-for-binary addrwatch_stdout addrwatch.x86_64: W: no-manual-page-for-binary addrwatch_syslog 1 packages and 0 specfiles checked; 0 errors, 6 warnings.
Explanation: /var/lib/addrwatch contains the sqlite db and is writable by the special user addrwatch that is created in post.
This is not my first package review, but my last was about 5 years ago. :-)
https://bugzilla.redhat.com/show_bug.cgi?id=1622717
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- - make %{?_smp_mflags} → %make_build
- Not needed
install -p -m 644 COPYING %{buildroot}%{_docdir}/
just use:
%license COPYING
- Use macros in Source0:
Source0: %url/releases/download/v%{version}/%{name}-%{version}.tar.gz
- You could use %autosetup -p1 instead of:
%setup -q %patch0 -p1
- Add gcc as a BR
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "FSF All Permissive", "Unknown or generated". 47 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/addrwatch/review- addrwatch/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in addrwatch-debuginfo , addrwatch-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: addrwatch-1.0.1-1.fc30.x86_64.rpm addrwatch-debuginfo-1.0.1-1.fc30.x86_64.rpm addrwatch-debugsource-1.0.1-1.fc30.x86_64.rpm addrwatch-1.0.1-1.fc30.src.rpm addrwatch.x86_64: W: spelling-error %description -l en_US syslog -> slog addrwatch.x86_64: W: non-standard-uid /var/lib/addrwatch addrwatch addrwatch.x86_64: W: non-standard-gid /var/lib/addrwatch addrwatch addrwatch.x86_64: W: no-manual-page-for-binary addrwatch_mysql addrwatch.x86_64: W: no-manual-page-for-binary addrwatch_stdout addrwatch.x86_64: W: no-manual-page-for-binary addrwatch_syslog addrwatch.src: W: spelling-error %description -l en_US syslog -> slog 4 packages and 0 specfiles checked; 0 errors, 7 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1622717
--- Comment #3 from Jens Kuehnel bugzilla-redhat@jens.kuehnel.org --- Here the new release. Everything from comment #2 is included.
Spec URL: https://copr-be.cloud.fedoraproject.org/results/jens/addrwatch/fedora-28-x86... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jens/addrwatch/fedora-28-x86...
https://bugzilla.redhat.com/show_bug.cgi?id=1622717
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- All good, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1622717
--- Comment #5 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/addrwatch
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com