[Bug 2033796] New: Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

Bug ID: 2033796
           Summary: Review Request: python-ua-parser - Python port of
                    Browserscope's user agent parser
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://smani.fedorapeople.org/review/python-ua-parser.spec
SRPM URL:
https://smani.fedorapeople.org/review/python-ua-parser-0.10.0-1.fc36.src.rpm
Description: Python port of Browserscope's user agent parser
Fedora Account System Username: smani

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

Jarek Prokop  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?

--- Comment #1 from Jarek Prokop  ---
Taking for a review.

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

Jarek Prokop  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

--- Comment #2 from Jarek Prokop  ---
LGTM, but there are a some nits that need to be fixed before approving:
  * Invalid license: `python-ua-parser.src: W: invalid-license ASL2.0`
    * Correct format is "ASL 2.0"
  * E: non-executable-script
/usr/lib/python3.10/site-packages/ua_parser/user_agent_parser_test.py 644
/usr/bin/python2.5
    * The shebang should not be there with those file permissions.
      This seems like appropriate medicine: `sed -i -e '|^#!|d'
ua_parser/user_agent_parser_test.py`
    * Optional: It looks like a test file, which could be run in the %check
section.

Please fix the license and the shebang.

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

--- Comment #3 from Sandro Mani  ---
The unit tests are failing [1], I'll need to look into it as time allows - I
guess it's a mismatching version of uap-core.

[1] https://kojipkgs.fedoraproject.org//work/tasks/7669/80237669/build.log

Spec URL: https://smani.fedorapeople.org/review/python-ua-parser.spec
SRPM URL:
https://smani.fedorapeople.org/review/python-ua-parser-0.10.0-2.fc36.src.rpm

%changelog
* Mon Dec 20 2021 Sandro Mani  - 0.10.0-2
- Fix license
- Add possibility to run unittest
- Don't install unittest

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

Jarek Prokop  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #4 from Jarek Prokop  ---
> The unit tests are failing [1], I'll need to look into it as time allows - I guess it's a mismatching version of uap-core.

Good to see them here, upstream's tests are ok (it seems), so the mismatched
version makes sense.

LGTM, package approved!

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

--- Comment #5 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-ua-parser

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

Sandro Mani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2021-12-21 16:25:15

--- Comment #6 from Sandro Mani  ---
Thanks!

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

--- Comment #7 from Fedora Update System  ---
FEDORA-2021-fa593b16a5 has been submitted as an update to Fedora 35.
https://bodhi.fedoraproject.org/updates/FEDORA-2021-fa593b16a5

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

--- Comment #8 from Fedora Update System  ---
FEDORA-2021-b68878febc has been submitted as an update to Fedora 34.
https://bodhi.fedoraproject.org/updates/FEDORA-2021-b68878febc

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

--- Comment #9 from Fedora Update System  ---
FEDORA-2021-b68878febc has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2021-b68878febc *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-b68878febc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

--- Comment #10 from Fedora Update System  ---
FEDORA-2021-fa593b16a5 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2021-fa593b16a5 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-fa593b16a5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|RAWHIDE                     |ERRATA

--- Comment #11 from Fedora Update System  ---
FEDORA-2021-b68878febc has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2033796] Review Request: python-ua-parser - Python port of Browserscope's user agent parser

https://bugzilla.redhat.com/show_bug.cgi?id=2033796

--- Comment #12 from Fedora Update System  ---
FEDORA-2021-fa593b16a5 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.