[Bug 1524133] New: Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

Bug ID: 1524133
           Summary: Review Request: deepin-calculator - an easy to use
                    calculator
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...

SRPM:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...

Description: an easy to use calculator

Fedora Account System Username: mosquito

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1465889
                   |                            |(DeepinDEPackageReview)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

--- Comment #1 from Robert-André Mauchin  ---
 - update-desktop-database is not needed in %post and %postun since Fedora 25.
See
https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=4...

- I've got a build error:

src/main.cpp:3:10: fatal error: DHiDPIHelper: No such file or directory
 #include <DHiDPIHelper>
          ^~~~~~~~~~~~~~
compilation terminated.

It seems DHiDPIHelper was added in a recent version of dtkwidget, at least
2.0.2
    See
https://github.com/linuxdeepin/dtkwidget/commit/0fdbcf605243bdc13a84abd08bf3...

Thus you need to add a correct minimum version to the BR:

BuildRequires:  pkgconfig(dtkwidget) >= 2.0.2

And you need to update the version of dtkwidget available in Fedora. The
latest version you packaged is 2.0.1.

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

Zamir SUN  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Alias|                            |deepin-calculator

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

Zamir SUN  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]           |[e-mail]
              Flags|                            |needinfo?(sensor.wen@gmail.
                   |                            |com)

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(sensor.wen@gmail. |
                   |com)                        |

--- Comment #2 from [e-mail] ---
http://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/Everything/...

Updated the latest version of dtkwidget. Please review again.

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

--- Comment #3 from Robert-André Mauchin  ---
 - Bump to 1.0.2.

- This:

sed -i 's|=lupdate|=lupdate-qt5|;s|=lrelease|=lrelease-qt5|' %{name}.pro

doesn't work as there is no lupdate/lrelease in the pro file. Thus
translation fails. There's a script here: translations/translate_generation.sh
which contains lrelease that you could replace:

sed -i 's|lrelease|lrelease-qt5|' translations/translate_generation.sh

- This scriplet is not needed anymore, it has been automated:

%post
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null ||:
/usr/bin/update-desktop-database -q ||:

%postun
if [ $1 -eq 0 ]; then
    /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null ||:
    /usr/bin/gtk-update-icon-cache -f -t -q %{_datadir}/icons/hicolor ||:
fi
/usr/bin/update-desktop-database -q ||:

%posttrans
/usr/bin/gtk-update-icon-cache -f -t -q %{_datadir}/icons/hicolor ||:

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

--- Comment #4 from [e-mail] ---
Spec:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...

SRPM:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...

Release 1.0.2. Thank you for your help.

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

--- Comment #5 from Robert-André Mauchin  ---
 - You need to add: Requires:       hicolor-icon-theme
   to own these directories:

[!]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor,
     /usr/share/dman, /usr/share/icons/hicolor/scalable

- There are source files with incorrect obsolete FSF address, patch them in
%prep with the new address and notify upstream about it:

deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatcommon.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatcommon.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatconst.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatconst.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatconvert.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatconvert.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floaterf.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floaterf.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatexp.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatexp.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatgamma.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatgamma.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floathmath.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floathmath.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatincgamma.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatio.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatio.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatipower.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatipower.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatlog.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatlog.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatlogic.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatlogic.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatlong.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatlong.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatnum.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatnum.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatpower.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatpower.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatseries.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floatseries.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floattrig.c
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/floattrig.h
deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address
deepin-calculator-1.0.2-1.fc29.x86_64/math/number.c

sed -i "s|59 Temple Place, Suite 330|51 Franklin Street, Fifth Floor|;s|Boston,
MA 02111-1307 USA.|Boston, MA 02110-1335, USA.|" math/*.{c,h}

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

--- Comment #6 from [e-mail] ---
SPEC:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...
SRPM:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...

Fixed it. Thank you.

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #7 from Robert-André Mauchin  ---
Package approved.

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-calculator

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

Zamir SUN  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2018-07-22 09:32:23

--- Comment #9 from Zamir SUN  ---
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging
effort.

[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

https://bugzilla.redhat.com/show_bug.cgi?id=1524133

--- Comment #10 from Zamir SUN  ---
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging
effort.