Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Merge Review: perl-XMLPath - XPath parser and evaluator for Perl
https://bugzilla.redhat.com/show_bug.cgi?id=541668
Summary: Merge Review: perl-XMLPath - XPath parser and evaluator for Perl Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mmaslano@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
SRPM: http://mmaslano.fedorapeople.org/MergeReview/perl-XML-XPath-1.13-9.fc13.src.... Spec: http://mmaslano.fedorapeople.org/MergeReview/perl-XML-XPath.spec Description: XPath parser and evaluator for Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=541668
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-11-27 04:32:55 EDT --- I wonder how can this package got missed at time of FC-6 when all core packages submitted for their merge-reviews.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=541668
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Merge Review: perl-XMLPath |Merge Review: |- XPath parser and |perl-XML-XPath - XPath |evaluator for Perl |parser and evaluator for | |Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=541668
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #2 from Parag AN(पराग) panemade@gmail.com 2009-12-09 01:50:26 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1863888 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) 72a8e7a71f5d0b46e004adfbc5c5dbf59affd03c XML-XPath-1.13.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + %doc is present. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=35, Tests=187, 4 wallclock secs ( 0.02 usr 0.02 sys + 3.16 cusr 0.52 csys = 3.72 CPU) + Package perl-XML-XPath-1.13-9.fc13.noarch => Provides: perl(XML::XPath) = 1.13 perl(XML::XPath::Boolean) perl(XML::XPath::Builder) perl(XML::XPath::Expr) perl(XML::XPath::Function) perl(XML::XPath::Literal) perl(XML::XPath::LocationPath) perl(XML::XPath::Node) perl(XML::XPath::Node::Attribute) perl(XML::XPath::Node::AttributeImpl) perl(XML::XPath::Node::Comment) perl(XML::XPath::Node::CommentImpl) perl(XML::XPath::Node::Element) perl(XML::XPath::Node::ElementImpl) perl(XML::XPath::Node::Namespace) perl(XML::XPath::Node::NamespaceImpl) perl(XML::XPath::Node::PI) perl(XML::XPath::Node::PIImpl) perl(XML::XPath::Node::Text) perl(XML::XPath::Node::TextImpl) perl(XML::XPath::NodeImpl) perl(XML::XPath::NodeSet) perl(XML::XPath::Number) perl(XML::XPath::Parser) perl(XML::XPath::PerlSAX) perl(XML::XPath::Root) perl(XML::XPath::Step) perl(XML::XPath::Variable) perl(XML::XPath::XMLParser)
Requires: /usr/bin/perl perl(Carp) perl(Exporter) perl(IO::File) perl(XML::Parser) perl(XML::XPath) perl(XML::XPath::Boolean) perl(XML::XPath::Expr) perl(XML::XPath::Function) perl(XML::XPath::Literal) perl(XML::XPath::LocationPath) perl(XML::XPath::Node) perl(XML::XPath::Node::Attribute) perl(XML::XPath::Node::Comment) perl(XML::XPath::Node::Element) perl(XML::XPath::Node::Namespace) perl(XML::XPath::Node::PI) perl(XML::XPath::Node::Text) perl(XML::XPath::NodeSet) perl(XML::XPath::Number) perl(XML::XPath::Parser) perl(XML::XPath::Root) perl(XML::XPath::Step) perl(XML::XPath::Variable) perl(XML::XPath::XMLParser) perl(overload) perl(strict) perl(vars)
+ Not a GUI application
Suggestions: 1) Remove redundant BR perl >= 1:5.6.1
2)Remove macros line %{!?perl_vendorlib: %define perl_vendorlib %(eval "`%{__perl} -V:installvendorlib`"; echo $installvendorlib)}
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=541668
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #3 from Marcela Mašláňová mmaslano@redhat.com 2009-12-10 07:28:02 EDT --- Thank you for your review. Your comments were fixed for rawhide and F-12.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla