[Bug 1180803] New: Review Request: python-XStatic-Angular-Bootstrap - Angular-Bootstrap (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1180803
Bug ID: 1180803 Summary: Review Request: python-XStatic-Angular-Bootstrap - Angular-Bootstrap (XStatic packaging standard) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mrunge@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://www.matthias-runge.de/fedora/python-XStatic-Angular-Bootstrap.spec SRPM URL: http://www.matthias-runge.de/fedora/python-XStatic-Angular-Bootstrap-0.11.0.... Description: JavaScript library packaged for setuptools (easy_install) / pip.
This package is intended to be used by any project that needs these files.
It intentionally does not provide any extra code except some metadata nor has any extra requirements.
Fedora Account System Username: mrunge
https://bugzilla.redhat.com/show_bug.cgi?id=1180803
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |karlthered@gmail.com Assignee|nobody@fedoraproject.org |karlthered@gmail.com Flags| |fedora-review+
--- Comment #1 from Haïkel Guémar karlthered@gmail.com --- As usual with XStatic package, please ask upstream to keep the license file.
I hereby approve this package into Fedora Packages Collection since it complies with guidelines. Please submit a SCM request.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/haikel/1180803-python-XStatic-Angular- Bootstrap/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python2.7/site-packages/xstatic/pkg [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python2.7/site- packages/xstatic/pkg [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python-XStatic-Angular-Bootstrap-0.11.0.2-1.fc22.noarch.rpm python-XStatic-Angular-Bootstrap-0.11.0.2-1.fc22.src.rpm python-XStatic-Angular-Bootstrap.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, footstools python-XStatic-Angular-Bootstrap.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal python-XStatic-Angular-Bootstrap.src: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, footstools python-XStatic-Angular-Bootstrap.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@zangetsu /]# rpmlint python-XStatic-Angular-Bootstrap python-XStatic-Angular-Bootstrap.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools python-XStatic-Angular-Bootstrap.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal 1 packages and 0 specfiles checked; 0 errors, 2 warnings. ]0;<mock-chroot><mock-chroot>[root@zangetsu /]# echo 'rpmlint-done:'
Requires -------- python-XStatic-Angular-Bootstrap (rpmlib, GLIBC filtered): python(abi) python-XStatic web-assets-filesystem
Provides -------- python-XStatic-Angular-Bootstrap: python-XStatic-Angular-Bootstrap
Source checksums ---------------- https://pypi.python.org/packages/source/X/XStatic-Angular-Bootstrap/XStatic-... : CHECKSUM(SHA256) this package : cbe428bf04c000460776b521f6ace0455e9f3f20135499e9aa2f4af693dc7b3e CHECKSUM(SHA256) upstream package : cbe428bf04c000460776b521f6ace0455e9f3f20135499e9aa2f4af693dc7b3e
https://bugzilla.redhat.com/show_bug.cgi?id=1180803
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #2 from Matthias Runge mrunge@redhat.com --- Haïkel, you're amazing, thank you!
New Package SCM Request ======================= Package Name: python-XStatic-Angular-Bootstrap Short Description: Angular-Bootstrap (XStatic packaging standard) Upstream URL: http://angular-ui.github.io/bootstrap/ Owners: mrunge Branches: f21 epel7
https://bugzilla.redhat.com/show_bug.cgi?id=1180803
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1180803
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1180803
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1180803
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- python-XStatic-Angular-Bootstrap-0.11.0.2-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-XStatic-Angular-Bootstrap-0.1...
https://bugzilla.redhat.com/show_bug.cgi?id=1180803
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- python-XStatic-Angular-Bootstrap-0.11.0.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-XStatic-Angular-Bootstrap-0.1...
https://bugzilla.redhat.com/show_bug.cgi?id=1180803
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-XStatic-Angular-Bootstrap-0.11.0.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1180803
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |python-XStatic-Angular-Boot | |strap-0.11.0.2-1.fc21 Resolution|--- |ERRATA Last Closed| |2015-01-26 22:01:03
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-XStatic-Angular-Bootstrap-0.11.0.2-1.fc21 has been pushed to the Fedora 21 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1180803
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-XStatic-Angular-Boot |python-XStatic-Angular-Boot |strap-0.11.0.2-1.fc21 |strap-0.11.0.2-1.el7
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-XStatic-Angular-Bootstrap-0.11.0.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla