Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: eekboard - A Virtual Keyboard for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=606714
Summary: Review Request: eekboard - A Virtual Keyboard for GNOME Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: dueno@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://ueno.fedorapeople.org/eekboard/eekboard.spec SRPM URL: http://ueno.fedorapeople.org/eekboard/eekboard-0.0.2-1.fc13.src.rpm Description: eekboard is a virtual keyboard software package which ships with a standalone virtual keyboard application (eekboard), and a library to create keyboard-like UI (libeek).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
Chen Lei supercyper1@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |supercyper1@gmail.com
--- Comment #1 from Chen Lei supercyper1@gmail.com 2010-06-22 10:54:40 EDT --- One suggestion:
It'll be better to merge libxxx subpackages to a -libs subpackage, libxxx subpackage looks like the debian style.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #2 from Daiki Ueno dueno@redhat.com 2010-06-22 21:14:49 EDT --- Thanks. Fixed in: Spec URL: http://ueno.fedorapeople.org/eekboard/eekboard.spec SRPM URL: http://ueno.fedorapeople.org/eekboard/eekboard-0.0.2-2.fc13.src.rpm
I also reduced the number of subpackages into 4:
- eekboard - eekboard-libs - eekboard-devel - eekboard-devel-docs
Previously I subpackaged them by library dependencies (gtk, clutter, xkl, etc). Now I think this rough splitting is better because the only application "eekboard" requires all of them.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #3 from Daiki Ueno dueno@redhat.com 2010-06-24 20:35:23 EDT --- Update: Spec URL: http://ueno.fedorapeople.org/eekboard/eekboard.spec SRPM URL: http://ueno.fedorapeople.org/eekboard/eekboard-0.0.3-2.fc13.src.rpm
and Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=2269458
Anyone to review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
--- Comment #4 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-06-26 05:14:42 EDT --- Some notes:
* BuildRoot - BuildRoot tag is no longer used (even if rpmlint may complain if you remove this) https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
! By the way for this package %clean is also unneeded because this package won't build on F-12 (c.f.: http://koji.fedoraproject.org/koji/taskinfo?taskID=2273814 : higher gtk seems needed ) and %clean is not needed for F-13+: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
* BR - Please try to remove redundant BRs - "glib2-devel" is always required by "gtk2-devel" - You probably need gobject-introspection"-devel" (not just gobject-introspection) ! Note that gobject-introspection-devel is required by clutter-devel (and so clutter-gtk-devel)
* build issues - The spec file contains: ----------------------------------------------------- 62 # Prevent the upstream configure script from using clutter-gtk-0.90, 63 # which is not available in Fedora yet. 64 export CLUTTER_GTK_CFLAGS=`pkg-config clutter-gtk-0.10 --cflags` 65 export CLUTTER_GTK_LIBS=`pkg-config clutter-gtk-0.10 --libs` ----------------------------------------------------- Why is this needed while configure.ac contains the below? ----------------------------------------------------- 72 PKG_CHECK_MODULES([CLUTTER_GTK], [clutter-gtk-0.90], 73 [enable_clutter_gtk=yes]) 74 if test x$enable_clutter_gtk = xno; then 75 PKG_CHECK_MODULES([CLUTTER_GTK], [clutter-gtk-0.10], 76 [enable_clutter_gtk=yes]) 77 fi ----------------------------------------------------- - Your srpm fails to build on F-13 as: http://koji.fedoraproject.org/koji/taskinfo?taskID=2273819 Note that current dist-f13-build pango is 1.28.0-1.fc13 and introspection is enabled from 1.28.0-2
* Desktop file verification ----------------------------------------------------- 518 /builddir/build/BUILDROOT/eekboard-0.0.3-2.fc14.i386/usr/share/applications/eekboard.desktop: error: (will be fatal in the future): value "GNOME" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: GTK ----------------------------------------------------- - Please consider to fix this.
* Documents - "AUTHORS COPYING README" should be moved to -libs, because eekboard depends on -libs and not the opposite.
* Directory ownership issue - Please take care of directory ownership issue ------------------------------------------------------ # rpm -qf /usr/include/eek-0.1/ /usr/include/eek-0.1/eek/ /usr/share/vala/ /usr/share/vala/vapi/ file /usr/include/eek-0.1 is not owned by any package file /usr/include/eek-0.1/eek is not owned by any package file /usr/share/vala is not owned by any package file /usr/share/vala/vapi is not owned by any package ------------------------------------------------------
! Functionality - By the way (with using rawhide) when I try to * launch uxterm * launch eekboard from uxterm * choose 'ヘルプ' -> '情報', then choose '閉じる' on the popup'ed window Then eekboard freezes....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #5 from Daiki Ueno dueno@redhat.com 2010-06-28 01:33:16 EDT --- Thanks. Mostly fixed:
Spec URL: http://ueno.fedorapeople.org/eekboard/eekboard.spec SRPM URL: http://ueno.fedorapeople.org/eekboard/eekboard-0.0.3-3.fc13.src.rpm
- on CLUTTER_GTK_CFLAGS and CLUTTER_GTK_LIBS setting
the upstream configure.ac is wrong (since it does not specify ACTION-IF-NOT-FOUND clause of PKG_CHECK_MODULES, configure aborts if clutter-gtk-0.90 is not found). I'll fix this in the next release.
- on F-13 build failure related to pango introspection
Pango*.gir is included in gir-repository-devel, so I added it to BR.
- on /usr/share/vala/ ownership
Added vala to eekboard-devel requirements.
- freeze on the About dialog
Couldn't reproduce it on F-13, but I'll try it on rawhide. Anyway, additional information would be much appreciated.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #6 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-06-28 03:07:06 EDT --- Just tried to rebuild but this time your srpm does not build on rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2276522
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #7 from Daiki Ueno dueno@redhat.com 2010-06-28 03:35:54 EDT --- Ah, sorry. gir-repository-devel is not available in rawhide. Now it should be fixed:
Spec URL: http://ueno.fedorapeople.org/eekboard/eekboard.spec SRPM URL: http://ueno.fedorapeople.org/eekboard/eekboard-0.0.3-4.fc13.src.rpm
Koji builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=2276551 https://koji.fedoraproject.org/koji/taskinfo?taskID=2276547
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #8 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-06-28 12:22:25 EDT --- Created an attachment (id=427454) --> (https://bugzilla.redhat.com/attachment.cgi?id=427454) screenshot of eekboard
For -4:
* Timestamps - Please consider to use ------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------------- to keep timestamps on installed files as much as possible. This method usually works for Makefiles generated by recent autotools.
* Directory ownership issue - Still %{_includedir}/eek-0.1/ is not owned by any packages.
! About "Freeze" of eekboard - Well, actually it seems that when I * launch eekboard (from terminal) * move eekboard window Then "virtual keyboard" on eekboard won't be redrawn (see attached)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #9 from Daiki Ueno dueno@redhat.com 2010-06-28 21:03:37 EDT --- Thanks. Updated:
Spec URL: http://ueno.fedorapeople.org/eekboard/eekboard.spec SRPM URL: http://ueno.fedorapeople.org/eekboard/eekboard-0.0.3-5.fc13.src.rpm
about "freeze", I guess you are hitting on the clutter-gtk bug: http://bugzilla.openedhand.com/show_bug.cgi?id=2169 Could you try the following?
EEKBOARD_DISABLE_CLUTTER=1 eekboard
I'm now thinking of making this behavior default, at least clutter-gtk-0.90 is not found when building.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #10 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-06-29 02:08:18 EDT --- Will check later. For now about this comment:
(In reply to comment #9)
about "freeze", I guess you are hitting on the clutter-gtk bug: http://bugzilla.openedhand.com/show_bug.cgi?id=2169 Could you try the following?
EEKBOARD_DISABLE_CLUTTER=1 eekboard
It seems this works for me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #11 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-06-29 03:20:07 EDT --- Well, good, except for the "freezing" issue on rawhide. I think for now setting "EEKBOARD_DISABLE_CLUTTER=1" as default is preferable, because we want to make the package work just as it is.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #12 from Jens Petersen petersen@redhat.com 2010-06-29 05:17:00 EDT --- Minor comment - not sure if it is worth subpackaging devel-docs? Maybe it could be merged into devel?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #13 from Parag AN(पराग) panemade@gmail.com 2010-06-29 06:34:51 EDT --- I too think devel-docs is not that big to have it subpackaged from -devel.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #14 from Daiki Ueno dueno@redhat.com 2010-07-01 01:10:01 EDT --- Thanks. Updated:
Spec URL: http://ueno.fedorapeople.org/eekboard/eekboard.spec SRPM URL: http://ueno.fedorapeople.org/eekboard/eekboard-0.0.4-1.fc13.src.rpm
about "freeze", I added a workaround instead of disabling Clutter.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #15 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-07-01 03:05:35 EDT --- Well, currently rawhide tree has some broken dependencies around gtk2/gtk3 related packages and now I am trying to resolve the dependencies at least between packages needed for this package, please wait....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #16 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-07-01 13:24:49 EDT --- Approving.
--------------------------------------------------------- This package (eekboard) is APPROVED by mtasaka ---------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
Daiki Ueno dueno@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #17 from Daiki Ueno dueno@redhat.com 2010-07-01 23:07:43 EDT --- Thanks for the review, Tasaka-san.
New Package CVS Request ======================= Package Name: eekboard Short Description: A Virtual Keyboard for GNOME Owners: ueno Branches: F-13 InitialCC: i18n-team
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #18 from Jason Tibbitts tibbs@math.uh.edu 2010-07-02 00:50:18 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #19 from Fedora Update System updates@fedoraproject.org 2010-07-02 02:02:45 EDT --- eekboard-0.0.4-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/eekboard-0.0.4-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #20 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-07-02 02:53:53 EDT --- Thanks, now closing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #21 from Fedora Update System updates@fedoraproject.org 2010-07-14 02:23:47 EDT --- eekboard-0.0.4-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/eekboard-0.0.4-2.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
--- Comment #22 from Fedora Update System updates@fedoraproject.org 2010-07-30 04:46:14 EDT --- eekboard-0.0.4-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606714
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |eekboard-0.0.4-2.fc13 Resolution|NEXTRELEASE |ERRATA
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla