https://bugzilla.redhat.com/show_bug.cgi?id=1460174
Bug ID: 1460174 Summary: Review Request: libopusenc - A library that provides an easy way to encode Ogg Opus files Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: pbrobinson@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
SPEC: https://pbrobinson.fedorapeople.org/libopusenc.spec SRPM: https://pbrobinson.fedorapeople.org/libopusenc-0.1-1.fc26.src.rpm Decscription: A library that provides an easy way to encode Ogg Opus files.
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=19925262
https://bugzilla.redhat.com/show_bug.cgi?id=1460174
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- URL is messed up. Also, no https?
Suggestion: make %{?_smp_mflags} V=1 → %make_build Suggestion: make install DESTDIR=%{buildroot} → %make_install
+ package name is OK + license is acceptable for Fedora (BSD) + license is specified correctly + builds and install OK + fedora-review finds no issues + scriptlets are correct + R/BR/P look correct + %check is present and passes
Package is APPROVED. Please note the comments at the top.
https://bugzilla.redhat.com/show_bug.cgi?id=1460174
--- Comment #2 from Peter Robinson pbrobinson@gmail.com --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
URL is messed up. Also, no https?
Suggestion: make %{?_smp_mflags} V=1 → %make_build Suggestion: make install DESTDIR=%{buildroot} → %make_install
All fixed locally, will be fixed on initial checkin. Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1460174
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libopusenc
https://bugzilla.redhat.com/show_bug.cgi?id=1460174
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2017-06-09 17:33:45
package-review@lists.fedoraproject.org