https://bugzilla.redhat.com/show_bug.cgi?id=2052620
Bug ID: 2052620 Summary: twincam - a lightweight camera application Product: Fedora Version: rawhide Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: ecurtin@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://ecurtin.fedorapeople.org/automotive_sig_packages/twincam/SPECS/twinc... SRPM URL: https://ecurtin.fedorapeople.org/automotive_sig_packages/twincam/SRPMS/twinc... Description: A lightweight camera application Fedora Account System Username: ecurtin
https://bugzilla.redhat.com/show_bug.cgi?id=2052620
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Flags| |fedora-review? Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2052620
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Initial spec review:
BuildRequires: libevent-devel BuildRequires: libcamera-devel BuildRequires: libdrm-devel
It seems that you're using Meson, and it discovers dependencies with pkgconfig, so I'd recommend switching to the pkgconfig names, like so:
BuildRequires: pkgconfig(libevent_pthreads) BuildRequires: pkgconfig(libcamera) BuildRequires: pkgconfig(libdrm)
%description A lightweight camera application
The summary and description are identical, so you might as well simplify here:
%description %{summary}.
Can you make those changes please?
https://bugzilla.redhat.com/show_bug.cgi?id=2052620
--- Comment #3 from Neal Gompa ngompa13@gmail.com ---
%pre exit 0
This can be dropped, since it does nothing.
https://bugzilla.redhat.com/show_bug.cgi?id=2052620
--- Comment #4 from ecurtin@redhat.com --- Changes made. Updated links:
Spec URL: https://ecurtin.fedorapeople.org/automotive_sig_packages/twincam/SPECS/twinc... SRPM URL: https://ecurtin.fedorapeople.org/automotive_sig_packages/twincam/SRPMS/twinc...
https://bugzilla.redhat.com/show_bug.cgi?id=2052620
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 2.1". 11 files have unknown license. Detailed output of licensecheck in /home/ngompa/2052620-twincam/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: twincam-0.2-3.fc36.x86_64.rpm twincam-debuginfo-0.2-3.fc36.x86_64.rpm twincam-debugsource-0.2-3.fc36.x86_64.rpm twincam-0.2-3.fc36.src.rpm twincam.x86_64: W: no-manual-page-for-binary twincam 4 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (debuginfo) ------------------- Checking: twincam-debuginfo-0.2-3.fc36.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/ericcurtin/twincam/archive/0.2/twincam-0.2.tar.gz : CHECKSUM(SHA256) this package : e1f2cc797df344836aba40b6afc4ac8a0777fb8c223aba473cd44f2a06b5a50a CHECKSUM(SHA256) upstream package : e1f2cc797df344836aba40b6afc4ac8a0777fb8c223aba473cd44f2a06b5a50a
Requires -------- twincam (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcamera-base.so.0()(64bit) libcamera.so.0()(64bit) libdrm.so.2()(64bit) libevent-2.1.so.7()(64bit) libevent_pthreads-2.1.so.7()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH)
twincam-debuginfo (rpmlib, GLIBC filtered):
twincam-debugsource (rpmlib, GLIBC filtered):
Provides -------- twincam: twincam twincam(x86-64)
twincam-debuginfo: debuginfo(build-id) twincam-debuginfo twincam-debuginfo(x86-64)
twincam-debugsource: twincam-debugsource twincam-debugsource(x86-64)
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2052620 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: fonts, Python, SugarActivity, Ocaml, PHP, Haskell, R, Java, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2052620
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #6 from Neal Gompa ngompa13@gmail.com ---
- If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
Just change your "BuildRequires: gcc-g++" to "BuildRequires: gcc-c++" to satisfy the check here.
I'm okay with you doing this on import, so...
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2052620
--- Comment #7 from ecurtin@redhat.com --- Thanks for the approval.
Changes made. Updated links:
Spec URL: https://ecurtin.fedorapeople.org/automotive_sig_packages/twincam/SPECS/twinc... SRPM URL: https://ecurtin.fedorapeople.org/automotive_sig_packages/twincam/SRPMS/twinc...
Will do on import also.
https://bugzilla.redhat.com/show_bug.cgi?id=2052620
--- Comment #8 from Neal Gompa ngompa13@gmail.com --- Your spec file doesn't match the SRPM you just posted.
https://bugzilla.redhat.com/show_bug.cgi?id=2052620
--- Comment #9 from ecurtin@redhat.com --- Good catch, now it does. Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=2052620
--- Comment #10 from Neal Gompa ngompa13@gmail.com --- You should be good for "fedpkg request-repo twincam 2052620" now.
https://bugzilla.redhat.com/show_bug.cgi?id=2052620
ecurtin@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|twincam - a lightweight |Review Request: twincam - a |camera application |lightweight camera | |application
https://bugzilla.redhat.com/show_bug.cgi?id=2052620
--- Comment #11 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/twincam
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com