Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=456178
Summary: Review Request: pyabiword - Python bindings for libabiword Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: uwog@uwog.net QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://uwog.net/~uwog/pyabiword.spec SRPM URL: http://uwog.net/~uwog/pyabiword-0.6.1-1.fc9.src.rpm Description: Python bindings for libabiword
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
rnorwood@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |rnorwood@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
rnorwood@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
rnorwood@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review-
------- Additional Comments From rnorwood@redhat.com 2008-07-22 12:30 EST ------- $ rpmlint ~/rpmbuild/SRPMS/pyabiword-0.6.1-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint /home/rnorwood/rpmbuild/RPMS/i386/pyabiword-0.6.1-1.fc9.i386.rpm pyabiword.i386: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
o AUTHORS and COPYING are good candidates for marking as %doc. (COPYING must be included). Also, the contents of the examples/ directory could be included.
o The source files don't include a license, which they should. The contents of the COPYING file (GPLv2) isn't enough to indicate the license. See: http://fedoraproject.org/wiki/Licensing/FAQ
o The 'Vendor' tag should not be used according to Fedora packaging guidelines. http://fedoraproject.org/wiki/Packaging/Guidelines
Everything else looks ok to me. Once the above issues are fixed, I can approve.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
rnorwood@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review- |fedora-review?
------- Additional Comments From rnorwood@redhat.com 2008-07-22 12:32 EST ------- Oops, I shouldn't have set the review flag to '-' while awaiting these fixes.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
------- Additional Comments From uwog@uwog.net 2008-07-22 13:51 EST ------- Spec URL: http://uwog.net/~uwog/pyabiword.spec SRPM URL: http://uwog.net/~uwog/pyabiword-0.6.1-2.fc9.src.rpm
Changes: - Added documentation, including examples - Removed old Vendor tag
Re licensing: I think the implied version is GPLv2+, as pyabiword links with libabiword. I'd prefer to update the spec when I get explicit approval from all contributors though.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
------- Additional Comments From rnorwood@redhat.com 2008-07-22 18:10 EST ------- Sorry, I neglected to check for missing BuildRequires - These needed to be added for the package to build in koji:
BuildRequires: gtk2-devel BuildRequires: libglade2-devel BuildRequires: libgnomeprintui22-devel BuildRequires: goffice04-devel BuildRequires: enchant-devel BuildRequires: fribidi-devel BuildRequires: wv-devel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
rnorwood@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From rnorwood@redhat.com 2008-07-22 18:12 EST ------- Assuming license issues and BR's are added, this gets a pass from me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
uwog@uwog.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From uwog@uwog.net 2008-07-22 18:29 EST ------- New Package CVS Request ======================= Package Name: pyabiword Short Description: Python bindings for libabiword Owners: uwog Branches: F-9 devel OLPC-3 InitialCC: uwog Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tummy.com
------- Additional Comments From kevin@tummy.com 2008-07-22 23:11 EST ------- Can we please sort out the license before importing/building? We don't want to distribute something we are unsure of the license of...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
------- Additional Comments From uwog@uwog.net 2008-07-23 05:09 EST ------- I am _sure_ it is GPL1+ now, because that is actually how the license works: if no explicit version is given, and that copyright file is included, then it is GPLv1+. That's just how it works. I asked some of the pyabiword devs, and they agree with that.
Now, that does not mean that I can't make the next release v2+ (which I will do, but 'relicencing' always takes time), but _this_ release is GPLv1+.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-07-23 11:41 EST ------- Ah indeed... sorry for the confusion on my part here, I was thinking there was no indication what the license was at all. :(
cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
------- Additional Comments From rnorwood@redhat.com 2008-07-30 21:53 EST ------- Marc, I think you can close this now. Thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
uwog@uwog.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
------- Additional Comments From uwog@uwog.net 2008-07-31 16:14 EST ------- Yep, thx.
package-review@lists.fedoraproject.org