[Bug 1486904] New: Review Request: python-pytest-benchmark - A py.test fixture for benchmarking code. It will group the tests into rounds that are calibrated to the chosen timer
https://bugzilla.redhat.com/show_bug.cgi?id=1486904
Bug ID: 1486904 Summary: Review Request: python-pytest-benchmark - A py.test fixture for benchmarking code. It will group the tests into rounds that are calibrated to the chosen timer Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: j.orti.alcaine@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jorti.fedorapeople.org/python-pytest-benchmark/python-pytest-benchma... SRPM URL: https://jorti.fedorapeople.org/python-pytest-benchmark/python-pytest-benchma... Description: This plugin provides a benchmark fixture. This fixture is a callable object that will benchmark any function passed to it.
Notable features and goals: - Sensible defaults and automatic calibration for microbenchmarks - Good integration with pytest - Comparison and regression tracking - Exhausive statistics - JSON export
Fedora Account System Username: jorti
https://bugzilla.redhat.com/show_bug.cgi?id=1486904
Juan Orti j.orti.alcaine@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1486767
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1486767 [Bug 1486767] Review Request: python-statistics - Port of Python 3.4 statistics to 2.7 and up
https://bugzilla.redhat.com/show_bug.cgi?id=1486904
Juan Orti j.orti.alcaine@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1486226
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1486226 [Bug 1486226] Review Request: python-guessit - Python library that extracts as much information as possible from a video filename
https://bugzilla.redhat.com/show_bug.cgi?id=1486904
Sandro Mani manisandro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |manisandro@gmail.com Assignee|nobody@fedoraproject.org |manisandro@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1486904
--- Comment #1 from Sandro Mani manisandro@gmail.com --- Mock reports: No matching package to install: 'python2-statistics'
https://bugzilla.redhat.com/show_bug.cgi?id=1486904
--- Comment #2 from Sandro Mani manisandro@gmail.com --- Oh never mind, missed the other review!
https://bugzilla.redhat.com/show_bug.cgi?id=1486904
--- Comment #3 from Sandro Mani manisandro@gmail.com --- E: summary-too-long C A py.test fixture for benchmarking code. It will group the tests into rounds that are calibrated to the
Rest looks good.
https://bugzilla.redhat.com/show_bug.cgi?id=1486904
--- Comment #4 from Juan Orti j.orti.alcaine@gmail.com --- Spec URL: https://jorti.fedorapeople.org/python-pytest-benchmark/python-pytest-benchma... SRPM URL: https://jorti.fedorapeople.org/python-pytest-benchmark/python-pytest-benchma...
https://bugzilla.redhat.com/show_bug.cgi?id=1486904 Bug 1486904 depends on bug 1486767, which changed state.
Bug 1486767 Summary: Review Request: python-statistics - Port of Python 3.4 statistics to 2.7 and up https://bugzilla.redhat.com/show_bug.cgi?id=1486767
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1486904
Sandro Mani manisandro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Sandro Mani manisandro@gmail.com --- All good, approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python2-pytest-benchmark-3.1.1-3.fc28.noarch.rpm python3-pytest-benchmark-3.1.1-3.fc28.noarch.rpm python-pytest-benchmark-3.1.1-3.fc28.src.rpm python2-pytest-benchmark.noarch: W: spelling-error Summary(en_US) py -> pt, p, y python2-pytest-benchmark.noarch: W: spelling-error Summary(en_US) benchmarking -> bench marking, bench-marking, benchmark python2-pytest-benchmark.noarch: W: spelling-error %description -l en_US microbenchmarks -> micro benchmarks, micro-benchmarks, benchmarks python3-pytest-benchmark.noarch: W: spelling-error Summary(en_US) py -> pt, p, y python3-pytest-benchmark.noarch: W: spelling-error Summary(en_US) benchmarking -> bench marking, bench-marking, benchmark python3-pytest-benchmark.noarch: W: spelling-error %description -l en_US microbenchmarks -> micro benchmarks, micro-benchmarks, benchmarks python3-pytest-benchmark.noarch: W: no-manual-page-for-binary py.test-benchmark python3-pytest-benchmark.noarch: W: no-manual-page-for-binary pytest-benchmark python-pytest-benchmark.src: W: spelling-error Summary(en_US) py -> pt, p, y python-pytest-benchmark.src: W: spelling-error Summary(en_US) benchmarking -> bench marking, bench-marking, benchmark python-pytest-benchmark.src: W: spelling-error %description -l en_US microbenchmarks -> micro benchmarks, micro-benchmarks, benchmarks 3 packages and 0 specfiles checked; 0 errors, 11 warnings.
Rpmlint (installed packages) ---------------------------- python2-pytest-benchmark.noarch: W: spelling-error Summary(en_US) py -> pt, p, y python2-pytest-benchmark.noarch: W: spelling-error Summary(en_US) benchmarking -> bench marking, bench-marking, benchmark python2-pytest-benchmark.noarch: W: spelling-error %description -l en_US microbenchmarks -> micro benchmarks, micro-benchmarks, benchmarks python3-pytest-benchmark.noarch: W: spelling-error Summary(en_US) py -> pt, p, y python3-pytest-benchmark.noarch: W: spelling-error Summary(en_US) benchmarking -> bench marking, bench-marking, benchmark python3-pytest-benchmark.noarch: W: spelling-error %description -l en_US microbenchmarks -> micro benchmarks, micro-benchmarks, benchmarks python3-pytest-benchmark.noarch: W: no-manual-page-for-binary py.test-benchmark python3-pytest-benchmark.noarch: W: no-manual-page-for-binary pytest-benchmark 2 packages and 0 specfiles checked; 0 errors, 8 warnings.
Requires -------- python2-pytest-benchmark (rpmlib, GLIBC filtered): python(abi) python2-cpuinfo python2-pathlib python2-pytest python2-statistics
python3-pytest-benchmark (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-cpuinfo python3-pytest
Provides -------- python2-pytest-benchmark: python-pytest-benchmark python2-pytest-benchmark python2.7dist(pytest-benchmark) python2dist(pytest-benchmark)
python3-pytest-benchmark: python3-pytest-benchmark python3.6dist(pytest-benchmark) python3dist(pytest-benchmark)
Source checksums ---------------- https://github.com/ionelmc/pytest-benchmark/archive/v3.1.1/pytest-benchmark-... : CHECKSUM(SHA256) this package : b05e2b2b8443e049a9a9789271bcc25d03a686fc9b4b26c09052db17008e9e90 CHECKSUM(SHA256) upstream package : b05e2b2b8443e049a9a9789271bcc25d03a686fc9b4b26c09052db17008e9e90
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1486904 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1486904
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-benchmark. You may create the branch "f27" using git in about 10 minutes.
https://bugzilla.redhat.com/show_bug.cgi?id=1486904
Juan Orti j.orti.alcaine@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2017-09-05 04:07:21
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com