Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: wmcalc - Calculator in a WindowMaker dockapp
https://bugzilla.redhat.com/show_bug.cgi?id=700862
Summary: Review Request: wmcalc - Calculator in a WindowMaker dockapp Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mariobl@freenet.de QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmcalc.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/wmcalc-0.3-1.fc14.src.rpm
Description: Wmcalc is a 64x64 pixel application that performs all the functions (and eventually more) of a simple four function calculator. It includes a 10 digit alpha-numeric display, and twenty buttons for user input. Clicking on the display will clear the calculator. It is specifically designed to be docked in Windowmaker, or 'Swallowed' by wharf in Afterstep. Of course, it should work in just about any window manager.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3035955
Well, it builds, but the debug package is still useless (debuginfo-without-sources). I've applied the variable CFLAGS="$RPM_OPT_FLAGS" to the "make" call, but without success.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
Martin Gieseking martin.gieseking@uos.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@uos.de
--- Comment #1 from Martin Gieseking martin.gieseking@uos.de 2011-04-29 13:22:14 EDT --- (In reply to comment #0)
Well, it builds, but the debug package is still useless (debuginfo-without-sources). I've applied the variable CFLAGS="$RPM_OPT_FLAGS" to the "make" call, but without success.
As you can see in the Makefile, CFLAGS is not used but FLAGS is. So just replace the variable and the %optflags should be applied.
If you want to add the configuration file with %doc, remove the leading dot as there shouldn't be any hidden doc files.
BTW, there is a memory issue in the application (array index out of bounds) that might lead to a segfault on some systems. The number 11 should be replaced with DISPSIZE in lines 117 and 118 of file wmcalc.c. If the upstream project is dead, you might want to add a corresponding patch yourself.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
--- Comment #2 from Mario Blättermann mariobl@freenet.de 2011-04-29 15:50:51 EDT --- Thanks for your hints.
Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmcalc.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/wmcalc-0.3-2.fc14.src.rpm
In case of the hidden file, I've renamed it to "wmcalc-config" to make somewhat clearer what it is for.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
--- Comment #3 from Mario Blättermann mariobl@freenet.de 2011-04-29 15:54:53 EDT --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3036469
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limb@jcomserv.net AssignedTo|nobody@fedoraproject.org |limb@jcomserv.net Flag| |fedora-review?
--- Comment #4 from Jon Ciesla limb@jcomserv.net 2011-07-18 09:17:59 EDT --- Good:
- rpmlint checks return:
wmcalc.x86_64: W: spelling-error Summary(en_US) dockapp -> dock app, dock-app, paddock The value of this tag appears to be misspelled. Please double-check.
Ignore.
wmcalc.x86_64: E: incorrect-fsf-address /usr/share/doc/wmcalc-0.3/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
Fix, probably just need a new copy of the file.
wmcalc.x86_64: W: no-manual-page-for-binary wmcalc Each executable in standard binary directories should have a man page.
Include if available.
2 packages and 0 specfiles checked; 1 errors, 2 warnings.
- package meets naming guidelines - package meets packaging guidelines - license ( GPLv2+ ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
Fix: Change license tag to GPLv2+
Question: Does this or does this not need a .desktop file?
Mock build in progress to double-check BRs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
--- Comment #5 from Jon Ciesla limb@jcomserv.net 2011-07-18 09:32:29 EDT --- Mock build was good, so it's just the license tag and .desktop question.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
--- Comment #6 from Mario Blättermann mariobl@freenet.de 2011-07-18 14:12:48 EDT --- (In reply to comment #4)
wmcalc.x86_64: E: incorrect-fsf-address /usr/share/doc/wmcalc-0.3/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
Fix, probably just need a new copy of the file.
Fixed,I've taken a new license file from the FSF website.
wmcalc.x86_64: W: no-manual-page-for-binary wmcalc Each executable in standard binary directories should have a man page.
Include if available.
I found a manpage in an Ubuntu package, which has been written originally for Debian: http://manpages.ubuntu.com/manpages/gutsy/man1/wmcalc.1.html
[...]
Fix: Change license tag to GPLv2+
Fixed.
Question: Does this or does this not need a .desktop file?
We don't need a *.desktop file for WindowMaker dockapps. See https://bugzilla.redhat.com/show_bug.cgi?id=701079#c5.
New files: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmcalc.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/wmcalc-0.3-3.fc15.src.rpm
Thanks for your time you spent on this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Jon Ciesla limb@jcomserv.net 2011-07-18 14:16:43 EDT --- Excellent, one problem, but I trust you'll fix it before importing:
wmcalc.x86_64: W: spurious-executable-perm /usr/share/man/man1/wmcalc.1.gz The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not.
Given that, APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
--- Comment #8 from Jon Ciesla limb@jcomserv.net 2011-07-18 14:17:49 EDT --- Oh, and one more thing, you might want to rename Source2 to wmcalc-gpl-2.0.txt, to avoid SRPM clobbering.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
--- Comment #9 from Mario Blättermann mariobl@freenet.de 2011-07-22 09:05:09 EDT --- Many thanks for your review! I've changed the files once again to reflect your review:
Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmcalc.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/wmcalc-0.3-4.fc15.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
Mario Blättermann mariobl@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #10 from Mario Blättermann mariobl@freenet.de 2011-07-22 09:07:26 EDT --- New Package SCM Request ======================= Package Name: wmcalc Short Description: Calculator in a WindowMaker dockapp Owners: mariobl Branches: f15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
--- Comment #11 from Jon Ciesla limb@jcomserv.net 2011-07-22 09:09:21 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-07-22 16:45:42 EDT --- wmcalc-0.3-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/wmcalc-0.3-4.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-07-22 21:55:24 EDT --- wmcalc-0.3-4.fc15 has been pushed to the Fedora 15 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-08-01 22:04:44 EDT --- wmcalc-0.3-4.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700862
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |wmcalc-0.3-4.fc15 Resolution| |ERRATA Last Closed| |2011-08-01 22:04:49
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla