Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: xfce4-xfswitch-plugin - User switching plugin for the Xfce4 Panel
https://bugzilla.redhat.com/show_bug.cgi?id=524413
Summary: Review Request: xfce4-xfswitch-plugin - User switching plugin for the Xfce4 Panel Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cwickert@fedoraproject.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://cwickert.fedorapeople.org/review/xfce4-xfswitch-plugin.spec SRPM URL: http://cwickert.fedorapeople.org/review/xfce4-xfswitch-plugin-0.0.1-1.fc12.s... Description: Xfswitch-plugin is a user switching plugin for the Xfce4 Panel. It allows you to leave the current session opened and open a new session with another user. At the moment it relies on GDM, but other display managers will be supported in the future.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524413
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |kevin@tummy.com Flag| |fedora-review?
--- Comment #1 from Kevin Fenzi kevin@tummy.com 2009-09-24 19:25:40 EDT --- I'd be happy to review this. Look for a full review in a while...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524413
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #2 from Kevin Fenzi kevin@tummy.com 2009-09-24 19:49:14 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: cb204f4a507f462d019529af6f547731 xfswitch-plugin-0.0.1.tar.gz cb204f4a507f462d019529af6f547731 xfswitch-plugin-0.0.1.tar.gz.orig OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK - No rpmlint output. OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
Issues:
1. Rpmlint says: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. (ie, nothing)
A simple package and everything looks good.
This package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524413
Christoph Wickert cwickert@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from Christoph Wickert cwickert@fedoraproject.org 2009-09-24 20:12:21 EDT --- Thanks, that was quick!
New Package CVS Request ======================= Package Name: xfce4-xfswitch-plugin Short Description: User switching plugin for the Xfce4 Panel Owners: cwickert Branches: F-10 F-11 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524413
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #4 from Kevin Fenzi kevin@tummy.com 2009-09-25 12:25:26 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524413
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2009-09-25 15:18:58 EDT --- xfce4-xfswitch-plugin-0.0.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/xfce4-xfswitch-plugin-0.0.1-1.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524413
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2009-09-25 15:20:54 EDT --- xfce4-xfswitch-plugin-0.0.1-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/xfce4-xfswitch-plugin-0.0.1-1.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524413
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #7 from Kevin Fenzi kevin@tummy.com 2009-09-26 17:04:13 EDT --- This is imported and built. Closing now. :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524413
Christoph Wickert cwickert@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |525563
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524413
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-10-06 06:03:33 EDT --- xfce4-xfswitch-plugin-0.0.1-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524413
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |0.0.1-1.fc10 Resolution|RAWHIDE |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524413
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-10-06 06:11:16 EDT --- xfce4-xfswitch-plugin-0.0.1-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524413
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.0.1-1.fc10 |0.0.1-1.fc11
package-review@lists.fedoraproject.org