[Bug 1292232] New: Review Request: nodejs-delegates - Delegate methods and accessors to another property - package-review

List overview All Threads
Download

newer

[Bug 1292232] New: Review Request: nodejs-delegates - Delegate methods and accessors to another property

older

[Bug 1267198] New: Review Request:...

[Bug 1292295] New: Review Request:...

Red Hat Bugzilla

16 Dec 2015 16 Dec '15

8:24 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

Bug ID: 1292232 Summary: Review Request: nodejs-delegates - Delegate methods and accessors to another property Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-delegates/nodejs-delegates.... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-delegates/nodejs-delegates-... Description: Delegate methods and accessors to another property Fedora Account System Username: jsmith

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

16 Dec 16 Dec

8:31 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

Jared Smith jsmith.fedora@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1292233

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1292233 [Bug 1292233] Review Request: nodejs-are-we-there-yet - Keep track of the overall completion of many disparate processes

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:01 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

Tom Hughes tom@compton.nu changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:08 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

Tom Hughes tom@compton.nu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #1 from Tom Hughes tom@compton.nu --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/tom/1292232 -nodejs-delegates/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: nodejs-delegates-1.0.0-1.fc24.noarch.rpm nodejs-delegates-1.0.0-1.fc24.src.rpm nodejs-delegates.noarch: W: spelling-error Summary(en_US) accessors -> accessory, accessorizes, accessorize nodejs-delegates.noarch: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize nodejs-delegates.noarch: W: only-non-binary-in-usr-lib nodejs-delegates.src: W: spelling-error Summary(en_US) accessors -> accessory, accessorizes, accessorize nodejs-delegates.src: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize 2 packages and 0 specfiles checked; 0 errors, 5 warnings.

Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory nodejs-delegates.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Requires -------- nodejs-delegates (rpmlib, GLIBC filtered): nodejs(engine)

Provides -------- nodejs-delegates: nodejs-delegates npm(delegates)

Source checksums ---------------- https://registry.npmjs.org/delegates/-/delegates-1.0.0.tgz : CHECKSUM(SHA256) this package : bfefdbf411ed50a94c7befbdd75fc49c4ff53b063d481e05bbac2f670acf6461 CHECKSUM(SHA256) upstream package : bfefdbf411ed50a94c7befbdd75fc49c4ff53b063d481e05bbac2f670acf6461

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1292232 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

17 Dec 17 Dec

2:49 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

--- Comment #2 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-delegates

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:34 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

--- Comment #3 from Fedora Update System updates@fedoraproject.org --- nodejs-delegates-1.0.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-cdaac304b9

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:34 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:35 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

--- Comment #4 from Fedora Update System updates@fedoraproject.org --- nodejs-delegates-1.0.0-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-25a4994f5a

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:35 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

--- Comment #5 from Fedora Update System updates@fedoraproject.org --- nodejs-delegates-1.0.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8cc0980d09

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:35 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

--- Comment #6 from Fedora Update System updates@fedoraproject.org --- nodejs-delegates-1.0.0-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-280da54fa1

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:49 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

Jared Smith jsmith.fedora@gmail.com changed:

--- Comment #7 from Jared Smith jsmith.fedora@gmail.com --- Closing as fixed in RAWHIDE to allow other packages to be reviewed.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:49 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

Jared Smith jsmith.fedora@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

18 Dec 18 Dec

12:26 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

Fedora Update System updates@fedoraproject.org changed:

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- nodejs-delegates-1.0.0-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update nodejs-delegates' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-25a4994f5a

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:54 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- nodejs-delegates-1.0.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update nodejs-delegates' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-cdaac304b9

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:19 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- nodejs-delegates-1.0.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update nodejs-delegates' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-280da54fa1

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:20 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- nodejs-delegates-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update nodejs-delegates' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8cc0980d09

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

20 Dec 20 Dec

7:09 p.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

Piotr Popieluch piotr1212@gmail.com changed:

--- Comment #12 from Piotr Popieluch piotr1212@gmail.com --- Built in rawhide, closing to unblock other review requests.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8 Feb 8 Feb

3:24 a.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- nodejs-delegates-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:24 a.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:53 a.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- nodejs-delegates-1.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:23 a.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- nodejs-delegates-1.0.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:22 a.m.

New subject: [Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- nodejs-delegates-1.0.0-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3453

Age (days ago)

3507

Last active (days ago)

package-review@lists.fedoraproject.org

21 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla