Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923035
Bug ID: 923035 Summary: Review Request: pybrain - The python machine learning library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: sanjay.ankur@gmail.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://ankursinha.fedorapeople.org/pybrain/pybrain.spec SRPM URL: http://ankursinha.fedorapeople.org/pybrain/pybrain-0.3.1-1.fc18.src.rpm
Description: PyBrain is a modular Machine Learning Library for Python. Its goal is to offer flexible, easy-to-use yet still powerful algorithms for Machine Learning Tasks and a variety of predefined environments to test and compare your algorithms.
PyBrain is short for Python-Based Reinforcement Learning, Artificial Intelligence and Neural Network Library. In fact, we came up with the name first and later reverse-engineered this quite descriptive "Backronym".
Fedora Account System Username: ankursinha
rpmlint info: [ankur@dhcppc1 SRPMS]$ rpmlint ../SPECS/pybrain.spec ./pybrain-0.3.1-1.fc18.src.rpm /var/lib/mock/fedora-18-x86_64/result/*.rpm ../SPECS/pybrain.spec:13: W: macro-in-comment %{name} ../SPECS/pybrain.spec:13: W: macro-in-comment %{name} ../SPECS/pybrain.spec:13: W: macro-in-comment %{version} ../SPECS/pybrain.spec: W: invalid-url Source0: pybrain-0.3.1.tar.gz pybrain.src:13: W: macro-in-comment %{name} pybrain.src:13: W: macro-in-comment %{name} pybrain.src:13: W: macro-in-comment %{version} pybrain.src: W: invalid-url Source0: pybrain-0.3.1.tar.gz pybrain.src:13: W: macro-in-comment %{name} pybrain.src:13: W: macro-in-comment %{name} pybrain.src:13: W: macro-in-comment %{version} pybrain.src: W: invalid-url Source0: pybrain-0.3.1.tar.gz 3 packages and 1 specfiles checked; 0 errors, 12 warnings. [ankur@dhcppc1 SRPMS]$
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923035
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@zarb.org Assignee|nobody@fedoraproject.org |misc@zarb.org
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923035
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #1 from Michael Scherer misc@zarb.org ---
Package Review ==============
Key: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package should contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - Large documentation must go in a -doc subpackage. Note: Documentation size is 2078720 bytes in 189 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - no need for macro python_sitelib as they are in rpm already
- no need for CFLAGS in %build
- since the package come from github, I think there is some guideline on how to download https://fedoraproject.org/wiki/Packaging:SourceURL#Github I think clearer instruction would help
- no need for rm -Rf RPM_BUILD_ROOT in %install
- you can use sed -i in %install
- since there is tests, they should be run in %check
- while I am not sure of everything, it seems that some packages are needed for some features : pylab numpy mlabwrap OpenGL.GLUT
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/misc/checkout/git/FedoraReview/923035-pybrain/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: pybrain-0.3.1-1.fc18.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint pybrain 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:'
Requires -------- pybrain (rpmlib, GLIBC filtered): python(abi)
Provides -------- pybrain: pybrain
Generated by fedora-review 0.4.0 (cf29f98) last change: 2013-02-08 Buildroot used: fedora-18-x86_64 Command line :./try-fedora-review -b 923035
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923035
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #2 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Hi Michael,
There are a few optional deps here:
https://github.com/pybrain/pybrain/wiki/Dependencies
While they appear to be runtime, I'll package them up so that pybrain can be better utilised.
Thanks, Warm regards, Ankur
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923035
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |pybrain
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923035
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |927485 (python-rlglue)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923035
--- Comment #3 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Hi Michael,
I've updated the spec/srpm with the requested changes:
* Mon Mar 25 2013 Ankur Sinha <ankursinha AT fedoraproject DOT org> 0.3.1-2 - Correct issues in rhbz# 923035 - run tests - doc separate package - add requires - remove arch specific spec bits
Some of the requires aren't in Fedora. I'm packaging them up too. They're runtime requires which are listed as optional on the project wiki page. I've added them to the spec and will not build until they're all in the repos. Adding blocker bugs too.
SPEC/SRPM:
http://ankursinha.fedorapeople.org/pybrain/pybrain.spec
http://ankursinha.fedorapeople.org/pybrain/pybrain-0.3.1-2.fc20.src.rpm
Thanks, Warm regards, Ankur
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923035
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |927550 (pycdf)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923035
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |927611 (pyode)
https://bugzilla.redhat.com/show_bug.cgi?id=923035
Bug 923035 depends on bug 927611, which changed state.
Bug 927611 Summary: Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine https://bugzilla.redhat.com/show_bug.cgi?id=927611
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=923035
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@gmail.co | |m
--- Comment #4 from Mario Blättermann mario.blaettermann@gmail.com --- Requires: python-imaging
Note, python-imaging is provided virtually by python-pillow since f19 [1]. Make sure it works with Pillow. In some cases small code modifications are needed [2].
[1] http://fedoraproject.org/wiki/Features/Pillow [2] http://fedoraproject.org/wiki/Features/Pillow#How_To_Test
https://bugzilla.redhat.com/show_bug.cgi?id=923035
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@gmail.com, | |sanjay.ankur@gmail.com Flags| |needinfo?(sanjay.ankur@gmai | |l.com)
https://bugzilla.redhat.com/show_bug.cgi?id=923035
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | Flags|needinfo?(sanjay.ankur@gmai | |l.com) |
--- Comment #5 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- I'll update the spec for pillow when I submit a new spec next. Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=923035 Bug 923035 depends on bug 927550, which changed state.
Bug 927550 Summary: Review Request: pycdf - A python interface to the Unidata netCDF library https://bugzilla.redhat.com/show_bug.cgi?id=927550
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX
https://bugzilla.redhat.com/show_bug.cgi?id=923035
--- Comment #8 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Well, there's no documentation to suggest what optional dependency is required for what purpose. The docs specify the pyode is required for using ODEs and nothing else. Unfortunately, I'm not using this library for work any more so I don't have much of an incentive to chase this down. I cannot break it down into subpackages. If the current way of pulling in the optional deps isn't good enough, I'm afraid I'll have to drop the package :/
Thanks, Warm regards, Ankur
https://bugzilla.redhat.com/show_bug.cgi?id=923035
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Last Closed| |2017-12-17 09:39:25
https://bugzilla.redhat.com/show_bug.cgi?id=923035 Bug 923035 depends on bug 927485, which changed state.
Bug 927485 Summary: Review Request: python-rlglue - Python codec for rlglue https://bugzilla.redhat.com/show_bug.cgi?id=927485
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX
package-review@lists.fedoraproject.org