Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
Summary: Review Request: pikloops - Code generator for PIC delays Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: aportal@univ-montp2.fr QAContact: fedora-package-review@redhat.com
Spec URL: http://linuxelectronique.free.fr/download/fedora/5/SPECS/pikloops.spec SRPM URL: http://linuxelectronique.free.fr/download/fedora/5/SRPMS/pikloops-0.2.1-1.sr... Description: PiKLoop generate for you code to create delays for Microchip PIC microcontrollers. It is an useful companion for Pikdev or Piklab IDE.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From Jochen@herr-schmitt.de 2006-09-27 13:41 EST ------- Good: + Rpmlint doesn't complaint source rpm. + Local build works fine. + Tar ball in source rpm matches with upstream + Local install/uninstall works fine. + Rpmlint of installed rpm doesn't complaints. + Programm starts properly. + Mock build works fine.
Bad: - Debuginfo package is empty. - QT environment variable are not sourced. - Desktop file: the Categories tag should contain Application (wiki: PackagingGuidelines#desktop) - Missing dependancy on update-desktop-database for %post (package desktop-file-utils) - Missing dependancy on update-desktop-database for %postun (package desktop-file-utils)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
aportal@univ-montp2.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alain.portal@free.fr
------- Additional Comments From aportal@univ-montp2.fr 2006-09-28 07:27 EST ------- (In reply to comment #1)
Bad:
- Debuginfo package is empty.
What can I do? I don't kknow why it is empty.
- QT environment variable are not sourced.
Why sourcing QT environment variable
- Desktop file: the Categories tag should contain Application (wiki: PackagingGuidelines#desktop)
I see a sample, not sure this is a MUST.
- Missing dependancy on update-desktop-database for %post (package
desktop-file-utils)
- Missing dependancy on update-desktop-database for %postun (package
desktop-file-utils)
This BuildRequires is no more needed since FC5 http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-de6770dd9867f...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From Jochen@herr-schmitt.de 2006-09-28 10:26 EST ------- 1.) Don't script the executables. Please use the gcc -g compiler flag.
2.) To be sure to compile with the right QT version.
4.) OK.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From aportal@univ-montp2.fr 2006-09-28 12:03 EST ------- (In reply to comment #3)
1.) Don't script the executables.
Sorry, I don't understand.
Please use the gcc -g compiler flag.
Just after %configure, I made: %{__sed} -i -e 's/CC = gcc/CC = gcc -g/' Makefile %{__sed} -i -e 's/CPP = gcc -E/CPP = gcc -E -g/' Makefile %{__sed} -i -e 's/CXX = g++/CXX = g++ -g/' Makefile %{__sed} -i -e 's/CXXCPP = g++ -E/CXXCPP = g++ -E -g/' Makefile %{__sed} -i -e 's/CC = gcc/CC = gcc -g/' %{name}/Makefile %{__sed} -i -e 's/CPP = gcc -E/CPP = gcc -E -g/' %{name}/Makefile %{__sed} -i -e 's/CXX = g++/CXX = g++ -g/' %{name}/Makefile %{__sed} -i -e 's/CXXCPP = g++ -E/CXXCPP = g++ -E -g/' %{name}/Makefile
debug-info rpm still empty
2.) To be sure to compile with the right QT version.
It seems to me there is only one QT version on each FC?, the last updated. The only problem I encountred was to buils under FC4 on arch x86_64.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169132
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From aportal@univ-montp2.fr 2006-09-28 12:09 EST ------- (In reply to comment #1)
Bad:
- Debuginfo package is empty.
I found. That was because of make install-strip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From aportal@univ-montp2.fr 2006-09-28 12:10 EST ------- Spec URL: http://linuxelectronique.free.fr/download/fedora/5/SPECS/pikloops.spec SRPM URL: http://linuxelectronique.free.fr/download/fedora/5/SRPMS/pikloops-0.2.1-2.sr...
%changelog * Thu Sep 28 2006 Alain Portal <aportal[AT]univ-montp2[DOT]fr> 0.2.1-2 - Don't make install-strip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-09-28 13:16 EST ------- Usually the files under /etc/profile.d is correctly "source"d (you can check this by trying to add "set" in the first line of %build). So "source"ing /etc/profile.d/qt.sh is not necessary.
This can be checked by a example of kbackup: http://buildsys.fedoraproject.org/logs/fedora-development-extras/18479-kback... (this is reviewed by me).
By the way, you should add %?dist tag.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From aportal@univ-montp2.fr 2006-09-28 13:30 EST ------- (In reply to comment #7)
By the way, you should add %?dist tag.
Oups...
SRPM URL: http://linuxelectronique.free.fr/download/fedora/5/SRPMS/pikloops-0.2.1-3.sr...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-09-29 07:48 EST ------- One question.
Why does /usr/share/applications/kde/pikloops.desktop have OnlyShowIn=KDE; ?
I tried to remove this, and PiKLoops icon appears on "Programming" session, so I think this can be shown in GNOME, too.
Other things seem to be okay.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From aportal@univ-montp2.fr 2006-09-29 08:03 EST ------- (In reply to comment #9)
One question.
Why does /usr/share/applications/kde/pikloops.desktop have OnlyShowIn=KDE; ?
I tried to remove this, and PiKLoops icon appears on "Programming" session, so I think this can be shown in GNOME, too.
It seems to me that was to prevent duplicate desktop entry in menu. Do I have to remove it?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-09-29 08:11 EST ------- (In reply to comment #10)
(In reply to comment #9)
One question.
Why does /usr/share/applications/kde/pikloops.desktop have OnlyShowIn=KDE; ?
It seems to me that was to prevent duplicate desktop entry in menu. Do I have to remove it?
Do you see some duplicate in KDE? In GNOME (I use GNOME), when the line OnlyShowIn=KDE; is removed, the PiKLoops seems to appear only in "Programming" entry and to have no duplicates.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From aportal@univ-montp2.fr 2006-09-29 08:40 EST ------- (In reply to comment #11)
Do you see some duplicate in KDE?
No, only one. I don't understand why I have to relogin to see the new entry in the menu...
In GNOME (I use GNOME), when the line OnlyShowIn=KDE; is removed, the PiKLoops seems to appear only in "Programming" entry and to have no duplicates.
And you see nothing if it isn't removed?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-09-29 08:54 EST ------- (In reply to comment #12)
(In reply to comment #11)
Do you see some duplicate in KDE?
No, only one. I don't understand why I have to relogin to see the new entry in the menu...
Umm.. I don't know either because I use GNOME...
In GNOME (I use GNOME), when the line OnlyShowIn=KDE; is removed, the PiKLoops seems to appear only in "Programming" entry and to have no duplicates.
And you see nothing if it isn't removed?
Yes, actually I see nothing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From aportal@univ-montp2.fr 2006-09-29 09:07 EST ------- (In reply to comment #13)
(In reply to comment #12)
(In reply to comment #11)
Do you see some duplicate in KDE?
No, only one. I don't understand why I have to relogin to see the new entry in the
menu...
Umm.. I don't know either because I use GNOME...
In GNOME (I use GNOME), when the line OnlyShowIn=KDE; is removed, the PiKLoops seems to appear only in "Programming" entry and to have no duplicates.
And you see nothing if it isn't removed?
Yes, actually I see nothing.
OK, I'll update the desktop file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From aportal@univ-montp2.fr 2006-09-29 09:15 EST ------- Spec URL: http://linuxelectronique.free.fr/download/fedora/5/SPECS/pikloops.spec SRPM URL: http://linuxelectronique.free.fr/download/fedora/5/SRPMS/pikloops-0.2.1-4.sr...
%changelog * Thu Sep 28 2006 Alain Portal <aportal[AT]univ-montp2[DOT]fr> 0.2.1-4 - Update %%{SOURCE1} which don't contain "OnlyShowIn=KDE;" any more
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From aportal@univ-montp2.fr 2006-09-29 09:24 EST ------- (In reply to comment #14)
I don't understand why I have to relogin to see the new entry in the
menu...
Umm.. I don't know either because I use GNOME...
Grrrr! I found... That was because there wasn't "Application" in categories.
But perhaps now, you could have duplicate entry. Let me know. Spec URL: http://linuxelectronique.free.fr/download/fedora/5/SPECS/pikloops.spec SRPM URL: http://linuxelectronique.free.fr/download/fedora/5/SRPMS/pikloops-0.2.1-5.sr...
%changelog * Thu Sep 28 2006 Alain Portal <aportal[AT]univ-montp2[DOT]fr> 0.2.1-5 - Update %%{SOURCE1} to add Application category
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-09-29 10:46 EST ------- (In reply to comment #16)
(In reply to comment #14)
But perhaps now, you could have duplicate entry. Let me know.
The result is: only one entry is shown, no duplicate. I will check if the other things to be fixed is left.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-09-29 12:06 EST ------- Well, accroding to http://fedoraproject.org/wiki/Packaging/ScriptletSnippets : desktop file does not have mimetype key, so calling update-desktop-database is not necessary.
Other things are okay. ------------------------------------------------ This package (pikloops) is APPROVED by me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From aportal@univ-montp2.fr 2006-09-29 12:23 EST ------- OK, thanks for the review!
%changelog * Fri Sep 29 2006 Alain Portal <aportal[AT]univ-montp2[DOT]fr> 0.2.1-6 - Remove useless update-desktop-database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
aportal@univ-montp2.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
aportal@univ-montp2.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From aportal@univ-montp2.fr 2007-07-20 14:42 EST ------- Package Change Request ====================== Package Name: pikloops Updated Fedora Owners: alain.portal@free.fr
Please, add my home email in comps because I'm on vacation for 6 weeks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs-
------- Additional Comments From wtogami@redhat.com 2007-07-23 17:29 EST ------- Sorry, we can't do this. Owners must match your Bugzilla account.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254
------- Additional Comments From aportal@univ-montp2.fr 2007-07-23 18:57 EST ------- What choice do you let me? - ask alain.portal AT free.fr for co-maintaining the package? - orphaning all packages?
If I can't receive bug reports when I'm on vacation, sure, I can't be a Fedora contributor. I'll never check my work email (my Fedora account) while I'm on vacation.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pikloops - Code generator for PIC delays
https://bugzilla.redhat.com/show_bug.cgi?id=208254
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=208254
Chitlesh GOORAH chitlesh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |chitlesh@gmail.com
--- Comment #23 from Chitlesh GOORAH chitlesh@gmail.com 2010-07-18 06:43:52 EDT --- Package Change Request ======================= Package Name: pikloops Short Description: Code generator for PIC delays Owners: chitlesh Branches: EL-5 EL-6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=208254
Chitlesh GOORAH chitlesh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs- |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=208254
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #24 from Kevin Fenzi kevin@tummy.com 2010-07-19 00:26:09 EDT --- cvs done
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla