https://bugzilla.redhat.com/show_bug.cgi?id=1948661
Bug ID: 1948661 Summary: Review Request: perl-YAML-PP-LibYAML - Faster parsing for YAML::PP Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jplesnik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jplesnik.fedorapeople.org/perl-YAML-PP-LibYAML/perl-YAML-PP-LibYAML.... SRPM URL: https://jplesnik.fedorapeople.org/perl-YAML-PP-LibYAML/perl-YAML-PP-LibYAML-... Description: YAML::PP::LibYAML is a subclass of YAML::PP. Instead of using YAML::PP::Parser as a the backend parser, it uses YAML::PP::LibYAML::Parser which calls YAML::LibYAML::API, an XS wrapper around the C libyaml.
Fedora Account System Username: jplesnik@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1948661
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1947805 Depends On| |1948651
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1947805 [Bug 1947805] perl-YAML-PP-0.027 is available https://bugzilla.redhat.com/show_bug.cgi?id=1948651 [Bug 1948651] Review Request: perl-YAML-LibYAML-API - Wrapper around the C libyaml library
https://bugzilla.redhat.com/show_bug.cgi?id=1948661 Bug 1948661 depends on bug 1948651, which changed state.
Bug 1948651 Summary: Review Request: perl-YAML-LibYAML-API - Wrapper around the C libyaml library https://bugzilla.redhat.com/show_bug.cgi?id=1948651
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1948661
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mspacek@redhat.com Assignee|nobody@fedoraproject.org |mspacek@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1948661
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1948661
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1948661
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Michal Josef Spacek mspacek@redhat.com --- Issues: - "YAML::LibYAML::API" => "0.011" in Makefile.PL vs perl(YAML::LibYAML::API::XS) >= 0.012 in spec file
[X] read spec file and check [X] Build in mock [X] rpmlint check [X] fedora-review build and check [X] look to final rpm dependencies
I am approving this package.
https://bugzilla.redhat.com/show_bug.cgi?id=1948661
--- Comment #2 from Michal Josef Spacek mspacek@redhat.com --- Better review :-)
Issues: - "YAML::LibYAML::API" => "0.011" in Makefile.PL vs perl(YAML::LibYAML::API::XS) >= 0.012 in spec file
[X] source file [X] summary [X] description [X] license [X] URL [X] Source0 [X] tests passed [X] BuildRequires
rpm -qp --requires perl-YAML-PP-LibYAML-0.005-1.fc35.noarch.rpm | sort | uniq -c | grep -v rpmlib
1 perl(base) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.32.1) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) 1 perl(YAML::LibYAML::API::XS) >= 0.011 1 perl(YAML::PP::Emitter) 1 perl(YAML::PP::LibYAML::Emitter) 1 perl(YAML::PP::LibYAML::Parser) 1 perl(YAML::PP::Parser) 1 perl(YAML::PP::Reader) 1 perl(YAML::PP::Writer) 1 perl(YAML::PP) >= 0.025
rpm -qp --provides perl-YAML-PP-LibYAML-0.005-1.fc35.noarch.rpm | sort | uniq -c
1 perl(YAML::PP::LibYAML::Emitter) = 0.005 1 perl(YAML::PP::LibYAML::Parser) = 0.005 1 perl(YAML::PP::LibYAML) = 0.005 1 perl-YAML-PP-LibYAML = 0.005-1.fc35
rpmlint perl-YAML-PP-LibYAML-0.005-1.fc35.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
The package is in line with Fedora and Perl packaging guide lines.
https://bugzilla.redhat.com/show_bug.cgi?id=1948661
--- Comment #3 from Jitka Plesnikova jplesnik@redhat.com --- https://pagure.io/releng/fedora-scm-requests/issue/33905
https://bugzilla.redhat.com/show_bug.cgi?id=1948661
--- Comment #4 from Jens Petersen petersen@redhat.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-YAML-PP-LibYAML
https://bugzilla.redhat.com/show_bug.cgi?id=1948661
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-YAML-PP-LibYAML-0.005- | |1.fc35 Resolution|--- |RAWHIDE Last Closed| |2021-05-12 12:06:25
--- Comment #5 from Jitka Plesnikova jplesnik@redhat.com --- Thank you for the review and the repository.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com