[Bug 226287] New: Merge Review: perl-XML-LibXML

List overview All Threads
Download

newer

older

[Bug 794722] Review Request: rngom...

[Bug 790349] New: Review Request:...

Red Hat Bugzilla

31 Jan 2007 31 Jan '07

2:38 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226287

Summary: Merge Review: perl-XML-LibXML Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: rnorwood@redhat.com

Fedora Merge Review: perl-XML-LibXML

http://cvs.fedora.redhat.com/viewcvs/devel/perl-XML-LibXML/ Initial Owner: rnorwood@redhat.com

-- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Show replies by date

Red Hat Bugzilla

22 Oct 22 Oct

4:04 a.m.

New subject: [Bug 226287] Merge Review: perl-XML-LibXML

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-XML-LibXML

https://bugzilla.redhat.com/show_bug.cgi?id=226287

bugzilla@redhat.com changed:

panemade@gmail.com changed:

------- Additional Comments From panemade@gmail.com 2007-10-22 05:04 EST ------- 1)perl as BR is not needed. mock build without it worked successfully. remove redundant dependency on perl >= 2:5.8.0 2)drop "|| :" from %check 3)you may like to use simple disttag like "2%{?dist}" 4)you may like to use Source URL as http://www.cpan.org/authors/id/P/PA/PAJAS/XML-LibXML-%%7Bversion%7D.tar.gz 5)rpmlint on SRPM and RPM gave me-> perl-XML-LibXML.i386: W: file-not-utf8 /usr/share/doc/perl-XML-LibXML-1.62001/Changes The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). ==> Use iconv command on that file

perl-XML-LibXML.i386: W: dangerous-command-in-%preun perl perl-XML-LibXML.i386: W: dangerous-command-in-%trigger perl ==>rpmlint suggested not to use perl command but is this some kind of workaround for some problem?

6)make test skipped one test => t/11memory....................ok 26/26 skipped: developers only (set MEMORY_TEST=1 to run these tests) make test should run all tests.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

25 Oct 25 Oct

4:47 p.m.

New subject: [Bug 226287] Merge Review: perl-XML-LibXML

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-XML-LibXML

https://bugzilla.redhat.com/show_bug.cgi?id=226287

------- Additional Comments From rnorwood@redhat.com 2007-10-25 17:47 EST ------- I've updated to the latest upstream version, 1.65.

perl-XML-LibXML-1.65-1.fc9 should fix issues 1-5.

For #6 - I think we generally don't run author/developer tests. In this case, the memory test at least seems to take a very long time. Similarly, 1.65 adds a threads test which also takes a long time. I recommend we leave both of these out.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

11:44 p.m.

New subject: [Bug 226287] Merge Review: perl-XML-LibXML

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-XML-LibXML

https://bugzilla.redhat.com/show_bug.cgi?id=226287

------- Additional Comments From panemade@gmail.com 2007-10-26 00:44 EST ------- rpmlint gave me perl-XML-LibXML.i386: W: dangerous-command-in-%preun perl perl-XML-LibXML.i386: W: dangerous-command-in-%trigger perl If you feel its necessary for this package then I can approve this package with those warnings.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

26 Oct 26 Oct

11:44 a.m.

New subject: [Bug 226287] Merge Review: perl-XML-LibXML

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-XML-LibXML

https://bugzilla.redhat.com/show_bug.cgi?id=226287

------- Additional Comments From rnorwood@redhat.com 2007-10-26 12:44 EST ------- Yes, there's not really any other way to do this - registration of the parsers is required at install/uninstall time. It's pretty nasty, though, and I wish there were a better way.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

8:36 p.m.

New subject: [Bug 226287] Merge Review: perl-XML-LibXML

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-XML-LibXML

https://bugzilla.redhat.com/show_bug.cgi?id=226287

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From panemade@gmail.com 2007-10-26 21:36 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM But not for RPM. perl-XML-LibXML.i386: W: dangerous-command-in-%preun perl perl-XML-LibXML.i386: W: dangerous-command-in-%trigger perl + source files match upstream url 7871c21078f706690cda9ca68d4ddac6 XML-LibXML-1.65.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01basic.....................

Compiled against libxml2 version: 20630 Running libxml2 version: 20630

ok t/02parse.....................ok t/03doc.......................ok t/04node......................ok t/05text......................ok t/06elements..................ok t/07dtd.......................ok t/08findnodes.................ok t/09xpath.....................ok t/10ns........................ok t/11memory....................ok 26/26 skipped: developers only (set MEMORY_TEST=1 to run these tests) t/12html......................ok t/13dtd.......................ok t/14sax.......................ok t/15nodelist..................ok t/16docnodes..................ok t/17callbacks.................ok t/18docfree...................ok t/19encoding..................ok t/20extras....................ok t/23rawfunctions..............ok t/24c14n......................ok t/25relaxng...................ok t/26schema....................ok t/27new_callbacks_simple......ok t/28new_callbacks_multiple....ok t/29id........................ok t/30xpathcontext..............ok t/31xpc_functions.............ok t/32xpc_variables.............ok t/40reader....................ok t/41xinclude..................ok t/90threads...................ok 14/14 skipped: optional (set THREAD_TEST=1 to run these tests) All tests successful, 40 subtests skipped. Files=33, Tests=1805, 3 wallclock secs ( 3.09 cusr + 0.47 csys = 3.56 CPU) + Package perl-XML-LibXML-1.65-1.fc8 -> Provides: LibXML.so perl(XML::LibXML) = 1.65 perl(XML::LibXML::Attr) perl(XML::LibXML::Boolean) = 1.65 perl(XML::LibXML::CDATASection) perl(XML::LibXML::Comment) perl(XML::LibXML::Document) perl(XML::LibXML::DocumentFragment) perl(XML::LibXML::Dtd) perl(XML::LibXML::Element) perl(XML::LibXML::InputCallback) perl(XML::LibXML::Literal) = 1.65 perl(XML::LibXML::NamedNodeMap) perl(XML::LibXML::Namespace) perl(XML::LibXML::Node) perl(XML::LibXML::NodeList) = 1.65 perl(XML::LibXML::Number) = 1.65 perl(XML::LibXML::PI) perl(XML::LibXML::Reader) = 1.65 perl(XML::LibXML::RelaxNG) perl(XML::LibXML::SAX) = 1.65 perl(XML::LibXML::SAX::AttributeNode) perl(XML::LibXML::SAX::Builder) = 1.65 perl(XML::LibXML::SAX::Generator) = 1.65 perl(XML::LibXML::SAX::Parser) = 1.65 perl(XML::LibXML::Schema) perl(XML::LibXML::Text) perl(XML::LibXML::XPathContext) = 1.65 perl(XML::LibXML::_SAXParser) Requires: /bin/sh libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libm.so.6 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libxml2.so.2 libz.so.1 perl >= 1:5.8.0 perl(:MODULE_COMPAT_5.8.8) perl(:WITH_ITHREADS) perl(:WITH_LARGEFILES) perl(:WITH_THREADS) perl(Carp) perl(DynaLoader) perl(Exporter) perl(IO::File) perl(IO::Handle) perl(XML::LibXML) perl(XML::LibXML::Boolean) perl(XML::LibXML::Common) perl(XML::LibXML::Literal) perl(XML::LibXML::NodeList) perl(XML::LibXML::Number) perl(XML::LibXML::XPathContext) perl(XML::NamespaceSupport) perl(XML::SAX::Base) perl(XML::SAX::DocumentLocator) perl(XML::SAX::Exception) perl(base) perl(constant) perl(overload) perl(strict) perl(vars) perl(warnings) rtld(GNU_HASH)

APPROVED.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

11 Nov 11 Nov

1:04 a.m.

New subject: [Bug 226287] Merge Review: perl-XML-LibXML

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-XML-LibXML

https://bugzilla.redhat.com/show_bug.cgi?id=226287

------- Additional Comments From panemade@gmail.com 2007-11-11 02:04 EST ------- Can we CLOSE this review if package is already built and in rawhide?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

12 Nov 12 Nov

4:38 a.m.

New subject: [Bug 226287] Merge Review: perl-XML-LibXML

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-XML-LibXML

https://bugzilla.redhat.com/show_bug.cgi?id=226287

panemade@gmail.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

23 Feb 23 Feb

2:01 a.m.

New subject: [Bug 226287] Merge Review: perl-XML-LibXML

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226287

Petr Pisar ppisar@redhat.com changed:

--- Comment #7 from Petr Pisar ppisar@redhat.com 2012-02-23 03:01:13 EST --- Package Change Request ====================== Package Name: Branches: f15 f16 f17 Owners: InitialCC: perl-sig

Please add perl-sig user with watch* permissions only into all Fedora branches.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

Red Hat Bugzilla

7:27 a.m.

New subject: [Bug 226287] Merge Review: perl-XML-LibXML

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226287

Jon Ciesla limburgher@gmail.com changed:

--- Comment #8 from Jon Ciesla limburgher@gmail.com 2012-02-23 08:27:26 EST --- Done, please include the package name in the future.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

Red Hat Bugzilla

7:38 a.m.

New subject: [Bug 226287] Merge Review: perl-XML-LibXML

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226287

Petr Pisar ppisar@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

--- Comment #9 from Petr Pisar ppisar@redhat.com 2012-02-23 08:38:51 EST --- Package Change Request ====================== Package Name: perl-XML-LibXML Branches: f17 Owners: InitialCC: perl-sig

Please add perl-sig user with watch* permissions only into F17 branch too. You seem to omit it.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

Red Hat Bugzilla

8:04 a.m.

New subject: [Bug 226287] Merge Review: perl-XML-LibXML

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226287

--- Comment #10 from Jon Ciesla limburgher@gmail.com 2012-02-23 09:04:24 EST --- Whoops. Done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

4716

Age (days ago)

6565

Last active (days ago)

package-review@lists.fedoraproject.org

11 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla