[Bug 1460199] New: Review Request: jsonrpc-glib - A JSON-RPC library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460199

Bug ID: 1460199
           Summary: Review Request: jsonrpc-glib - A JSON-RPC library for
                    GLib
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: http://declera.com/~yaneti/jsonrpc-glib/jsonrpc-glib.spec
SRPM URL:
http://declera.com/~yaneti/jsonrpc-glib/jsonrpc-glib-3.25.2-1.fc27.src.rpm
Description: Jsonrpc-GLib is a JSON-RPC library for GLib. It includes support
for communicating as both a JSON-RPC client and server. Additionally, it
supports upgrating connections to use GVariant for less runtime overhead.
Fedora Account System Username: yaneti

[Bug 1460199] Review Request: jsonrpc-glib - A JSON-RPC library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460199

--- Comment #1 from Yanko Kaneti  ---
- 3.25.2-2
- Address some issues from the other review - -2

Spec URL: http://declera.com/~yaneti/jsonrpc-glib/jsonrpc-glib.spec
SRPM URL:
http://declera.com/~yaneti/jsonrpc-glib/jsonrpc-glib-3.25.2-2.fc27.src.rpm

Plase note. No %chect because upstream hasn't fully defined the test yet it
seems.

[Bug 1460199] Review Request: jsonrpc-glib - A JSON-RPC library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460199

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

--- Comment #2 from Kalev Lember  ---
Taking for review.

[Bug 1460199] Review Request: jsonrpc-glib - A JSON-RPC library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460199

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

--- Comment #3 from Kalev Lember  ---
Fedora review jsonrpc-glib-3.25.2-2.fc27.src.rpm 2017-06-09

$ rpmlint jsonrpc-glib-3.25.2-2.fc27.src.rpm \
          jsonrpc-glib \
          jsonrpc-glib-debuginfo \
          jsonrpc-glib-devel
jsonrpc-glib.src: W: spelling-error %description -l en_US runtime -> run time,
run-time, rudiment
jsonrpc-glib.x86_64: W: spelling-error %description -l en_US runtime -> run
time, run-time, rudiment
jsonrpc-glib-devel.x86_64: W: only-non-binary-in-usr-lib
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ OK
! needs attention

+ rpmlint warnings are harmless and can be ignored
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (COPYING) is included in %license
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm

3caca5989e5b406c0777b4a9688c50c7e8c746757d8e832e6dfd4307824126dfeb223bc96d37da243cbc81e795ca11cf940f017c0bae5896a89c64589c0fb81c
 jsonrpc-glib-3.25.2.tar.xz

3caca5989e5b406c0777b4a9688c50c7e8c746757d8e832e6dfd4307824126dfeb223bc96d37da243cbc81e795ca11cf940f017c0bae5896a89c64589c0fb81c
 Download/jsonrpc-glib-3.25.2.tar.xz
+ The package builds in koji
(https://koji.fedoraproject.org/koji/taskinfo?taskID=19935565)
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ locale handling
+ ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
+ -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8

Looks good to me! APPROVED

[Bug 1460199] Review Request: jsonrpc-glib - A JSON-RPC library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460199

--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/jsonrpc-glib

[Bug 1460199] Review Request: jsonrpc-glib - A JSON-RPC library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460199

Yanko Kaneti  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2017-06-10 02:52:39

--- Comment #5 from Yanko Kaneti  ---
Built in rawhide

Thanks