Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-map - String/symbol indifferent ordered hash
https://bugzilla.redhat.com/show_bug.cgi?id=785711
Summary: Review Request: rubygem-map - String/symbol indifferent ordered hash Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: bkabrda@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://bkabrda.fedorapeople.org/pkgs/map/rubygem-map.spec SRPM URL: http://bkabrda.fedorapeople.org/pkgs/map/rubygem-map-5.2.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3745841
Description: The awesome ruby container you've always wanted: a string/symbol indifferent ordered hash that works in all rubies.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785711
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vondruch@redhat.com AssignedTo|nobody@fedoraproject.org |vondruch@redhat.com Flag| |fedora-review?
--- Comment #1 from Vít Ondruch vondruch@redhat.com 2012-01-30 08:51:27 EST --- I take it for a review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785711
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #2 from Vít Ondruch vondruch@redhat.com 2012-01-30 08:51:46 EST --- * Spec file differences - The spec file you provides differs from the spec file in SRPM. The SRPM version looks better IMO. Please make sure which one you are using.
* License - The license file says "same as ruby's". However, the license between Ruby 1.8 and Ruby 1.9, differs. Would you mind to clarify the license with upstream?
Otherwise I have no other concerns => APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785711
--- Comment #3 from Bohuslav Kabrda bkabrda@redhat.com 2012-01-31 02:34:02 EST --- (In reply to comment #2)
- Spec file differences
- The spec file you provides differs from the spec file in SRPM. The SRPM version looks better IMO. Please make sure which one you are using.
Sorry about that, fixed :)
- License
- The license file says "same as ruby's". However, the license between Ruby 1.8 and Ruby 1.9, differs. Would you mind to clarify the license with upstream?
Solved to BSD or Ruby: https://github.com/ahoward/map/issues/10
Otherwise I have no other concerns => APPROVED.
New Package SCM Request ======================= Package Name: rubygem-map Short Description: String/symbol indifferent ordered hash Owners: bkabrda Branches: InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785711
Bohuslav Kabrda bkabrda@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785711
--- Comment #4 from Jon Ciesla limburgher@gmail.com 2012-01-31 09:11:50 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785711
Bohuslav Kabrda bkabrda@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2012-02-01 04:02:55
package-review@lists.fedoraproject.org