[Bug 865241] New: Review Request: liblangtag - library to access tags for identifying languages
https://bugzilla.redhat.com/show_bug.cgi?id=865241
Bug ID: 865241 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: liblangtag - library to access tags for identifying languages Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: dtardon@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://dtardon.fedorapeople.org/liblangtag.spec SRPM URL: http://dtardon.fedorapeople.org/liblangtag-0.3-1.fc17.src.rpm Description: liblangtag is an interface library to access tags for identifying languages.
Features: * several subtag registry database supports: - language - extlang - script - region - variant - extension - grandfathered - redundant * handling of the language tags - parser - matching - canonicalizing Fedora Account System Username: dtardon
This will be a dependency for libreoffice 3.7 .
https://bugzilla.redhat.com/show_bug.cgi?id=865241
David Tardon dtardon@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dtardon@redhat.com
--- Comment #1 from David Tardon dtardon@redhat.com --- Note to reviewer: several source files have a wrong license header (GPLv2+). That is by mistake, not by design, and it has been fixed upstream. Citation from private e-mail from the creator of these files:
"That's true. it may be introduced by using wrong template to insert the copyright notice by my emacs lisp. you should deal with it as LGPLv3+ as well as other files."
https://bugzilla.redhat.com/show_bug.cgi?id=865241
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review+
--- Comment #2 from Parag AN(पराग) panemade@gmail.com --- Review:
+ Koji scratch build for f19 is ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4580604
+ rpmlint on rpms gave liblangtag.src: W: spelling-error %description -l en_US subtag -> sub tag, sub-tag, subtotal liblangtag.src: W: spelling-error %description -l en_US extlang -> extolling liblangtag.src: W: spelling-error %description -l en_US canonicalizing -> cannibalizing, canonizing, canalizing liblangtag.x86_64: W: spelling-error %description -l en_US subtag -> sub tag, sub-tag, subtotal liblangtag.x86_64: W: spelling-error %description -l en_US extlang -> extolling liblangtag.x86_64: W: spelling-error %description -l en_US canonicalizing -> cannibalizing, canonizing, canalizing liblangtag-devel.x86_64: W: no-documentation liblangtag-devel.x86_64: E: incorrect-fsf-address /usr/include/liblangtag/lt-ext-module-data.h 4 packages and 0 specfiles checked; 1 errors, 7 warnings. ==> Good to contact upstream for incorrect-fsf-address if not fixed already in upstream
+ Source verified with upstream as (sha256sum) 47d3bf2824df0df409219d2061c99adac11019151315e5372f6844bba1f4de4d liblangtag-0.3.tar.bz2 47d3bf2824df0df409219d2061c99adac11019151315e5372f6844bba1f4de4d ../SOURCES/liblangtag-0.3.tar.bz2
+ Follows packaging guidelines
Suggestions: 1) Good to preserve timestamps of installed files from source as make install DESTDIR=%{buildroot} INSTALL="install -p"
2) You can add author's reply as a text file in %doc for license clarification
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=865241
David Tardon dtardon@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from David Tardon dtardon@redhat.com --- New Package SCM Request ======================= Package Name: liblangtag Short Description: An interface library to access tags for identifying languages Owners: caolanm dtardon erack Branches: f18 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=865241
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=865241
David Tardon dtardon@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2012-10-11 07:42:46
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla