[Bug 251826] New: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251826
Summary: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: j.w.r.degoede@hhs.nl QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://people.atrpms.net/~hdegoede/maniadrive-music.spec SRPM URL: http://people.atrpms.net/~hdegoede/maniadrive-music-1.0-1.fc8.src.rpm Description: Soundtrack for ManiaDrive. This is not the original ManiaDrive soundtrack as the original soundtrack is licensed under a CC BY-NC-SA license, which is not acceptable to Fedora. This replacement music was carefully chosen to keep the same atmosphere as the original music.
This soundtrack contains music from the following artists / groups:
Black moon http://www.dogmazic.net/static.php?op=musiqueIndex.php&group=Black+moon
Kitoy http://www.dogmazic.net/static.php?op=musiqueIndex.php&group=Kitoy
little http://www.dogmazic.net/static.php?op=musiqueIndex.php&group=little
Syndrome: http://www.dogmazic.net/static.php?op=musiqueIndex.php&group=Syndrome
Zzjmc http://www.dogmazic.net/static.php?op=musiqueIndex.php&group=Zzjmc
---
maniadrive's review is bug 251824
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251826
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-08-14 18:25 EST ------- Here is a new version which adds 2 songs form the original soundtrack whose unclear license situation has been cleared now:
Spec URL: http://people.atrpms.net/~hdegoede/maniadrive-music.spec SRPM URL: http://people.atrpms.net/~hdegoede/maniadrive-music-1.0-2.fc8.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack
https://bugzilla.redhat.com/show_bug.cgi?id=251826
packages@amiga-hardware.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |packages@amiga-hardware.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack
https://bugzilla.redhat.com/show_bug.cgi?id=251826
------- Additional Comments From packages@amiga-hardware.com 2007-08-27 16:48 EST ------- * rpmlint: No Problems * Package named correctly: Yes * Patches named correctly: N/A * Spec file named correctly: Yes * Licence(s) acceptable: Yes * Licence field matches: No (!!! - See below) * Licence file installed: Yes (!!! - See below) * Spec file in American English: Yes * Source matches upstream: N/A * Locales use %find_lang: N/A * Contains %clean: Yes * %install contain rm -rf %{buildroot} or similar: Yes * Specfile legible: Yes * Compiles and builds ok: Yes (mock/i386 devel) * Calls ldconfig in %post/%postun for shlibs: N/A * Owns directories it creates: Yes * Duplicate files: No * Permissions set correctly: Yes * Consistent macro use: Yes * Separate -doc needed (for large docs): N/A * %doc affects runtime: N/A * Headers and static libs in -devel: N/A * .pc files in -devel: N/A * .so in -devel: N/A * -devel requires base: N/A * Contains .la files: N/A * Owns files it didn't create: No * .desktop files included and installed correctly: N/A * Filenames valid UTF8: Yes
1. I think the license field should be:
CC-BY and Free Art and GPL+
I couldn't find anything that refers to a specific GPL version and according to the licensing page, GPL is not a valid short form.
2. According to the guidelines:
"MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc."
So I have doubts that the text of the licenses should be included in the README.
Apart from that I see no problems.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack
https://bugzilla.redhat.com/show_bug.cgi?id=251826
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-08-29 16:59 EST ------- (In reply to comment #2)
- I think the license field should be:
CC-BY and Free Art and GPL+
I couldn't find anything that refers to a specific GPL version and according to the licensing page, GPL is not a valid short form.
Agreed.
- According to the guidelines:
"MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc."
So I have doubts that the text of the licenses should be included in the README.
I see, well for the CC licenses, atleast a link to the webpage with the shortform must be included, as the CC licenses have this clause: "* For any reuse or distribution, you must make clear to others the license terms of this work. The best way to do this is with a link to this web page."
I thought it would be better to just include the shortform, for offline reference.
More in general I think the guideline you quote doesn't apply here, as that is meant for packages where upstream distributes the sources in bundled form, like tar or zip file. In this case there is a direct link on the music site webpage to the .ogg file and on this same page a link to the license, so in a sense the license and music files are bundled too, just like when they are in a zip file, but now one needs to do some more work to get both parts of the bundle.
In the end either way is fine with me though, so if you think its better to rip out the license texts and only provide links to the relevant CC license short forms, then I'll do that. So please let me know which one it will be and then I'll prepare a new release.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack
https://bugzilla.redhat.com/show_bug.cgi?id=251826
packages@amiga-hardware.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+
------- Additional Comments From packages@amiga-hardware.com 2007-08-29 17:18 EST ------- (In reply to comment #3)
I thought it would be better to just include the shortform, for offline reference.
It actually occurred to me after the posting, that inclusion of the license might be a clause so I read it and noticed the recommendation to link to the license but that only served to muddy things further :-)
In the end either way is fine with me though, so if you think its better to rip out the license texts and only provide links to the relevant CC license short forms, then I'll do that. So please let me know which one it will be and then I'll prepare a new release.
Well I think you made a valid point regarding the "bundling" of the license, ie the content and the license are available as direct links and coupled with the fact I didn't have strong convictions either way, only doubts, I think it's fine to leave as-is.
Assuming the license field is fixed before import, the package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack
https://bugzilla.redhat.com/show_bug.cgi?id=251826
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-08-30 03:13 EST ------- New Package CVS Request ======================= Package Name: maniadrive-music Short Description: Replacement soundtrack for the non free ManiaDrive soundtrack Owners: j.w.r.degoede@hhs.nl Branches: devel only! InitialCC: <empty> Cvsextras Commits: yes
Note, this _really_ is devel only, as mania drive needs a new php sub-package which is only in Rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack
https://bugzilla.redhat.com/show_bug.cgi?id=251826
petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs-
------- Additional Comments From petersen@redhat.com 2007-08-30 20:42 EST ------- Sorry need your FAS username for the Owner field.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack
https://bugzilla.redhat.com/show_bug.cgi?id=251826
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-08-31 02:45 EST ------- New Package CVS Request ======================= Package Name: maniadrive-music Short Description: Replacement soundtrack for the non free ManiaDrive soundtrack Owners: jwrdegoede Branches: devel only! InitialCC: <empty> Cvsextras Commits: yes
Note, this _really_ is devel only, as mania drive needs a new php sub-package which is only in Rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack
https://bugzilla.redhat.com/show_bug.cgi?id=251826
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs- |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack
https://bugzilla.redhat.com/show_bug.cgi?id=251826
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-08-31 22:00 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-music - Replacement soundtrack for the non free ManiaDrive soundtrack
https://bugzilla.redhat.com/show_bug.cgi?id=251826
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-09-01 08:44 EST ------- Imported and build, closing.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla