[Bug 2131496] New: Review Request: golang-github-sahilm-fuzzy - Go library that provides fuzzy string matching
https://bugzilla.redhat.com/show_bug.cgi?id=2131496
Bug ID: 2131496 Summary: Review Request: golang-github-sahilm-fuzzy - Go library that provides fuzzy string matching Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mikel@olasagasti.info QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-sahilm-fuzzy.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-sahilm-fuzzy-0.1.0-1.... Description: symbols in the style of Sublime Text, VSCode, IntelliJ IDEA et al. Fedora Account System Username: mikelo2
https://bugzilla.redhat.com/show_bug.cgi?id=2131496
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Blocks| |2131497
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2131497 [Bug 2131497] Review Request: golang-github-charmbracelet-bubbles - TUI components for Bubble Tea
https://bugzilla.redhat.com/show_bug.cgi?id=2131496
Anthony Rabbito hello@anthonyrabbito.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |hello@anthonyrabbito.com CC| |hello@anthonyrabbito.com
https://bugzilla.redhat.com/show_bug.cgi?id=2131496
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2131496
Anthony Rabbito hello@anthonyrabbito.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mikel@olasagasti. | |info)
--- Comment #1 from Anthony Rabbito hello@anthonyrabbito.com --- Hi Mikel
I've noticed:
BuildRequires: golang(github.com/kylelemons/godebug/pretty)
and
%generate_buildrequires %go_generate_buildrequires
Is godebug/pretty an added dependency on top of the generated deps?
https://bugzilla.redhat.com/show_bug.cgi?id=2131496
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mikel@olasagasti. | |info) |
--- Comment #2 from Mikel Olasagasti Uranga mikel@olasagasti.info --- %go_generate_buildrequires is not pulling " golang(github.com/kylelemons/godebug/pretty)" dep, so I added manually and left %go_generate_buildrequires as it doesn't break, but I removed it now.
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-sahilm-fuzzy.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-sahilm-fuzzy-0.1.0-1....
https://bugzilla.redhat.com/show_bug.cgi?id=2131496
Anthony Rabbito hello@anthonyrabbito.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Anthony Rabbito hello@anthonyrabbito.com --- go2rpm package:
- [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
https://bugzilla.redhat.com/show_bug.cgi?id=2131496
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-sahilm-fuzzy
https://bugzilla.redhat.com/show_bug.cgi?id=2131496
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-bda99b2f6d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bda99b2f6d
https://bugzilla.redhat.com/show_bug.cgi?id=2131496
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2022-10-31 14:34:24
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-bda99b2f6d has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com