Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
Bug ID: 903829 Summary: Review Request: perl-Time-Interval - Convert seconds to human readable form Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Reporter: long@rule.lv
Spec URL: http://unibackup.rule.lv/FedoraRPM/perl-Time-Interval.spec SRPM URL: http://unibackup.rule.lv/FedoraRPM/perl-Time-Interval-1.22-2.fc16.src.rpm Description: This is a rather simple perl module for dealing with time intervals. Among other things, this module can tell you the number of hours, minutes, and seconds elapsed between two dates. Fedora Account System Username: normunds
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
Normunds long@rule.lv changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
--- Comment #1 from Normunds long@rule.lv --- Bug 903829, Bug 903826, Bug 903824 are my first Fedora packages, yet more to come. I checked them with both Mock and Koji for all Fedora releases (16, 17, 18, 19, rawhide).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
Normunds long@rule.lv changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |perl-Time-Interval
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #2 from Normunds long@rule.lv --- All packages mentioned below were tested with rpmlint, mock (for i386 arch) and koji (16, 17, 18, 19, rawhide). These are my first packages for Fedora, so if you find something to improve in one of them, don't bother, I'll check other packages for reported problems.
Need sponsor.
bug 903824 perl-Convert-Age.spec bug 903826 perl-Net-Domain-TLD.spec bug 903829 perl-Time-Interval.spec bug 904328 perl-Config-ApacheFormat.spec bug 904329 perl-Data-Validate-Domain.spec bug 904330 perl-Data-Validate-IP.spec bug 904331 perl-Shell.spec
Thanks.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
--- Comment #3 from Petr Šabata psabata@redhat.com --- Taking the review.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #4 from Petr Šabata psabata@redhat.com --- Issues:
Missing build-time dependencies: perl(Exporter) perl(Test)
Lines 30 and 31 are useless. None of the files has executable bits set. Line 32 is wrong. Modules aren't scripts and aren't supposed to contain shebangs. Line 43 may be removed. Done by rpmbuild.
Preferrably substitute command macros with simple calls.
The license is not mentioned anywhere in the upstream tarball, not even on the CPAN module webpage. Please, ask upstream for clarification.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #5 from Normunds long@rule.lv --- Spec file and src package updated.
* Fixed dependencies. * Replaced macros with simple commands. * Removed useless lines * Sent query to Time-Interval maintainer. Interestingly, someone has asked this same question to him few years ago, although he looks active other Perl package maintainer, Time-Interval license still is not updated :)
New package overwritten in original location.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #6 from Petr Šabata psabata@redhat.com --- Removing FE-NEEDSPONSOR.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #7 from Petr Šabata psabata@redhat.com --- Seems okay now (just the perl macro on the MODULE_COMPAT line...).
(In reply to comment #5)
- Sent query to Time-Interval maintainer. Interestingly, someone has asked
this same question to him few years ago, although he looks active other Perl package maintainer, Time-Interval license still is not updated :)
I see https://rt.cpan.org/Public/Bug/Display.html?id=43024
I can't approve the review until the licensing issue is cleared up.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #8 from Normunds long@rule.lv --- Package updated, license is now included in upstream, other requested changes done.
Spec URL: http://unibackup.rule.lv/FedoraRPM/perl-Time-Interval.spec SRPM URL: http://unibackup.rule.lv/FedoraRPM/perl-Time-Interval-1.231-1.fc16.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #9 from Petr Šabata psabata@redhat.com --- There's been a new release, 1.232, which removes the ._* files from the distribution.
Two more things: 1. Include the LICENSE file in your %doc 2. Your changelog entry is suddenly without a contact e-mail
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #10 from Normunds long@rule.lv --- Question: is contact e-mail mandatory? I decided that including e-mail in publicly available spec file would be perfect catch for spam bots.
Sorry for inconsistencies.
Thanks.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #11 from Petr Šabata psabata@redhat.com --- (In reply to comment #10)
Question: is contact e-mail mandatory? I decided that including e-mail in publicly available spec file would be perfect catch for spam bots.
Yes, it is. But don't worry too much, your e-mail is available in the publicly available git commits anyway :)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #12 from Normunds long@rule.lv --- Big thanks for your support with getting response from upstream.
Updated to version 1.232, added obfuscated e-mail, added LICENSE to doc.
Spec URL: http://unibackup.rule.lv/FedoraRPM/perl-Time-Interval.spec SRPM URL: http://unibackup.rule.lv/FedoraRPM/perl-Time-Interval-1.232-1.fc16.src.rpm
Thanks.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #13 from Petr Šabata psabata@redhat.com --- Again, if you must use this format, enclose it with qw(< >) at least.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #14 from Normunds fedorapkg@rule.lv --- Spec file/srpm updated, added <> to e-mail.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #15 from Normunds fedorapkg@rule.lv --- Another reviewer suggested to use simpler e-mail obfuscation, so, to be consistent, I changed it for all packages.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #16 from Petr Šabata psabata@redhat.com --- Alright, approving.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
Normunds fedorapkg@rule.lv changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #17 from Normunds fedorapkg@rule.lv --- Thanks for your help and support :)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #18 from Normunds fedorapkg@rule.lv --- New Package SCM Request ======================= Package Name: perl-Time-Interval Short Description: Perl module that converts time intervals of days, hours, minutes, and seconds Owners: normunds psabata Branches: f16 f17 f18 InitialCC: perl-sig
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #19 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- perl-Time-Interval-1.232-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Time-Interval-1.232-1.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- perl-Time-Interval-1.232-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Time-Interval-1.232-1.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- perl-Time-Interval-1.232-1.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- perl-Time-Interval-1.232-1.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=903829
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Fixed In Version| |perl-Time-Interval-1.232-1. | |fc18 Resolution|--- |CURRENTRELEASE Last Closed| |2014-04-03 12:17:37
package-review@lists.fedoraproject.org