[Bug 1473663] New: Review Request: perl-Shell-Guess - Make an educated guess about the shell in use

https://bugzilla.redhat.com/show_bug.cgi?id=1473663

Bug ID: 1473663
           Summary: Review Request: perl-Shell-Guess - Make an educated
                    guess about the shell in use
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://ppisar.fedorapeople.org/perl-Shell-Guess/perl-Shell-Guess.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Shell-Guess/perl-Shell-Guess-0.06-1.fc2...
Description:
The Shell::Guess Perl module makes a reasonably aggressive attempt to
determine the shell being employed by the user, either the shell that executed
the Perl script directly, or the users' login shell.

Fedora Account System Username: ppisar

[Bug 1473663] Review Request: perl-Shell-Guess - Make an educated guess about the shell in use

https://bugzilla.redhat.com/show_bug.cgi?id=1473663

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1473656

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1473656
[Bug 1473656] Review Request: perl-Unix-Process - Perl extension to get PID
information from ps command

[Bug 1473663] Review Request: perl-Shell-Guess - Make an educated guess about the shell in use

https://bugzilla.redhat.com/show_bug.cgi?id=1473663

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1473678

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1473678
[Bug 1473678] Review Request: perl-Shell-Config-Generate - Portably
generate configuration for any shell

[Bug 1473663] Review Request: perl-Shell-Guess - Make an educated guess about the shell in use

https://bugzilla.redhat.com/show_bug.cgi?id=1473663

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1473705

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1473705
[Bug 1473705] Review Request: perl-Alien-Base-ModuleBuild - Perl framework
for building Alien:: modules and their libraries

[Bug 1473663] Review Request: perl-Shell-Guess - Make an educated guess about the shell in use

https://bugzilla.redhat.com/show_bug.cgi?id=1473663
Bug 1473663 depends on bug 1473656, which changed state.

Bug 1473656 Summary: Review Request: perl-Unix-Process - Perl extension to get PID information from ps command
https://bugzilla.redhat.com/show_bug.cgi?id=1473656

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE

[Bug 1473663] Review Request: perl-Shell-Guess - Make an educated guess about the shell in use

https://bugzilla.redhat.com/show_bug.cgi?id=1473663

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1473663] Review Request: perl-Shell-Guess - Make an educated guess about the shell in use

https://bugzilla.redhat.com/show_bug.cgi?id=1473663

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Shell-Guess-0.06-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(File::Spec)
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(strict)
      1 perl(Unix::Process)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Shell-Guess-0.06-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Shell::Guess) = 0.06
      1 perl-Shell-Guess = 0.06-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Shell-Guess*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

[Bug 1473663] Review Request: perl-Shell-Guess - Make an educated guess about the shell in use

https://bugzilla.redhat.com/show_bug.cgi?id=1473663

--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Shell-Guess

[Bug 1473663] Review Request: perl-Shell-Guess - Make an educated guess about the shell in use

https://bugzilla.redhat.com/show_bug.cgi?id=1473663

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |perl-Shell-Guess-0.06-1.fc2
                   |                            |7

--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

[Bug 1473663] Review Request: perl-Shell-Guess - Make an educated guess about the shell in use

https://bugzilla.redhat.com/show_bug.cgi?id=1473663

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2017-08-01 08:43:27