https://bugzilla.redhat.com/show_bug.cgi?id=2255886
Bug ID: 2255886 Summary: Review Request: lxqt-menu-data Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sztsian@gmail.com QA Contact: extras-qa@fedoraproject.org CC: farchord@gmail.com, ngompa13@gmail.com, package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
SPEC URL: https://download.copr.fedorainfracloud.org/results/zsun/lxqt/fedora-rawhide-... SRPM URL: https://download.copr.fedorainfracloud.org/results/zsun/lxqt/fedora-rawhide-...
FAS: zsun Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110861675
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2248017, 2248018, 2248184, | |2248191, 2248192, 2248193, | |2248194, 2248195, 2248196, | |2248197, 2248198, 2248199, | |2248200, 2248201, 2248202, | |2248203, 2248212, 2248433
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2248017 [Bug 2248017] qterminal-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248018 [Bug 2248018] qtermwidget-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248184 [Bug 2248184] liblxqt-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248191 [Bug 2248191] lxqt-globalkeys-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248192 [Bug 2248192] lximage-qt-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248193 [Bug 2248193] lxqt-about-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248194 [Bug 2248194] lxqt-notificationd-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248195 [Bug 2248195] lxqt-admin-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248196 [Bug 2248196] lxqt-session-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248197 [Bug 2248197] lxqt-policykit-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248198 [Bug 2248198] lxqt-powermanagement-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248199 [Bug 2248199] lxqt-panel-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248200 [Bug 2248200] lxqt-openssh-askpass-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248201 [Bug 2248201] lxqt-config-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248202 [Bug 2248202] lxqt-sudo-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248203 [Bug 2248203] lxqt-runner-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248212 [Bug 2248212] lxqt-qtplugin-1.4.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2248433 [Bug 2248433] pcmanfm-qt-1.4.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Status|NEW |ASSIGNED Flags| |fedora-review?
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
--- Comment #2 from Neal Gompa ngompa13@gmail.com ---
%define __cmake_in_source_build 1
I think you can drop this and simplify this spec since we do out-of-source builds properly and automatically now.
# No binary at all, so disable debuginfo package %global debug_package %{nil}
This can be dropped since you have "BuildArch: noarch" already.
mkdir build cd build %cmake3 -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO ..
This should be replaced with "%cmake -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO".
cd build make install/fast DESTDIR=%{buildroot}
This should be replaced with "%cmake_install"
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
--- Comment #3 from Zamir SUN sztsian@gmail.com --- Thanks for the review. SPEC URL: https://download.copr.fedorainfracloud.org/results/zsun/lxqt/fedora-rawhide-... SRPM URL: https://download.copr.fedorainfracloud.org/results/zsun/lxqt/fedora-rawhide-...
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://lxqt-project.org/
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6815985 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2005968 --> https://bugzilla.redhat.com/attachment.cgi?id=2005968&action=edit The .spec file difference from Copr build 6815985 to 6815986
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6815986 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
--- Comment #7 from Neal Gompa ngompa13@gmail.com ---
%build mkdir build cd build %cmake -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO .. %cmake_build
%install cd build %cmake_install
This should be simplified to:
%build %cmake -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO %cmake_build
%install %cmake_install
If you need it to do out of source builds in RHEL < 9, then add the following to the top of your spec file:
%undefine __cmake_in_source_build
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
--- Comment #8 from Zamir SUN sztsian@gmail.com --- (In reply to Neal Gompa from comment #7)
This should be simplified to:
%build %cmake -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO %cmake_build
%install %cmake_install
Thanks. Historically some of the LXQt packages cannot be built in source root. But looks like this one works just fine.
If you need it to do out of source builds in RHEL < 9, then add the following to the top of your spec file:
%undefine __cmake_in_source_build
I'll do it only when I plan to update in EPEL.
SPEC URL: https://download.copr.fedorainfracloud.org/results/zsun/lxqt/fedora-rawhide-... SRPM URL: https://download.copr.fedorainfracloud.org/results/zsun/lxqt/fedora-rawhide-...
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
--- Comment #9 from Neal Gompa ngompa13@gmail.com --- (In reply to Zamir SUN from comment #8)
(In reply to Neal Gompa from comment #7)
This should be simplified to:
%build %cmake -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO %cmake_build
%install %cmake_install
Thanks. Historically some of the LXQt packages cannot be built in source root. But looks like this one works just fine.
Right, KDE is the same way. We have a derivative %cmake macro (called %cmake_kf5 or now %cmake_kf6) that enforces this. If you have a similar %cmake_lxqt macro, you can enforce it there. But it's also not needed if you do not care about anything older than RHEL 9, since the regular %cmake macro sets up out of source builds by default since Fedora 33 / RHEL 9.
Cf. https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #10 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |lxqt-menu-data |lxqt-menu-data -Menu files | |for LXQt Panel, | |Configuration Center and | |PCManFM-Qt/libfm-qt
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
--- Comment #11 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/lxqt-menu-data
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2024-01-08 12:28:35
https://bugzilla.redhat.com/show_bug.cgi?id=2255886
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |projects.rg@smart.ms Fixed In Version| |lxqt-menu-data-1.4.1-1.fc40
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com