[Bug 698264] New: Review Request: perl-TryCatch - First class try catch semantics for Perl, without source filters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-TryCatch - First class try catch semantics for Perl, without source filters
https://bugzilla.redhat.com/show_bug.cgi?id=698264
Summary: Review Request: perl-TryCatch - First class try catch semantics for Perl, without source filters Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mmaslano@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
SPEC: http://mmaslano.fedorapeople.org/review/perl-TryCatch.spec SRPM: http://mmaslano.fedorapeople.org/review/perl-TryCatch-1.003000-1.fc14.src.rp... Description: This module aims to provide a nicer syntax and method to catch errors in Perl, similar to what is found in other languages (such as Java, Python or C++). The standard method of using eval {}; if ($@) {} is often prone to subtle bugs, primarily that its far too easy to stomp on the error in error handlers. And also eval/if isn't the nicest idiom.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698264
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |698251
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698264
Bug 698264 depends on bug 698251, which changed state.
Bug 698251 Summary: Review Request: perl-B-Hooks-OP-PPAddr - Hook into opcode execution https://bugzilla.redhat.com/show_bug.cgi?id=698251
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698264
Mario Blättermann mariobl@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mariobl@freenet.de
--- Comment #1 from Mario Blättermann mariobl@freenet.de 2011-04-27 07:06:53 EDT --- $ rpmlint -v * perl-TryCatch.src: I: checking perl-TryCatch.src: W: spelling-error %description -l en_US eval -> veal, vela, val perl-TryCatch.src: I: checking-url http://search.cpan.org/dist/TryCatch/ (timeout 10 seconds) perl-TryCatch.src: I: checking-url http://www.cpan.org/authors/id/A/AS/ASH/TryCatch-1.003000.tar.gz (timeout 10 seconds) perl-TryCatch.spec: I: checking-url http://www.cpan.org/authors/id/A/AS/ASH/TryCatch-1.003000.tar.gz (timeout 10 seconds) 1 packages and 1 specfiles checked; 0 errors, 1 warnings.
Just a small "spelling error" once again, to be ignored.
Koji build fails: http://koji.fedoraproject.org/koji/taskinfo?taskID=3029459
From the Mock output:
Error: No Package found for perl(B::Hooks::OP::PPAddr) >= 0.03
Moreover, it's a "noarch" package in my mind.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698264
--- Comment #2 from Marcela Mašláňová mmaslano@redhat.com 2011-04-27 07:20:19 EDT --- (In reply to comment #1)
$ rpmlint -v * perl-TryCatch.src: I: checking perl-TryCatch.src: W: spelling-error %description -l en_US eval -> veal, vela, val perl-TryCatch.src: I: checking-url http://search.cpan.org/dist/TryCatch/ (timeout 10 seconds) perl-TryCatch.src: I: checking-url http://www.cpan.org/authors/id/A/AS/ASH/TryCatch-1.003000.tar.gz (timeout 10 seconds) perl-TryCatch.spec: I: checking-url http://www.cpan.org/authors/id/A/AS/ASH/TryCatch-1.003000.tar.gz (timeout 10 seconds) 1 packages and 1 specfiles checked; 0 errors, 1 warnings.
Just a small "spelling error" once again, to be ignored.
It's not error, it's keyword 'eval'.
Koji build fails: http://koji.fedoraproject.org/koji/taskinfo?taskID=3029459
Rawhide mirrors are lazy. I built requirement week ago.
From the Mock output: Error: No Package found for perl(B::Hooks::OP::PPAddr) >= 0.03
Moreover, it's a "noarch" package in my mind.
It's arch dependent. Module contains TryCatch.xs, which is usually good sign for being arch.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698264
--- Comment #3 from Mario Blättermann mariobl@freenet.de 2011-04-27 16:57:20 EDT --- (In reply to comment #2)
Rawhide mirrors are lazy. I built requirement week ago.
What's the required package, actually? Is it already available from the F15 repos? Otherwise, I should feed Koji again with the package *and* the requirement.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698264
--- Comment #4 from Marcela Mašláňová mmaslano@redhat.com 2011-04-28 03:02:23 EDT --- (In reply to comment #3)
(In reply to comment #2)
Rawhide mirrors are lazy. I built requirement week ago.
What's the required package, actually? Is it already available from the F15 repos? Otherwise, I should feed Koji again with the package *and* the requirement.
It's perl-B-Hooks-OP-PPAddr, which has build here: http://koji.fedoraproject.org/koji/buildinfo?buildID=240288
I don't plan push into F-15.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698264
Mario Blättermann mariobl@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mariobl@freenet.de Flag| |fedora-review+
--- Comment #5 from Mario Blättermann mariobl@freenet.de 2011-05-07 13:39:22 EDT --- Succesful Koji build for f16: http://koji.fedoraproject.org/koji/taskinfo?taskID=3056870
$ rpmlint -v * perl-TryCatch.src: I: checking perl-TryCatch.src: W: spelling-error %description -l en_US eval -> veal, vela, val perl-TryCatch.src: I: checking-url http://search.cpan.org/dist/TryCatch/ (timeout 10 seconds) perl-TryCatch.src: I: checking-url http://www.cpan.org/authors/id/A/AS/ASH/TryCatch-1.003000.tar.gz (timeout 10 seconds) perl-TryCatch.i686: I: checking perl-TryCatch.i686: W: spelling-error %description -l en_US eval -> veal, vela, val perl-TryCatch.i686: I: checking-url http://search.cpan.org/dist/TryCatch/ (timeout 10 seconds) perl-TryCatch-debuginfo.i686: I: checking perl-TryCatch-debuginfo.i686: I: checking-url http://search.cpan.org/dist/TryCatch/ (timeout 10 seconds) perl-TryCatch.spec: I: checking-url http://www.cpan.org/authors/id/A/AS/ASH/TryCatch-1.003000.tar.gz (timeout 10 seconds) 3 packages and 1 specfiles checked; 0 errors, 2 warnings.
→ OK.
--------------------------------- key:
[+] OK [.] OK, not applicable [X] needs work ---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPL+ or Artistic [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 590620cf5815781cc0d344bf5483956a TryCatch-1.003000.tar.gz 590620cf5815781cc0d344bf5483956a TryCatch-1.003000.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. Don't know how to test it on my system. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts.
----------------
PACKAGE APPROVED
----------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698264
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |perl-TryCatch - First class |perl-TryCatch - First class |try catch semantics for |try catch semantics for |Perl, without source |Perl |filters | Flag| |fedora-cvs?
--- Comment #6 from Marcela Mašláňová mmaslano@redhat.com 2011-05-09 04:09:55 EDT --- New Package SCM Request ======================= Package Name: perl-TryCatch Short Description: First class try catch semantics for Perl Owners: mmaslano psabata ppisar Branches: f15 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698264
--- Comment #7 from Jason Tibbitts tibbs@math.uh.edu 2011-05-10 11:31:03 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698264
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2011-08-09 07:34:51
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla