https://bugzilla.redhat.com/show_bug.cgi?id=1096052
Bug ID: 1096052 Summary: Review Request: - nodejs-i18n - lightweight translation module Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: apatil@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://anishpatil.fedorapeople.org/nodejs-i18n.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-i18n-0.4.1-1.fc20.src.rpm
Description: lightweight translation module with dynamic json storage
Fedora Account System Username:anishpatil
https://bugzilla.redhat.com/show_bug.cgi?id=1096052
anish apatil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1096072
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 [Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096052 Bug 1096052 depends on bug 1096072, which changed state.
Bug 1096072 Summary: Review Request: nodejs-sprintf - JavaScript sprintf implementation https://bugzilla.redhat.com/show_bug.cgi?id=1096072
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1096052
Eduardo Mayorga e@mayorgalinux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |e@mayorgalinux.com Assignee|nobody@fedoraproject.org |e@mayorgalinux.com Flags| |fedora-review?
--- Comment #1 from Eduardo Mayorga e@mayorgalinux.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues ====== - Latest upstream release is now 0.5
- Fix rpmlint hardcoded-library-path error. Replace %{_prefix}/lib/node_modules by %{nodejs_sitelib}.
- Remove node_modules directory in buildroot in %prep and symlink dependencies calling %nodejs_symlink_deps in %install. See: https://fedoraproject.org/wiki/Packaging:Node.js#Symlinking_Dependencies
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 28 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-i18n-0.4.1-1.fc22.noarch.rpm nodejs-i18n-0.4.1-1.fc22.src.rpm nodejs-i18n.noarch: W: spelling-error %description -l en_US json -> son, j son nodejs-i18n.noarch: W: only-non-binary-in-usr-lib nodejs-i18n.src: W: spelling-error %description -l en_US json -> son, j son nodejs-i18n.src:37: E: hardcoded-library-path in %{_prefix}/lib/node_modules 2 packages and 0 specfiles checked; 1 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-i18n nodejs-i18n.noarch: W: spelling-error %description -l en_US json -> son, j son nodejs-i18n.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:'
Requires -------- nodejs-i18n (rpmlib, GLIBC filtered): nodejs(engine) npm(debug) npm(sprintf)
Provides -------- nodejs-i18n: nodejs-i18n npm(i18n)
Source checksums ---------------- http://registry.npmjs.org/i18n/-/i18n-0.4.1.tgz : CHECKSUM(SHA256) this package : 1dd43aaeb5ae6d198324341319ce28a27df57ba7c6a660bc04e3767fc2cd0ba0 CHECKSUM(SHA256) upstream package : 1dd43aaeb5ae6d198324341319ce28a27df57ba7c6a660bc04e3767fc2cd0ba0
https://bugzilla.redhat.com/show_bug.cgi?id=1096052
Eduardo Mayorga e@mayorgalinux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: - |Review Request: nodejs-i18n |nodejs-i18n - lightweight |- Lightweight translation |translation module |module
https://bugzilla.redhat.com/show_bug.cgi?id=1096052
--- Comment #2 from anish apatil@redhat.com --- Hi Eduardo!
Thank you for review, I think this package depends on mustache, which is not in Fedora repository. So I have created a new package review request https://bugzilla.redhat.com/show_bug.cgi?id=1138130
Thanks, Anish P.
https://bugzilla.redhat.com/show_bug.cgi?id=1096052
anish apatil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1161035
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1161035 [Bug 1161035] Review Request: nodejs-i18n-node-angular - i18n-node in an AngularJS application
https://bugzilla.redhat.com/show_bug.cgi?id=1096052
Zuzana Svetlikova zsvetlik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zsvetlik@redhat.com
--- Comment #4 from Zuzana Svetlikova zsvetlik@redhat.com --- Some comments:
- not the latest version - missing BuildRequires for dependencies and devDependencies - missing nodejs_symlink_deps macro in %install and nodejs_symlink_deps --check in %check - the tests are executed by 'make test' - LICENSE should be in %license
https://bugzilla.redhat.com/show_bug.cgi?id=1096052
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr1212@gmail.com
--- Comment #5 from Piotr Popieluch piotr1212@gmail.com --- Anish, any progress on this?
https://bugzilla.redhat.com/show_bug.cgi?id=1096052
noriko noriko.mizumoto@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1546484
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1546484 [Bug 1546484] F28 Localization Tracking
https://bugzilla.redhat.com/show_bug.cgi?id=1096052
Piotr Drąg piotrdrag@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1546484 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1546484 [Bug 1546484] F28 Localization Tracking
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla