https://bugzilla.redhat.com/show_bug.cgi?id=1128366
Bug ID: 1128366 Summary: Review Request: lis - A library for solving linear equations and eigenvalue problems Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: dev@der-flo.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://flo.fedorapeople.org/lis.spec SRPM URL: https://flo.fedorapeople.org/lis-1.4.53-1.fc20.src.rpm Description: Lis, a Library of Iterative Solvers for linear systems, is a scalable parallel library for solving systems of linear equations and standard eigenvalue problems with real sparse matrices using iterative methods.
Fedora Account System Username: flo
koji-Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7267825
Note: I adopted this orphaned package
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i@cicku.me
--- Comment #1 from Christopher Meng i@cicku.me --- As you've taken the package, doing some cleanup is needed.
Please cleanup those obsoleted stuffs in the SPEC.
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
--- Comment #2 from Florian "der-flo" Lehner dev@der-flo.net --- Spec URL: https://flo.fedorapeople.org/lis.spec SRPM URL: https://flo.fedorapeople.org/lis-1.4.53-2.fc20.src.rpm koji-Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7269578
* Sun Aug 10 2014 Florian Lehner dev@der-flo.net - 1.4.53-2 - Remove defattr at the beginning of the files-section - Use default buildroot instead of making its own - Remove unnecessary clean-section - Use pushd and popd instead of cd
If I missed something, please point me at it.
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |i@cicku.me
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
--- Comment #3 from Christopher Meng i@cicku.me --- 1. 1.4.55(japanese version page) is out.
2. Can't "make check" work?
3. I'm not sure if --enable-longlong is needed on 64 bits arch, you'd better drop an email to the upstream.
4. WRONG:
%package doc Summary: Developer documentation for lis Group: Documentation Requires: %{name}%{?_isa} = %{version}-%{release}
%description doc Lis, a Library of Iterative Solvers for linear systems, is a scalable parallel library for solving systems of linear equations and standard eigenvalue problems with real sparse matrices using iterative methods.
This package contains the developer documentation for lis.
i. No BuildArch: noarch
ii. Requires: %{name}%{?_isa} = %{version}-%{release}
When you fix i, drop the %_isa macro.
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
--- Comment #4 from Florian "der-flo" Lehner dev@der-flo.net --- (In reply to Christopher Meng from comment #3)
- Can't "make check" work?
Unfortunately, it is stated: *** No rule to make target 'check'
- I'm not sure if --enable-longlong is needed on 64 bits arch, you'd better
drop an email to the upstream.
It's necessary for cross compiling
Spec URL: https://flo.fedorapeople.org/lis.spec SRPM URL: https://flo.fedorapeople.org/lis-1.4.55-1.fc20.src.rpm koji-Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7274631
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #5 from Christopher Meng i@cicku.me --- 1. Drop all "Group" tags in the SPEC.
2. lis.i686: W: spurious-executable-perm /usr/share/doc/lis/AUTHORS lis.i686: W: spurious-executable-perm /usr/share/doc/lis/COPYING
Others are fine.
Fix 2 above and build in koji then push to f20+ IMO is the best scheme.
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
--- Comment #6 from Florian "der-flo" Lehner dev@der-flo.net --- Here is the update:
Spec URL: https://flo.fedorapeople.org/lis.spec SRPM URL: https://flo.fedorapeople.org/lis-1.4.56-1.fc20.src.rpm koji-Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7283428
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
--- Comment #7 from Christopher Meng i@cicku.me --- Fine now.
Please build and push.
I won't set the review flag as this package is already in the repo and not deprecated.
When you push updates to stable Fedora branches, mention this bug in Bugs section.
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- lis-1.4.56-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lis-1.4.56-1.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- Package lis-1.4.56-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lis-1.4.56-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-9451/lis-1.4.56-1.fc20 then log in and leave karma (feedback).
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- lis-1.4.57-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lis-1.4.57-1.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1128366
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |lis-1.4.57-1.fc20 Resolution|--- |ERRATA Last Closed| |2014-08-28 11:28:57
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- lis-1.4.57-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org