Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768007
Thomas Spura <tomspur(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |tomspur(a)fedoraproject.org
AssignedTo|nobody(a)fedoraproject.org |tomspur(a)fedoraproject.org
Flag| |fedora-review+
--- Comment #1 from Thomas Spura <tomspur(a)fedoraproject.org> 2012-01-18 16:14:53 EST
---
Review:
- $ rpmlint /home/tom/rpmbuild/SRPMS/python-flatland-0.0.2-1.fc16.src.rpm
/home/tom/rpmbuild/RPMS/noarch/python-flatland-0.0.2-1.fc16.noarch.rpm
python-flatland.src: W: spelling-error %description -l en_US namespace -> name
space, name-space, names pace
python-flatland.src: W: invalid-url Source0: jek-flatland-0938e70bb76d.tar.bz2
python-flatland.noarch: W: spelling-error %description -l en_US namespace ->
name space, name-space, names pace
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
all ignorable
- koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3712729
- source match upstream:
2a0185ad21e9f45a5be67fda5fb43b81 jek-flatland-0938e70bb76d.tar.bz2
- license ok
NEEDSWORK:
- please be more specific in %files:
%{python_sitelib}/flatland-*py?.?.egg-info
%{python_sitelib}/flatland/
- Query upstream to include license headers
- Please add a check section:
%check
nosetests -v
Then you see, there is at least one missing dep blinker (both BR and R).
========================================================================
Please implement the NEEDSWORK issues, but as they are all "should":
========================================================================
APPROVED
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.