[Bug 1946033] New: Review Request:python-protego - Pure-Python robots.txt parser with support for modern conventions
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
Bug ID: 1946033 Summary: Review Request:python-protego - Pure-Python robots.txt parser with support for modern conventions Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: echevemaster@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://echevemaster.fedorapeople.org/python-protego/python-protego.spec SRPM URL: https://echevemaster.fedorapeople.org/python-protego/python-protego-0.1.16-1... Description: Pure-Python robots.txt parser with support for modern conventions
Fedora Account System Username: echevemaster
This package is needed for the new version of python-scrapy
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1933617
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1933617 [Bug 1933617] F35FailsToInstall: python3-scrapy
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Use pypi_source:
Source0: %{pypi_source}
- This is not needed anymore:
%{?python_provide:%python_provide python3-%{pkg_name}}
Please refer to: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_pr...
- I think this should be handled automatically by the dependency generator:
Requires: python3-six
See: rpm -q --requires -p python3-protego-0.1.16-1.fc35.noarch.rpm | sort -f | uniq -c 1 python(abi) = 3.9 1 python3.9dist(six)
- Split the description to stay below 80 characters:
%description Protego is a pure-Python `robots.txt` parser with support for modern conventions.
- Add a period at the end of the other description:
%description Protego is a pure-Python `robots.txt` parser with support for modern conventions.
You could use a single %global common_description for both though:
%global common_description %{expand: Protego is a pure-Python `robots.txt` parser with support for modern conventions.}
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 3-clause "New" or "Revised" License", "Unknown or generated", "*No copyright* [generated file]". 4158 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-protego/review-python- protego/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-protego-0.1.16-1.fc35.noarch.rpm python-protego-0.1.16-1.fc35.src.rpm python3-protego.noarch: W: spelling-error Summary(en_US) txt -> text, ext, tit python3-protego.noarch: W: spelling-error %description -l en_US txt -> text, ext, tit python-protego.src: W: spelling-error Summary(en_US) txt -> text, ext, tit python-protego.src: W: spelling-error %description -l en_US txt -> text, ext, tit python-protego.src: E: description-line-too-long C Protego is a pure-Python `robots.txt` parser with support for modern conventions. 2 packages and 0 specfiles checked; 1 errors, 4 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
--- Comment #2 from Eduardo Echeverria echevemaster@gmail.com --- Hi Robert, I made changes on the spec based on your suggestions, can you check it out again?
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
--- Comment #4 from Eduardo Echeverria echevemaster@gmail.com --- Thanks Robert https://pagure.io/releng/fedora-scm-requests/issue/33359
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
--- Comment #5 from Tomas Hrcka thrcka@redhat.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-protego
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-41513f962c has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-41513f962c
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-4c100f26e2 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-4c100f26e2
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-4c100f26e2 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-4c100f26e2 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-4c100f26e2
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-41513f962c has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-41513f962c *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-41513f962c
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2021-06-01 01:02:48
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-41513f962c has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1946033
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-4c100f26e2 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com