https://bugzilla.redhat.com/show_bug.cgi?id=1421066
Bug ID: 1421066 Summary: Review Request: deepin-wm-switcher - Window manager switcher for Deepin Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: sensor.wen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/FZUG/repo/blob/master/rpms/deepin_project/deepin-wm-switc...
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17617894
Description: Window manager switcher for Deepin
Fedora Account System Username: mosquito
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1465889 | |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
Felix Yan felixonmars@archlinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1421058
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1421058 [Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
--- Comment #1 from sensor.wen@gmail.com --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8... SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...
Release 1.1.2
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- It would be better to include some additional info in %description about what this package actually *does*. The text from https://github.com/linuxdeepin/deepin-wm-switcher#deepin-wm-switcher would be OK, I think.
Looks OK, but #1421058 needs to be done first to meaningfully review this.
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
--- Comment #3 from sensor.wen@gmail.com --- #1421058 is done. let's go review it. @Zbigniew Jędrzejewski-Szmek
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
--- Comment #4 from sensor.wen@gmail.com --- https://koji.fedoraproject.org/koji/taskinfo?taskID=22368478
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- + package name is OK + license is acceptable for Fedora (GPLv3) + license is specified correctly + package builds in mock + BuildRequires / Requires / Provides look OK + latest version + fedora-review finds no issues + rpmlint output is OK (only some grumbling about missing man pages and documentation) + no scriptlets are necessary
Package is APPROVED. I didn't test it, but the packaging is OK.
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-wm-switcher
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |deepin-wm-switcher
https://bugzilla.redhat.com/show_bug.cgi?id=1421066 Bug 1421066 depends on bug 1421058, which changed state.
Bug 1421058 Summary: Review Request: deepin-metacity - 2D window manager for Deepin https://bugzilla.redhat.com/show_bug.cgi?id=1421058
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-07-22 09:32:47
--- Comment #7 from Zamir SUN sztsian@gmail.com --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
https://bugzilla.redhat.com/show_bug.cgi?id=1421066
--- Comment #8 from Zamir SUN sztsian@gmail.com --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
package-review@lists.fedoraproject.org