[Bug 1473678] New: Review Request: perl-Shell-Config-Generate - Portably generate configuration for any shell

https://bugzilla.redhat.com/show_bug.cgi?id=1473678

Bug ID: 1473678
           Summary: Review Request: perl-Shell-Config-Generate - Portably
                    generate configuration for any shell
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://ppisar.fedorapeople.org/perl-Shell-Config-Generate/perl-Shell-Config...
SRPM URL:
https://ppisar.fedorapeople.org/perl-Shell-Config-Generate/perl-Shell-Config...
Description:
This Perl module provides an interface for specifying shell configurations for
different shell environments without having to worry about the arcane
differences between shells such as csh, sh, cmd.exe and command.com.

Fedora Account System Username: ppisar

[Bug 1473678] Review Request: perl-Shell-Config-Generate - Portably generate configuration for any shell

https://bugzilla.redhat.com/show_bug.cgi?id=1473678

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1473663

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1473663
[Bug 1473663] Review Request: perl-Shell-Guess - Make an educated guess
about the shell in use

[Bug 1473678] Review Request: perl-Shell-Config-Generate - Portably generate configuration for any shell

https://bugzilla.redhat.com/show_bug.cgi?id=1473678

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1473705

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1473705
[Bug 1473705] Review Request: perl-Alien-Base-ModuleBuild - Perl framework
for building Alien:: modules and their libraries

[Bug 1473678] Review Request: perl-Shell-Config-Generate - Portably generate configuration for any shell

https://bugzilla.redhat.com/show_bug.cgi?id=1473678
Bug 1473678 depends on bug 1473663, which changed state.

Bug 1473663 Summary: Review Request: perl-Shell-Guess - Make an educated guess about the shell in use
https://bugzilla.redhat.com/show_bug.cgi?id=1473663

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE

[Bug 1473678] Review Request: perl-Shell-Config-Generate - Portably generate configuration for any shell

https://bugzilla.redhat.com/show_bug.cgi?id=1473678

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1473678] Review Request: perl-Shell-Config-Generate - Portably generate configuration for any shell

https://bugzilla.redhat.com/show_bug.cgi?id=1473678

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Shell-Config-Generate-0.26-1.fc27.noarch.rpm | sort |
uniq -c
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(Shell::Guess) >= 0.02
      1 perl(strict)
      1 perl(:VERSION) >= 5.8.1
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Shell-Config-Generate-0.26-1.fc27.noarch.rpm | sort |
uniq -c
      1 perl(Shell::Config::Generate) = 0.26
      1 perl-Shell-Config-Generate = 0.26-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Shell-Config-Generate*
perl-Shell-Config-Generate.noarch: W: spelling-error Summary(en_US) Portably ->
Port ably, Port-ably, Portable
perl-Shell-Config-Generate.noarch: W: spelling-error %description -l en_US csh
-> sch, cs, ch
perl-Shell-Config-Generate.noarch: W: spelling-error %description -l en_US cmd
-> cm, cad, cod
perl-Shell-Config-Generate.noarch: W: spelling-error %description -l en_US exe
-> ex, exes, exec
perl-Shell-Config-Generate.src: W: spelling-error Summary(en_US) Portably ->
Port ably, Port-ably, Portable
perl-Shell-Config-Generate.src: W: spelling-error %description -l en_US csh ->
sch, cs, ch
perl-Shell-Config-Generate.src: W: spelling-error %description -l en_US cmd ->
cm, cad, cod
perl-Shell-Config-Generate.src: W: spelling-error %description -l en_US exe ->
ex, exes, exec
2 packages and 1 specfiles checked; 0 errors, 8 warnings.
Rpmlint is ok

The package looks good.
Approved.

[Bug 1473678] Review Request: perl-Shell-Config-Generate - Portably generate configuration for any shell

https://bugzilla.redhat.com/show_bug.cgi?id=1473678

--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Shell-Config-Generat...

[Bug 1473678] Review Request: perl-Shell-Config-Generate - Portably generate configuration for any shell

https://bugzilla.redhat.com/show_bug.cgi?id=1473678

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |perl-Shell-Config-Generate-
                   |                            |0.26-1.fc27
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2017-08-03 10:19:43

--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.