[Bug 1460662] New: Review Request: rubygem-mustermann - A library using patterns like regular expressions

https://bugzilla.redhat.com/show_bug.cgi?id=1460662

Bug ID: 1460662
           Summary: Review Request: rubygem-mustermann - A library using
                    patterns like regular expressions
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://pagure.io/jaruga_rubygem-mustermann/raw/master/f/rubygem-mustermann....
SRPM URL:
https://pagure.io/jaruga_rubygem-mustermann/raw/master/f/rubygem-mustermann-...
Description: A library using patterns like regular expressions
Fedora Account System Username: jaruga

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=19993792

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

https://bugzilla.redhat.com/show_bug.cgi?id=1460662

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Vít Ondruch  ---
I'll take it for review ...

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

https://bugzilla.redhat.com/show_bug.cgi?id=1460662

--- Comment #2 from Vít Ondruch  ---
* Summary/Description
  - I'd say that the summary is misleading. The original (but capitalized)
would
    be better IMHO.
  - The description should start with capital letter.

* Group tag is deprecated
  - Please remove the Group tag. It is deprecated [1].

* Test {support,mustermann-contrib} libraries
  - It would be good to document why the {support,mustermann-contrib} is needed
    (e.g. "Support routines required by test suite").
  - I don't think there is any reason to expand these libraries into the
    .%{gem_instdir}. Although we are using this on several places, this is used
    typically to mimic the upstream repository layout. In this case, I think it
    would be much better to expand the sources using the %setup macro in %prep
    section, e.g.:

~~~
%setup -q -D -T -n  %{gem_name}-%{version} -b1 -b2
~~~

* Idiomatic test suite execution.
  - We typically execute the RSpec test suite via "rspec spec". If you need to
    specify additional path, the "rspec" command supports -I variable just as
    ruby does. E.g. this should work for you:

~~~
rspec -I{support,mustermann-contrib}/lib spec
~~~

[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

https://bugzilla.redhat.com/show_bug.cgi?id=1460662

--- Comment #3 from Vít Ondruch  ---
BTW there appears to be circular dependency with Sinatra, you should consider
to prepare Mustermann for bootstrap.

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

https://bugzilla.redhat.com/show_bug.cgi?id=1460662

--- Comment #4 from Jun Aruga  ---
Vit, thank you for the review.

I fixed those items that you mentioned.

1 point.
> %setup -q -D -T -n  %{gem_name}-%{version} -b1 -b2

Below "-b n" looks better regarding the official document' sample.

~~~
%setup -q -D -T -n  %{gem_name}-%{version} -b 1 -b 2
~~~

http://ftp.rpm.org/max-rpm/s1-rpm-inside-macros.html
> %setup -T -b 0

I updated below files.

Spec URL:
https://pagure.io/jaruga_rubygem-mustermann/raw/master/f/rubygem-mustermann....
SRPM URL:
https://pagure.io/jaruga_rubygem-mustermann/raw/master/f/rubygem-mustermann-...

Could you check again?
Thanks.

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

https://bugzilla.redhat.com/show_bug.cgi?id=1460662

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #5 from Vít Ondruch  ---
Just one minor nit. I'd move the seds out of the pushd/popd block, since they
are using absolute path now.

Otherwise the package looks good => APPROVED.

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

https://bugzilla.redhat.com/show_bug.cgi?id=1460662

--- Comment #6 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-mustermann

[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

https://bugzilla.redhat.com/show_bug.cgi?id=1460662

Jun Aruga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |rubygem-mustermann-1.0.0-1.
                   |                            |fc27
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2017-06-13 12:47:10

--- Comment #7 from Jun Aruga  ---
Thank you. I pushed the files including your additional mentioning item.