Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
Summary: Review Request: pixie - 3D renderer Renderman compliant Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kwizart@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: http://kwizart.free.fr/fedora/6/testing/pixie/pixie.spec SRPM URL: http://kwizart.free.fr/fedora/6/testing/pixie/pixie-2.1.1-1.kwizart.fc6.src.... Description: 3D renderer Renderman compliant
rpmlint complaint about non-executable scripts and wrong script interpreter about shaders but theses files aren't mean to be executed...
tested in mock Fedora Core 6 on x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
lephilousophe@users.sourceforge.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lephilousophe@users.sourcefo | |rge.net
------- Additional Comments From lephilousophe@users.sourceforge.net 2007-05-28 09:57 EST ------- RPMLint output is empty Compiles under mock fc6-i386
URL of the package is bad : cf http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6e...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |lxtnow@gmail.com Flag| |fedora-review?
------- Additional Comments From lxtnow@gmail.com 2007-05-30 22:08 EST ------- [in reply to comment #1]
+1
--
Avoid to use as more possible a mirror url from sourceforge website. So, the use of "source0: download.sourceforge.net/pixie/Pixie-2.1.1.tgz" is more appropriate. ;)
-------------------------------------
Starting review....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From lxtnow@gmail.com 2007-06-02 13:08 EST ------- Created an attachment (id=155990) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=155990&action=vie...) pixie-2.1.1-build.log
Mock failed on FC-6 and F-7 (i386) and seem freeze on x86_64. see build log for details.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From kwizart@gmail.com 2007-06-02 14:38 EST ------- g++: Internal error: Killed (program cc1plus) You should say it if you killed the compiler!
As state in a doc file, compilation take a lot of time because of optimization... It takes about 20min on my dual core
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From lxtnow@gmail.com 2007-06-02 19:40 EST ------- ^^ nope, i don't send kill signal to g++.
i will re-launch the build to check
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From kwizart@gmail.com 2007-06-03 17:23 EST ------- OK i get wrong it takes around two hours to compile on x86_64 for Fedora 7 with my AMD64 X2 (it take less time on x86)... I have 2go of dual channel memory... The system is instable during this indeed...
My ISP website is offline... Here is a mirror: Spec URL: http://kwizartchitecture.free.fr/fedora/7/testing/Pixie/pixie.spec SRPM URL: http://kwizartchitecture.free.fr/fedora/7/testing/Pixie/pixie-2.1.1-1.kwizar... Description: 3D renderer Renderman compliant
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From kwizart@gmail.com 2007-06-03 17:24 EST ------- Well also about URL for sourceforge... All others URL format are failing, This is the only format that can retrieve sources...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From lxtnow@gmail.com 2007-06-06 17:13 EST ------- mock's on its way
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From lxtnow@gmail.com 2007-06-06 23:55 EST ------- it seem still failed to build on my virtual machines with same error above. i will try on physical one by tomorrow.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-06-07 02:52 EST ------- (In reply to comment #5)
^^ nope, i don't send kill signal to g++.
i will re-launch the build to check
Perhaps killed by OOM (Out Of Memory) killer...
On my machine (with 768M RAM + about 780M swaps), g++ on execute.cpp ate all memory + swap and finally was killed by OOM killer...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-06-07 02:58 EST ------- Perhaps you can see the message in /var/log/messages like this: ---------------------------------------------------------------- Jun 7 15:46:50 localhost kernel: printk: 6 messages suppressed. Jun 7 15:46:50 localhost kernel: xterm invoked oom-killer: gfp_mask=0x201d2, order=0, oomkilladj=0 Jun 7 15:46:51 localhost kernel: [<c045c844>] out_of_memory+0x69/0x185 <snip> Jun 7 15:47:07 localhost kernel: Out of memory: kill process 9504 (g++) score 129440 or a child Jun 7 15:47:07 localhost kernel: Killed process 9505 (cc1plus) ---------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From lxtnow@gmail.com 2007-06-09 20:58 EST ------- Hi Mamoru,
i'll check this out and launch the test on my main machine which has 2go of memory (dual channel)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-06-09 22:03 EST ------- Okay. Please go again. Actually rebuilding this package is too heavy for my machine...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From lxtnow@gmail.com 2007-06-15 20:03 EST ------- Well,
Same things with my main machine :( it seem that we need a powerfull config to make this package build on x86_64. Rebuilt on i386 and after few hour successfully done.
Nicolas, could you upload the build log from x86_64 ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora
------- Additional Comments From lxtnow@gmail.com 2007-06-21 09:38 EST ------- ping
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From kwizart@gmail.com 2007-06-21 17:23 EST ------- I will submit build for x86_64 next week-end...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From kwizart@gmail.com 2007-06-27 15:39 EST ------- Created an attachment (id=158048) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=158048&action=vie...) fedora-7-x86_64 build.log
This take around one hour to build on my amd64 x2 4200+ with 2GO dual channel...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From lxtnow@gmail.com 2007-07-07 23:30 EST ------- Ok,
Starting review...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From lxtnow@gmail.com 2007-07-14 00:48 EST ------- === REQUIRED ITEMS ===
[ FAILED ] Package is named according to the Package Naming Guidelines. [ FAILED ] Spec file name must match the base package name. [ OK ] Package meets the Packaging Guidelines. [ OK ] Package successfully builds into binary rpms on at least one supported architecture. [ CHECK ] Tested on: Mock i386 [FC-devel]
[ OK ] Package is not relocatable. [ OK ] Buildroot is correct [ OK ] Package is licensed with an open-source compatible license. [ Ok ] License field in the package spec file matches the actual license. [ OK ] License type: LGPL [ OK ] The source package includes the text of the license(s). [ OK ] Spec file is legible and written in American English. [ OK ] Package is not known to require ExcludeArch. [ OK ] All build dependencies are listed in BuildRequires. [ CHECK ] The spec file handles locales properly. [ OK ] ldconfig called in %post and %postun if required. [ ? ] Package must own all directories that it creates. [ OK ] Package requires other packages for directories it uses. [ OK ] Package does not contain duplicates in %files. [ Ok ] Permissions on files are set properly. [ OK ] Package has a %clean section. [ OK ] Package consistently uses macros. [ OK ] Package contains code, or permissable content. [ ? ] Large documentation files are in a -doc subpackage, if required. [ ? ] Package uses nothing in %doc for runtime. [ SKIP ] Header files in -devel subpackage, if present. [ SKIP ] Static libraries in -devel subpackage, if present. [ SKIP ] Package requires pkgconfig, if .pc files are present. [ Ok ] Development .so files in -devel subpackage, if present. [ Ok ] Fully versioned dependency in subpackages, if present. [ OK ] Package does not contain any libtool archives (.la). [ SKIP ] Package contains a properly installed %{name}.desktop file. [ OK ] Package does not own files or directories owned by other packages. [ CHECK ] Requires: libGL.so.1()(64bit) libGLU.so.1()(64bit) libHalf.so.4()(64bit) libIex.so.4()(64bit) libIlmImf.so.4()(64bit) libImath.so.4()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libdl.so.2()(64bit) libdl.so.2(GLIBC_2.2.5)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libpixiecommon.so.0()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libri.so.0()(64bit) libsdr.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libtiff.so.3()(64bit) libz.so.1()(64bit) rtld(GNU_HASH)
=== ISSUES ===
# Package Name:
The base package name is Pixie (with upper-case letter). Please move it to Pixie instead of pixie. That's also imply to move the name of spec file to the right one.
# Timestamps action:
This package have many text/documentations files and png/icons files so keeping timestamps is desirable. Does this package accept 'make INSTALL="install -p" install' ?
# Some concerns about Large documentation:
The final package is mostly documentation.I don't think it's mandatory that it be split into a -doc subpackage. But, it'll be not a bad idea to do so. Also, any reason to mkdir'ed __doc (with double underscore) ?
# Ownership:
Currently your %file section (main package) sound good. however, i've some comment about ownership (which can be improved). ---------- %dir %{_libdir}/Pixie %{_libdir}/Pixie/displays/ %{_libdir}/Pixie/modules/ ---------- The use of %{_libdir}/Pixie is enough and owned by the package (including sub-folders)
---------- %dir %{_datadir}/Pixie %dir %{_datadir}/Pixie/shaders %{_datadir}/Pixie/shaders/*.sdr %{_datadir}/Pixie/shaders/*.sl ---------- You don't need to own sub-folders if you already own parent directory. And, As above, this can be improved by %{_datadir}/Pixie (which's enough to be owned)
# Quick request:
Nicolas, will you upload somewhere the packaged x86_64 binaries please ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: pixie - 3D |Review Request: Pixie - 3D |renderer Renderman compliant|renderer Renderman compliant
------- Additional Comments From kwizart@gmail.com 2007-07-14 15:49 EST ------- Ok, so... - Update to 2.2.1 - Rename to Pixie - Preserve timestamp at install step - Improve directory ownership - Move docs to sub-package - Add a dyn patch to link to shared ftgl
# Quick answear: The rpm package was already in the same directory for x86_64 (previous version)
Spec URL: http://kwizart.free.fr/fedora/6/testing/Pixie/Pixie.spec SRPM URL: http://kwizart.free.fr/fedora/6/testing/Pixie/Pixie-2.2.1-1.kwizart.fc6.src.... Description: 3D renderer Renderman compliant
I've tested to rebuild autotools because if sometime solve the rpath issue at source... But not in this case! so i leave it commented...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From kwizart@gmail.com 2007-07-15 09:01 EST ------- ok i finally experienced this Out of memory: kill process 9504 (g++) score... (only on x86_64 tought - i386 built fine) I will give a retry, but i think this is more related to swap size (as kswapd has taken most of the ressources - top command show it)... I will give a retry with more swap size (i currently have 2Gio of RAM and 3Gio of swap size)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From lxtnow@gmail.com 2007-07-15 15:44 EST ------- [comment #20] Sound Good. Will you also upload the updated packages x86_64 (including -doc and -devel sub-packages and build.log) thanks.
[comment #21] :-).... if this happened with the updated release ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From lxtnow@gmail.com 2007-07-16 15:01 EST ------- Well, Checked on mock_i386
# About timestamps action
'make INSTALL="install -p" install' doesn't sounds to work well on docs/images files as we want. 'Cause the Makefile called install-sh script to install all shipped data. So you will have to sed or patch the Makefile. Or also, if you like improvment, try this in %install stage 'make install_sh_DATA="$(install_sh) -c -pm 0644" install'
# Sub-packages
-libs and -devel subpackage don't seem good. this: %{_libdir}/*.so should be moved to -devel. this: %{_libdir}/*.so.* should be moved to -lib(s) if other applications require them for developing work, otherwhise keeping them in main package it's good.
Also, don't forget to upload packaged x86_64 rpm files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From lxtnow@gmail.com 2007-07-25 17:43 EST ------- ping ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From kwizart@gmail.com 2007-08-15 15:59 EST ------- Spec URL: http://kwizart.free.fr/fedora/6/testing/Pixie/Pixie.spec SRPM URL: http://kwizart.free.fr/fedora/6/testing/Pixie/Pixie-2.2.2-1.kwizart.fc7.src.... Description: 3D renderer Renderman compliant
building in mock x86_64 (fc6) might need to test also in devel and maybe ppc (ppc64)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-08-15 23:46 EST ------- Failed at least on ppc64, both rawhide & F-7, perhaps due to OOM killer *on koji*.
http://koji.fedoraproject.org/koji/taskinfo?taskID=104258 (rawhide) http://koji.fedoraproject.org/koji/taskinfo?taskID=104314 (F-7)
IMO codes must be fixed to reduce the burden on compilation anyway...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549
------- Additional Comments From lxtnow@gmail.com 2007-08-23 09:49 EST ------- ping !
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/show_bug.cgi?id=241549
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(kwizart@gmail.com)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/show_bug.cgi?id=241549
kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(kwizart@gmail.com)|
------- Additional Comments From kwizart@gmail.com 2007-08-26 08:46 EST ------- Well i don't know if it is normal for 64bit arch to need hours to compile instead of 10min for 32bit... Upstream says it takes times because of some expensive optimized macros within the source code. I supposed that theses macros needed a lot of swap size (Mamoru: do you know how much swap have the koji builders?) I expect that it needs around 5Gio , maybe more (3Gio was used when it fails on x86_64 for me - swap was full and kswap took lot of cpu time before OOM killer).
There is some changes upstream in the rib.c, maybe I can backport this change and see if something is better, anyway, i will try to contact upstream about this subject...
------- Additional Comments From kwizart@gmail.com 2007-08-26 08:49 EST ------- @Mamoru thx for this test!
I will try to backport changes from cvs...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/show_bug.cgi?id=241549
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-08-26 13:44 EST ------- (In reply to comment #26)
Failed at least on ppc64, both rawhide & F-7, perhaps due to OOM killer *on koji*.
http://koji.fedoraproject.org/koji/taskinfo?taskID=104258 (rawhide) http://koji.fedoraproject.org/koji/taskinfo?taskID=104314 (F-7)
IMO codes must be fixed to reduce the burden on compilation anyway...
Well, I retried and this time it was okay for all arch...
http://koji.fedoraproject.org/koji/taskinfo?taskID=129921
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/show_bug.cgi?id=241549
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From lxtnow@gmail.com 2007-09-05 05:40 EST ------- Okay, All issues has been fixed.
This package can be apporved now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/show_bug.cgi?id=241549
kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From kwizart@gmail.com 2007-09-05 09:21 EST ------- New Package CVS Request ======================= Package Name: Pixie Short Description: 3D renderer Renderman compliant Owners: kwizart Branches: devel FC-6 F-7 EL-4 EL-5 InitialCC: <empty> Commits by cvsextras: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/show_bug.cgi?id=241549
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-09-05 17:28 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Pixie - 3D renderer Renderman compliant
https://bugzilla.redhat.com/show_bug.cgi?id=241549
kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla