[Bug 1292295] New: Review Request: nodejs-is-windows - Returns true if the platform is windows
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
Bug ID: 1292295 Summary: Review Request: nodejs-is-windows - Returns true if the platform is windows Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-is-windows/nodejs-is-window... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-is-windows/nodejs-is-window... Description: Returns true if the platform is windows Fedora Account System Username: jsmith
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews), | |1292287
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1292287 [Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |piotr1212@gmail.com Assignee|nobody@fedoraproject.org |piotr1212@gmail.com Flags| |fedora-review+
--- Comment #1 from Piotr Popieluch piotr1212@gmail.com --- I guess this is will be the most useless package in the Fedora package collection ;)
All is ok, APPROVED
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/piotr/rpmbuild/1292295-nodejs-is-windows/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-is-windows-0.1.0-1.fc24.noarch.rpm nodejs-is-windows-0.1.0-1.fc24.src.rpm nodejs-is-windows.noarch: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory nodejs-is-windows.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Requires -------- nodejs-is-windows (rpmlib, GLIBC filtered): nodejs(engine)
Provides -------- nodejs-is-windows: nodejs-is-windows npm(is-windows)
Source checksums ---------------- https://registry.npmjs.org/is-windows/-/is-windows-0.1.0.tgz : CHECKSUM(SHA256) this package : 97e5a64ca9d49db0332cb5f55d4b18fef52ced803a83f6b8d9bc1f8931fa7ceb CHECKSUM(SHA256) upstream package : 97e5a64ca9d49db0332cb5f55d4b18fef52ced803a83f6b8d9bc1f8931fa7ceb https://raw.githubusercontent.com/jonschlinkert/is-windows/master/test.js : CHECKSUM(SHA256) this package : e0b908e2bc1e39a936a7bf1f20f889f6c6a9eba2978ec65555c418a096d02e48 CHECKSUM(SHA256) upstream package : e0b908e2bc1e39a936a7bf1f20f889f6c6a9eba2978ec65555c418a096d02e48
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1292295 -x CheckOwnDirs Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
--- Comment #2 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-is-windows
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- nodejs-is-windows-0.1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-c48e4ee695
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- nodejs-is-windows-0.1.0-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-05b419bd7c
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- nodejs-is-windows-0.1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-bc8283a34e
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- nodejs-is-windows-0.1.0-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-516682f7f0
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- nodejs-is-windows-0.1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update nodejs-is-windows' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-c48e4ee695
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- nodejs-is-windows-0.1.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update nodejs-is-windows' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-516682f7f0
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- nodejs-is-windows-0.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update nodejs-is-windows' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-bc8283a34e
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed| |2015-12-20 13:14:10
--- Comment #10 from Piotr Popieluch piotr1212@gmail.com --- Built in rawhide, closing to unblock other review requests.
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords| |Reopened
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- nodejs-is-windows-0.1.0-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-05b419bd7c
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- nodejs-is-windows-0.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2015-12-20 13:14:10 |2016-02-07 21:24:03
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- nodejs-is-windows-0.1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- nodejs-is-windows-0.1.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1292295
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- nodejs-is-windows-0.1.0-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla