[Bug 437981] New: Review Request: eigen - A lightweight C++ template library for vector and matrix math
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=437981
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/eigen/eigen.spec SRPM URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/eigen/eigen-1.0.5-1.src.rpm Description: Eigen is a lightweight C++ template library for vector and matrix math, a.k.a. linear algebra.
$ rpmlint *.rpm eigen.src: W: invalid-license GPLv2+ with exceptions eigen-devel.noarch: W: invalid-license GPLv2+ with exceptions bah. :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |kevin@tigcc.ticalc.org Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From kevin@tigcc.ticalc.org 2008-03-18 11:29 EST ------- I'll review this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
------- Additional Comments From kevin@tigcc.ticalc.org 2008-03-18 11:37 EST ------- Hmmm, this seems to want graphviz and latex to build the documentation (it uses them on my "fully" populated system, at least), so I think those should be BRed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
------- Additional Comments From kevin@tigcc.ticalc.org 2008-03-18 11:41 EST ------- Oh, and what rpmlint are you using? That License tag is valid according to the Fedora license list, and the rpmlint-0.82-2.fc8 I'm using doesn't spit out those false warnings. (I get empty output from rpmlint, which is good. :-) )
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
------- Additional Comments From rdieter@math.unl.edu 2008-03-18 11:48 EST ------- Built/checked on fc7. Doh on the graphviz (my bad for not using mock).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
------- Additional Comments From kevin@tigcc.ticalc.org 2008-03-18 11:53 EST ------- Don't forget texlive-latex too, it's used to convert the formulas in the doxygen documentation to images for the HTML.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
------- Additional Comments From rdieter@math.unl.edu 2008-03-18 12:02 EST ------- Spec URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/eigen/eigen.spec SRPM URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/eigen/eigen-1.0.5-2.src.rpm
%changelog * Tue Mar 18 2008 Rex Dieter rdieter@fedoraproject.org 1.0.5-2 - BR: graphviz tex(latex) - -devel: Provides: %%name (compat with other distros)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From kevin@tigcc.ticalc.org 2008-03-18 13:04 EST ------- MUST Items: + rpmlint output: none + named and versioned according to the Package Naming Guidelines: + spec file name matches base package name + Packaging Guidelines: + License GPLv2+ with exceptions OK, matches actual license + No known patent problems + No emulator, no firmware, no binary-only or prebuilt components + Complies with the FHS + proper changelog, tags, BuildRoot, Requires, BuildRequires, Summary, Description + no non-UTF-8 characters + relevant documentation included + nothing to compile, so RPM_OPT_FLAGS are irrelevant + nothing to compile (noarch package), so no debuginfo package + no static libraries nor .la files + no duplicated system libraries + no binaries => no rpaths + no configuration files, so %config guideline doesn't apply + no init scripts, so init script guideline doesn't apply + no GUI executables, so no .desktop file needed + ... and thus no desktop-file-install needed either + no timestamp-clobbering file commands + _smp_mflags used + scriptlets are valid + not a web application, so web application guideline doesn't apply + no conflicts + complies with all the legal guidelines + license included as %doc + source matches upstream: MD5SUM: 960d7e5fb6542270eae4d53ca99b607c SHA1SUM: 32400616c4866eab158115c556df330b077644a3 + builds on at least one arch (F8 i386) + no known non-working arches, so no ExcludeArch needed + BuildRequires are complete (cmake, doxygen, graphviz, tex(latex)) + no translations, so translation/locale guidelines don't apply + no shared libraries, so no ldconfig call needed + package not relocatable + ownership correct (owns package-specific directories, doesn't own directories owned by another package) + no duplicate files in %files + permissions correct, defattr used correctly + %clean section present and correct + macros used where possible + no non-code content + no large documentation files, so no -doc package needed + %doc files not required at runtime + all header files in -devel + no static libraries, so no -static package needed + no .pc files, so no Requires: pkgconfig needed + no .so symlinks vs. plugins + no main package (as this is a headers-only library), -devel Provides: %{name} = %{version}-%{release} instead, OK + no .la files + no GUI executables, so no .desktop file needed + buildroot is deleted at the beginning of %install + all filenames are valid UTF-8
SHOULD Items: + license included as %doc + no translations for description and summary provided by upstream * skipping mock test * skipping all arch test * skipping functionality test + scriptlets are sane + no subpackages other than -devel, so "Usually, subpackages other than devel should require the base package using a fully versioned dependency." is irrelevant + no .pc files, so "placement of .pc files" is irrelevant + no file dependencies
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From rdieter@math.unl.edu 2008-03-18 13:10 EST ------- New Package CVS Request ======================= Package Name: eigen Short Description: A lightweight C++ template library for vector and matrix math Owners: rdieter, kkofler Branches: EL-5 F-7 F-8 Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-03-18 13:44 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From rdieter@math.unl.edu 2008-03-18 15:26 EST ------- imported, built for rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
------- Additional Comments From updates@fedoraproject.org 2008-03-18 15:36 EST ------- eigen-1.0.5-2.fc8 has been submitted as an update for Fedora 8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
------- Additional Comments From updates@fedoraproject.org 2008-03-21 18:13 EST ------- eigen-1.0.5-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eigen - A lightweight C++ template library for vector and matrix math
https://bugzilla.redhat.com/show_bug.cgi?id=437981
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |CLOSED Resolution|NEXTRELEASE |CURRENTRELEASE Fixed In Version| |1.0.5-2.fc8
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla