[Bug 1506428] New: Split GNOME Shell extension HistoryManager Prefix Search into a separate package
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
Bug ID: 1506428 Summary: Split GNOME Shell extension HistoryManager Prefix Search into a separate package Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: andrew@tosk.in QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Package name: gnome-shell-extension-sustmi-historymanager-prefix-search
Formerly a subpackage of gnome-shell-extension-sustmi
Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-historymanager...
SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-historymanager-prefix-searc...
Description: The GNOME Shell Run Command dialog (Alt-F2) and Looking Glass let you cycle through the history of previous commands with the arrow keys, but there's currently no built-in way to search or do autocompletion for commands. With HistoryManager Prefix Search, you can type the beginning of a command, and then hit the PageUp and PageDown keys to cycle through previous commands which match the prefix you typed.
Fedora Account System Username: terrycloth
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
--- Comment #1 from Andrew Toskin andrew@tosk.in --- Oops, the *new* package name will be gnome-shell-extension-historymanager-prefix-search (without "sustmi" in the middle).
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- - Please edit the bug title to follow the pattern for RR:
Review Request: gnome-shell-extension-historymanager-prefix-search - Use PageUp and PageDown to search for previous GNOME Shell commands
Otherwise you won't pe able to use fedrepo-req when the puckage is accepted.
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
Andrew Toskin andrew@tosk.in changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Split GNOME Shell extension |Review Request: |HistoryManager Prefix |gnome-shell-extension-histo |Search into a separate |rymanager-prefix-search - |package |Use PageUp and PageDown to | |search for previous GNOME | |Shell commands
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
Troy Curtis troycurtisjr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |troycurtisjr@gmail.com
--- Comment #3 from Troy Curtis troycurtisjr@gmail.com --- Since this package does not have any schemas, probably do not need the BuildRequires on glib for CentOS/RHEL 7.
According to my repoquery, nothing currently depends on 'gnome-shell-extension-sustmi-historymanager-prefix-search', so I don't think you need the Provides line for the old name.
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
--- Comment #4 from Andrew Toskin andrew@tosk.in --- Oh, yeah, that BuildRequires tag was leftover from when this was one of two subpackages; the other did have schemas, this one does not.
I guess I read the The "Upgrade Paths" Fedora wiki page too quickly. Anything depending on these recently added GNOME Shelle extensions seems pretty unlikely, so yeah, I guess the Provides tag was also unnecessary.
I've removed both the BuildRequires and Provides tags. Same URLs.
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- Hello again Andrew,
- Please use a more meaningful name for your archive, with:
Source0: https://github.com/sustmi/%%7Bname%7D/archive/v%%7Bversion%7D/%%7Bname%7D-%%...
Package is fine otherwise, it is accepted.
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
--- Comment #6 from Andrew Toskin andrew@tosk.in ---
Please use a more meaningful name for your archive
Done.
Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-historymanager...
SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-historymanager-prefix-searc...
I'm not positive about this part of the process, but I've also opened an issue on RelEng's Pagure about splitting the packages.
https://pagure.io/releng/issue/7124
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
--- Comment #7 from Andrew Toskin andrew@tosk.in --- Is there anything else I need to do before the newly split package can be accepted...?
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
Rex Dieter rdieter@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@gmail.com
--- Comment #8 from Rex Dieter rdieter@gmail.com --- Next steps (for submitter/maintainer):
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=Pa...
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
--- Comment #9 from Andrew Toskin andrew@tosk.in --- THANK YOU. That step was not mentioned in the wiki page about splitting packages, and it didn't occur to me to treat the newly split packages so much like creating whole new packages from scratch.
However, now I have a new problem: fedrepo-req reports "Error: The Bugzilla bug's review was approved over 60 days ago"
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
--- Comment #10 from Andrew Toskin andrew@tosk.in --- Rex, could you maybe mark this as approved again? Along with the other split package, in Bug #1506429?
Or do I have to start over with a new review request, even though the packages haven't changed since October?
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #11 from Robert-André Mauchin zebob.m@gmail.com --- Rex is probably very busy
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
--- Comment #12 from Andrew Toskin andrew@tosk.in --- Cool, thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
--- Comment #13 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-historymanager-pref...
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- gnome-shell-extension-historymanager-prefix-search-10-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b866dfc687
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- gnome-shell-extension-historymanager-prefix-search-10-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a458392fef
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- gnome-shell-extension-historymanager-prefix-search-10-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a458392fef
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- gnome-shell-extension-historymanager-prefix-search-10-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-b866dfc687
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-02-13 12:37:37
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- gnome-shell-extension-historymanager-prefix-search-10-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- gnome-shell-extension-historymanager-prefix-search-10-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com